Correct TerminalApp.LocalTests failures #10148

Closed
opened 2026-01-31 02:13:47 +00:00 by claunia · 2 comments
Owner

Originally created by @miniksa on GitHub (Aug 13, 2020).

Originally assigned to: @miniksa on GitHub.

With the tests being re-enabled with Helix in automation, I've turned off the ones that are failing. They need to be fixed and restored.

This is the list for TerminalApp.LocalTests:

Originally created by @miniksa on GitHub (Aug 13, 2020). Originally assigned to: @miniksa on GitHub. With the tests being re-enabled with Helix in automation, I've turned off the ones that are failing. They need to be fixed and restored. This is the list for TerminalApp.LocalTests: - `SettingsTests::TestCommandsAndKeybindings` - `CommandTests::TestAutogeneratedName` - `SettingsTests::ValidateExecuteCommandlineWarning` - Is also #6949. - `TabTests::TryDuplicateBadPane` - Is also #5169 - `TabTests::TryDuplicateBadTab` - Is also #5169
Author
Owner

@miniksa commented on GitHub (Aug 13, 2020):

These 3 seem to be skipped already, but Helix is still reporting them as fail.... why...

  • SettingsTests::ValidateExecuteCommandlineWarning
  • TabTests::TryDuplicateBadPane
  • TabTests::TryDuplicateBadTab
@miniksa commented on GitHub (Aug 13, 2020): These 3 seem to be skipped already, but Helix is still reporting them as fail.... why... - `SettingsTests::ValidateExecuteCommandlineWarning` - `TabTests::TryDuplicateBadPane` - `TabTests::TryDuplicateBadTab`
Author
Owner

@miniksa commented on GitHub (Aug 13, 2020):

Why = #7286

@miniksa commented on GitHub (Aug 13, 2020): Why = #7286
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10148