starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

RendererDtorAndThread unit tests are sometimes hanging #7286

New Issue
Open
opened 2026-01-31 01:00:11 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 01:00:11 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Apr 5, 2020).

Environment

Windows build number: Version 10.0.18362.657
Windows Terminal version (if applicable): Commit 4f8acb4b9f

Steps to reproduce

In a cmd.exe shell, in the tools directory, run the RendererDtorAndThread tests repeatedly like this:

for /L %i in (1,1,1000) do runut /name:*RendererDtorAndThread*

Expected behavior

The tests should complete successfully every time.

Actual behavior

Invariably one of the runs will hang. It's not that big a deal when testing locally, because it doesn't happen that often, but it's annoying when it causes the CI build to timeout when submitting a PR (which I've had happen a couple of time now).

After reproducing the hang locally, I attaching to the process in a debugger, and found that the RenderThread was stuck waiting for the _hPaintEnabledEvent. I also noticed that the these tests used to have a Sleep which I think was added specifically to prevent this from happening. See here:

8476040481/src/host/ut_host/VtIoTests.cpp (L360-L365)

Uncommenting those Sleep calls seem to fix the problem, although the tests do then take much longer to run.

Originally created by @j4james on GitHub (Apr 5, 2020). # Environment Windows build number: Version 10.0.18362.657 Windows Terminal version (if applicable): Commit 4f8acb4b9fbd61196d0a5287749a58abe0fbaa28 # Steps to reproduce In a _cmd.exe_ shell, in the _tools_ directory, run the `RendererDtorAndThread` tests repeatedly like this: for /L %i in (1,1,1000) do runut /name:*RendererDtorAndThread* # Expected behavior The tests should complete successfully every time. # Actual behavior Invariably one of the runs will hang. It's not that big a deal when testing locally, because it doesn't happen that often, but it's annoying when it causes the CI build to timeout when submitting a PR (which I've had happen a couple of time now). After reproducing the hang locally, I attaching to the process in a debugger, and found that the `RenderThread` was stuck waiting for the `_hPaintEnabledEvent`. I also noticed that the these tests used to have a `Sleep` which I think was added specifically to prevent this from happening. See here: https://github.com/microsoft/terminal/blob/8476040481a7459d3b6deb94b498262c5cfeb5a4/src/host/ut_host/VtIoTests.cpp#L360-L365 Uncommenting those `Sleep` calls seem to fix the problem, although the tests do then take much longer to run.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Area-CodeHealth Issue-Bug Needs-Attention Needs-Tag-Fix Priority-1 Product-Meta Resolution-No-Repro
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7286
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?