starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Panes should have editable titles #10160

New Issue
Open
opened 2026-01-31 02:14:02 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 02:14:02 +00:00
Owner
Copy Link

Originally created by @HunterMitchell on GitHub (Aug 14, 2020).

Originally assigned to: @HunterMitchell on GitHub.

Description of the new feature/enhancement

Having a title per tab is nice, but I have run into situations where I would much rather name each pane to help with multitasking. I have not seen this feature listed on #1000 and I feel like this can be of use for #7075. Below is Terminator on linux. Double-clicking the title allows editing and the title bar can be click-dragged to move panes around.
terminator

Originally created by @HunterMitchell on GitHub (Aug 14, 2020). Originally assigned to: @HunterMitchell on GitHub. # Description of the new feature/enhancement Having a title per tab is nice, but I have run into situations where I would much rather name each pane to help with multitasking. I have not seen this feature listed on #1000 and I feel like this can be of use for #7075. Below is Terminator on linux. Double-clicking the title allows editing and the title bar can be click-dragged to move panes around. ![terminator](https://user-images.githubusercontent.com/6901336/90219642-1c888f80-ddcc-11ea-9d32-83d12f321d29.png)
claunia added the Issue-FeatureHelp WantedProduct-TerminalArea-UserInterface labels 2026-01-31 02:14:02 +00:00
claunia commented 2026-01-31 02:14:02 +00:00
Author
Owner
Copy Link

@HunterMitchell commented on GitHub (Aug 14, 2020):

Currently working on a PR for this feature.

@HunterMitchell commented on GitHub (Aug 14, 2020): Currently working on a PR for this feature.
claunia commented 2026-01-31 02:14:03 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 14, 2020):

I'm okay with this feature, as long as we make it disable-able with a setting ☺️

@zadjii-msft commented on GitHub (Aug 14, 2020): I'm okay with this feature, as long as we make it disable-able with a setting ☺️
claunia commented 2026-01-31 02:14:03 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 15, 2020):

This fits in with the vision I have of panes having titlebars, yeah. I'm yanking Triage 😄

@DHowett commented on GitHub (Aug 15, 2020): This fits in with the vision I have of panes having titlebars, yeah. I'm yanking Triage :smile:
claunia commented 2026-01-31 02:14:03 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 15, 2020):

Titlebars make good drag handles for reordering... and snapping... and everything. This almost blocks that. I'm surprised we didn't have a workitem for it!

@DHowett commented on GitHub (Aug 15, 2020): Titlebars make good drag handles for reordering... and snapping... and everything. This almost blocks that. I'm surprised we didn't have a workitem for it!
claunia commented 2026-01-31 02:14:03 +00:00
Author
Owner
Copy Link

@HunterMitchell commented on GitHub (Aug 17, 2020):

I will be creating a draft PR soon, but had a few questions I wanted to run past you guys ( @zadjii-msft / @DHowett ). Since this pane titlebar is global, I assume it should be located in the GlobalAppSettings. Below is what I'm currently thinking these settings should look like.

{
    "paneTitlebar": {
        "show": true,
        "backgroundColor": "#FF0000",
        "foregroundColor": "#000000"
    }
}

On another note, most of my edits are in "Pane.h/Pane.cpp". Am I missing something, or is there not an easy way to get GlobalAppSettings? Maybe I missing something due to my lack of sleep lately 😁.

What I have so far (would like to see some border customization to match a theme down the road):
pane-titlebar

@HunterMitchell commented on GitHub (Aug 17, 2020): I will be creating a draft PR soon, but had a few questions I wanted to run past you guys ( @zadjii-msft / @DHowett ). Since this pane titlebar is global, I assume it should be located in the GlobalAppSettings. Below is what I'm currently thinking these settings should look like. ```json { "paneTitlebar": { "show": true, "backgroundColor": "#FF0000", "foregroundColor": "#000000" } } ``` On another note, most of my edits are in "Pane.h/Pane.cpp". Am I missing something, or is there not an easy way to get GlobalAppSettings? Maybe I missing something due to my lack of sleep lately 😁. What I have so far (would like to see some border customization to match a theme down the road): ![pane-titlebar](https://user-images.githubusercontent.com/6901336/90385372-a775be00-e048-11ea-90c3-4b6359b06627.gif)
claunia commented 2026-01-31 02:14:03 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 17, 2020):

Okay first off, that's amazing. Great work!

Secondly: I'd maybe hold off on the foreground/background color configuration until after #3327/#5772. Those are properties that IMO make more sense to be part of the visual "theme", which is a concept we're still working on. We're planning on throwing all sorts of visual customizations in there, including tab colors, titlebar colors, pane border colors, etc, so I think that's probably the best place for those settings to eventually live. I think for now we should probably just stick with some theme color to use as the pane titlebar BG. I'm really excited to see the possibility for colors in the (near) future though!

Third: Yea, the app settings are pretty hard to get at from Pane. You've gotta use const auto& settings = CascadiaSettings::GetCurrentAppSettings(); to get at the CascadiaSettings instance.

Forthly: I keep watching that gif and seeing new additional things you've already implemented in the pane title and I'm just constantly impressed. You've already got the context menu and double click renaming down. That's awesome. I'm excited.

@zadjii-msft commented on GitHub (Aug 17, 2020): Okay first off, that's amazing. Great work! Secondly: I'd _maybe_ hold off on the foreground/background color configuration until after #3327/#5772. Those are properties that IMO make more sense to be part of the visual "theme", which is a concept we're still working on. We're planning on throwing all sorts of visual customizations in there, including tab colors, titlebar colors, pane border colors, etc, so I think that's probably the best place for those settings to eventually live. I think for now we should probably just stick with some theme color to use as the pane titlebar BG. I'm really excited to see the possibility for colors in the (near) future though! Third: Yea, the app settings are pretty hard to get at from `Pane`. You've gotta use `const auto& settings = CascadiaSettings::GetCurrentAppSettings();` to get at the `CascadiaSettings` instance. Forthly: I keep watching that gif and seeing new additional things you've already implemented in the pane title and I'm just constantly impressed. You've already got the context menu and double click renaming down. That's awesome. I'm excited.
claunia commented 2026-01-31 02:14:04 +00:00
Author
Owner
Copy Link

@HunterMitchell commented on GitHub (Aug 18, 2020):

I really appreciate the feedback and I'm pretty excited for theme support myself! It's been a hot minute since I've written some C++, so adding this feature I would like myself gave me the motivation to get back in the C++ realm.

I think for now we should probably just stick with some theme color to use as the pane titlebar BG.

Do you have a specific color in mind? You already know I have to support red, but I assume it needs to be some neutral color for now.

@HunterMitchell commented on GitHub (Aug 18, 2020): I really appreciate the feedback and I'm pretty excited for theme support myself! It's been a hot minute since I've written some C++, so adding this feature I would like myself gave me the motivation to get back in the C++ realm. > I think for now we should probably just stick with some theme color to use as the pane titlebar BG. Do you have a specific color in mind? You already know I have to support red, but I assume it needs to be some neutral color for now.
claunia commented 2026-01-31 02:14:04 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 19, 2020):

What if we started with the ChromeLow theme resource for now, and we'll let the design experts weigh in for the PR? 😉 That'll give us "a little darker" in dark theme, and "a little lighter" in light theme.

For the record, the titlebar uses ChromeDisabledHigh by default:

image

(from https://docs.microsoft.com/en-us/windows/uwp/design/controls-and-patterns/xaml-theme-resources)

Sound good?

EDIT Oh man I had an idea, what if we just used the same color as the tab background. (Refer to #7134, #7162) So if the control's "tabColor" changes, we should use that value as the pane color. So a profile's tabColor would apply to the pane titlebar. If there's no color set, then we'll use whatever value we pick as the default for the pane titlebars - this could either be ChromeLow or TabViewBackground(=ChromeDisabledHigh). But using the color picker to change the tab's color would set a value for the tab to use regardless of the pane titlebar color.

I'm rambling and brainstorming now.

@zadjii-msft commented on GitHub (Aug 19, 2020): What if we started with the `ChromeLow` theme resource for now, and we'll let the design experts weigh in for the PR? 😉 That'll give us "a little darker" in dark theme, and "a little lighter" in light theme. For the record, the titlebar uses `ChromeDisabledHigh` by default: ![image](https://user-images.githubusercontent.com/18356694/90681004-54f2f800-e228-11ea-9925-210ac3595112.png) (from https://docs.microsoft.com/en-us/windows/uwp/design/controls-and-patterns/xaml-theme-resources) Sound good? <hr> **EDIT** Oh man I had an idea, what if we just used the same color as the tab background. (Refer to #7134, #7162) So if the control's "tabColor" changes, we should use that value as the pane color. So a profile's `tabColor` would apply to the pane titlebar. If there's no color set, then we'll use whatever value we pick as the default for the pane titlebars - this could either be `ChromeLow` or `TabViewBackground`(=`ChromeDisabledHigh`). But using the color picker to change the tab's color would set a value for the tab to use regardless of the pane titlebar color. I'm rambling and brainstorming now.
claunia commented 2026-01-31 02:14:04 +00:00
Author
Owner
Copy Link

@HunterMitchell commented on GitHub (Aug 21, 2020):

Sorry for the delay, I've been a bit busy. I went ahead and implemented the tab color change as requested, and it seems to work fine other than the fact I was unable to get it to change when the user uses the tab's color picker. I also have one small bug (or at least I hope it's small), that ill mention in the draft pull request ill be throwing up today. Maybe someone can give me some guidance on how to fix it.

I was also thinking a bit about the border for each pane and wanted to get your and other peoples opinion on using the pane's titlebar to indicate if a pane is focused or not. If you look at the image in my initial comment, terminator provides different colors (foreground / background) of the titlebar when active or not. In this case, the active pane has a white foreground and a darker background than the others. I am kinda wanting to get rid of the borders for a cleaner look (as seen in terminator), but I understand this might not be what the team has in mind for the UI. Of course, this would be an issue for user's who prefer not to use pane titlebars, but we might could only apply borders then? Just throwing out some ideas.

@HunterMitchell commented on GitHub (Aug 21, 2020): Sorry for the delay, I've been a bit busy. I went ahead and implemented the tab color change as requested, and it seems to work fine other than the fact I was unable to get it to change when the user uses the tab's color picker. I also have one small bug (or at least I hope it's small), that ill mention in the draft pull request ill be throwing up today. Maybe someone can give me some guidance on how to fix it. I was also thinking a bit about the border for each pane and wanted to get your and other peoples opinion on using the pane's titlebar to indicate if a pane is focused or not. If you look at the image in my initial comment, terminator provides different colors (foreground / background) of the titlebar when active or not. In this case, the active pane has a white foreground and a darker background than the others. I am kinda wanting to get rid of the borders for a cleaner look (as seen in terminator), but I understand this might not be what the team has in mind for the UI. Of course, this would be an issue for user's who prefer not to use pane titlebars, but we might could only apply borders then? Just throwing out some ideas.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted Issue-Feature Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10160
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?