starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Deleting Chinese IME during composition sends the first character to the Terminal #7134

New Issue
Closed
opened 2026-01-31 00:56:00 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 00:56:00 +00:00
Owner
Copy Link

Originally created by @leonMSFT on GitHub (Mar 24, 2020).

Steps to reproduce

Related to #5054
Start a Chinese IME composition without completing it/selecting the characters e.g. "wei'yuan", then delete the characters.

Expected behavior

There should be no characters left on the screen.

Actual behavior

The letter "w" will appear in the buffer.

Cause

We're receiving a CompositionCompleted event before we receive a TextUpdating event for the final character "w" to be deleted. This causes us to believe that "w" is a completed composition, so we send it to the terminal. We then receive the TextUpdating event right after to tell us to delete the "w", so it disappears from the _inputBuffer.

Originally created by @leonMSFT on GitHub (Mar 24, 2020). # Steps to reproduce Related to #5054 Start a Chinese IME composition without completing it/selecting the characters e.g. "wei'yuan", then delete the characters. # Expected behavior There should be no characters left on the screen. # Actual behavior The letter "w" will appear in the buffer. # Cause We're receiving a `CompositionCompleted` event before we receive a `TextUpdating` event for the final character "w" to be deleted. This causes us to believe that "w" is a completed composition, so we send it to the terminal. We then receive the `TextUpdating` event right after to tell us to delete the "w", so it disappears from the `_inputBuffer`.
claunia commented 2026-01-31 00:56:03 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Mar 26, 2020):

Tagging this into v1.x -- feel free to override me

@DHowett-MSFT commented on GitHub (Mar 26, 2020): Tagging this into v1.x -- feel free to override me
claunia commented 2026-01-31 00:56:03 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (Mar 26, 2020):

As weird as it may seem, the behaviour of WT is actually aligned with stock cmd.exe. This bug also exists there. Exact same bahaviour. Does this mean it is what we actually expect it to be? I'm confused...

@skyline75489 commented on GitHub (Mar 26, 2020): As weird as it may seem, the behaviour of WT is actually aligned with stock `cmd.exe`. This bug also exists there. Exact same bahaviour. Does this mean it is what we actually expect it to be? I'm confused...
claunia commented 2026-01-31 00:56:04 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Mar 26, 2020):

For version 1, "works like cmd.exe" will be acceptable. We'd love to do better than cmd.exe, but our deadlines are getting closer every day 😁

@DHowett-MSFT commented on GitHub (Mar 26, 2020): For version 1, "works like cmd.exe" will be acceptable. We'd love to do better than cmd.exe, but our deadlines are getting closer every day :grin:
claunia commented 2026-01-31 00:56:04 +00:00
Author
Owner
Copy Link

@leonMSFT commented on GitHub (Mar 26, 2020):

I'm surprised cmd behaves the same way! It kinda sounds like both Terminal and cmd use the same underlying api, making them both able to repro this bug.

@leonMSFT commented on GitHub (Mar 26, 2020): I'm surprised cmd behaves the same way! It kinda sounds like both Terminal and cmd use the same underlying api, making them both able to repro this bug.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Input Area-TerminalControl In-PR Issue-Bug Needs-Tag-Fix Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7134
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?