starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Visual Error - shortcut CTRL+SHIFT+[dash,equals] #10207

New Issue
Closed
opened 2026-01-31 02:15:23 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 02:15:23 +00:00
Owner
Copy Link

Originally created by @kellytrinh on GitHub (Aug 18, 2020).

Environment

WT Version 1.1.2233

Steps to reproduce

  1. Have lots of different profiles defined.
  2. In settings.json extend additional shortcuts from the existing 1 to 9 for 0, - (dash), and = (equals) so that CTRL+SHIFT+[key] opens respective profile

Expected behavior

In the menu for opening a tab/profile, the shortcut for extended shortcuts should appear as logically expected

Actual behavior

In the menu for opening a tab/profile, the shortcut newly defined 0 is appear next to relevant profile but the shortcut for dash and equals do not appear.

Originally created by @kellytrinh on GitHub (Aug 18, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none WT Version 1.1.2233 ``` # Steps to reproduce 1. Have lots of different profiles defined. 2. In `settings.json` extend additional shortcuts from the existing 1 to 9 for 0, - (dash), and = (equals) so that CTRL+SHIFT+[key] opens respective profile # Expected behavior In the menu for opening a tab/profile, the shortcut for extended shortcuts should appear as logically expected # Actual behavior In the menu for opening a tab/profile, the shortcut newly defined 0 is appear next to relevant profile but the shortcut for dash and equals do not appear.
claunia commented 2026-01-31 02:15:24 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 18, 2020):

Could you share the actual json you've added for these keybindings?

@zadjii-msft commented on GitHub (Aug 18, 2020): Could you share the actual json you've added for these keybindings?
claunia commented 2026-01-31 02:15:25 +00:00
Author
Owner
Copy Link

@kellytrinh commented on GitHub (Aug 18, 2020):

The relevant lines below; the shortcut themselves do work and I can open the tab/profiles with them fine.

        { "command": { "action": "newTab", "index": 7 }, "keys": "ctrl+shift+9" },
        { "command": { "action": "newTab", "index": 8 }, "keys": "ctrl+shift+0" },        
        { "command": { "action": "newTab", "index": 9 }, "keys": "ctrl+shift+-" },                
        { "command": { "action": "newTab", "index": 10 }, "keys": "ctrl+shift+=" },
@kellytrinh commented on GitHub (Aug 18, 2020): The relevant lines below; the shortcut themselves do work and I can open the tab/profiles with them fine. ``` { "command": { "action": "newTab", "index": 7 }, "keys": "ctrl+shift+9" }, { "command": { "action": "newTab", "index": 8 }, "keys": "ctrl+shift+0" }, { "command": { "action": "newTab", "index": 9 }, "keys": "ctrl+shift+-" }, { "command": { "action": "newTab", "index": 10 }, "keys": "ctrl+shift+=" }, ```
claunia commented 2026-01-31 02:15:25 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 18, 2020):

It looks like we only actually do this for the first 9 profiles:

93d266925c/src/cascadia/TerminalApp/TerminalPage.cpp (L465-L468)

This is probably because we had 9 hardcoded "switch to tab" commands and it was not possible to add a custom index when we first wrote this code 😄

@DHowett commented on GitHub (Aug 18, 2020): It looks like we only actually do this for the first 9 profiles: https://github.com/microsoft/terminal/blob/93d266925cfce92c1f321c43e10809d624cd2b94/src/cascadia/TerminalApp/TerminalPage.cpp#L465-L468 This is probably because we had 9 hardcoded "switch to tab" commands and it was not possible to add a custom index when we first wrote this code :smile:
claunia commented 2026-01-31 02:15:25 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 18, 2020):

Ho boy would you look at that. Yep, we should fix that

@zadjii-msft commented on GitHub (Aug 18, 2020): Ho boy would you look at that. Yep, we should fix that
claunia commented 2026-01-31 02:15:25 +00:00
Author
Owner
Copy Link

@kellytrinh commented on GitHub (Aug 19, 2020):

Just noticed - for some reason there seems to be some bug in the shortcut handling - with the JSON snippet above; CTRL+SHIFT+9 works. So does CTRL+SHIFT+[dash]. But the one in the middle CTRL+SHIFT+0 oddly does nothing.

So there is two bugs, the OP with [dash] [equals] shortcuts not appears and additionally the sequence CTRL+SHIFT+0 not being handled.

@kellytrinh commented on GitHub (Aug 19, 2020): Just noticed - for some reason there seems to be some bug in the shortcut handling - with the JSON snippet above; CTRL+SHIFT+9 works. So does CTRL+SHIFT+[dash]. But the one in the middle CTRL+SHIFT+0 oddly does nothing. So there is two bugs, the OP with [dash] [equals] shortcuts not appears and additionally the sequence CTRL+SHIFT+0 not being handled.
claunia commented 2026-01-31 02:15:25 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 19, 2020):

If you have multiple keyboard layouts enabled, Ctrl+Shift+0 is reserved by Windows as a keyboard layout switch command.

@DHowett commented on GitHub (Aug 19, 2020): If you have multiple keyboard layouts enabled, Ctrl+Shift+0 is reserved by Windows as a keyboard layout switch command.
claunia commented 2026-01-31 02:15:26 +00:00
Author
Owner
Copy Link

@kellytrinh commented on GitHub (Aug 19, 2020):

If you mean multiple languages - no I don't have anything like that installed.

Not sure what other layouts you could mean but happy to look into if you give me a pointer on where to check the windows setting.

Anyway; if you are sure this is not a bug and expected behaviour due to windows outside; then can ignore.

@kellytrinh commented on GitHub (Aug 19, 2020): If you mean multiple languages - no I don't have anything like that installed. Not sure what other layouts you could mean but happy to look into if you give me a pointer on where to check the windows setting. Anyway; if you are sure this is not a bug and expected behaviour due to windows outside; then can ignore.
claunia commented 2026-01-31 02:15:26 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 26, 2020):

:tada:This issue was addressed in #7344, which has now been successfully released as Windows Terminal v1.2.2381.0.🎉

Handy links:

@ghost commented on GitHub (Aug 26, 2020): :tada:This issue was addressed in #7344, which has now been successfully released as `Windows Terminal v1.2.2381.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.2.2381.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 02:15:26 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 26, 2020):

:tada:This issue was addressed in #7344, which has now been successfully released as Windows Terminal Preview v1.3.2382.0.🎉

Handy links:

@ghost commented on GitHub (Aug 26, 2020): :tada:This issue was addressed in #7344, which has now been successfully released as `Windows Terminal Preview v1.3.2382.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.3.2382.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings good first issue Help Wanted Issue-Bug Needs-Tag-Fix Priority-2 Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10207
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?