starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Code Health: Deps - Update all dependencies prior to v2. #7344

New Issue
Closed
opened 2026-01-31 01:01:31 +00:00 by claunia · 10 comments
claunia commented 2026-01-31 01:01:31 +00:00
Owner
Copy Link

Originally created by @WSLUser on GitHub (Apr 9, 2020).

Description of the new feature/enhancement

We should try to ship with the least amount of bugs possible, this includes updating dependencies that haven't been touched since Terminal was first released into the wild such as WinAppDriver

Proposed technical implementation details (optional)

We should enable the dependabot from github but for now we just need to import the newest releases and verify nothing has changed. I did already review CLI11 based on their release notes and believe we can update it with no code changes to Terminal.

Originally created by @WSLUser on GitHub (Apr 9, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> We should try to ship with the least amount of bugs possible, this includes updating dependencies that haven't been touched since Terminal was first released into the wild such as WinAppDriver # Proposed technical implementation details (optional) We should enable the dependabot from github but for now we just need to import the newest releases and verify nothing has changed. I did already review CLI11 based on their release notes and believe we can update it with no code changes to Terminal. <!-- A clear and concise description of what you want to happen. -->
claunia added the Issue-TaskNeeds-Tag-FixProduct-TerminalArea-CodeHealth labels 2026-01-31 01:01:31 +00:00
claunia commented 2026-01-31 01:01:32 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 9, 2020):

dependencies that haven't been touched since Terminal was first released into the wild such as CLI11

to be fair, this dependency was added in November, and it was the newest available version in November. It's not factual to state that it hasn't been touched since Terminal was first released into the wild.

@DHowett-MSFT commented on GitHub (Apr 9, 2020): > dependencies that haven't been touched since Terminal was first released into the wild such as CLI11 to be fair, this dependency was added in _November_, and it was the newest available version in November. It's not factual to state that it hasn't been touched since Terminal was first released into the wild.
claunia commented 2026-01-31 01:01:32 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Apr 10, 2020):

I was basing it off the version history of the deps. If I have time, I plan on submitting a PR for some of the more trivial updates.

@WSLUser commented on GitHub (Apr 10, 2020): I was basing it off the version history of the deps. If I have time, I plan on submitting a PR for some of the more trivial updates.
claunia commented 2026-01-31 01:01:33 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Apr 10, 2020):

Yeah I think most of the stuff in deps is being managed by Nuget but with the private feed not entirely sure how to get them updated. The only 2 that could get updated easily if they ever needed updates are wil and gsl due to using git submodules. I was starting to look into using submodules for the rest of the deps and that was when I realized Nuget is being used.

@WSLUser commented on GitHub (Apr 10, 2020): Yeah I think most of the stuff in deps is being managed by Nuget but with the private feed not entirely sure how to get them updated. The only 2 that could get updated easily if they ever needed updates are `wil `and `gsl `due to using git submodules. I was starting to look into using submodules for the rest of the deps and that was when I realized Nuget is being used.
claunia commented 2026-01-31 01:01:33 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (May 12, 2020):

@DHowett-MSFT just realized that this one seems weird to be in the v1.x milestone. Any reason this one's blocked? Maybe we could resolve it fairly quickly?

@carlos-zamora commented on GitHub (May 12, 2020): @DHowett-MSFT just realized that this one seems weird to be in the v1.x milestone. Any reason this one's blocked? Maybe we could resolve it fairly quickly?
claunia commented 2026-01-31 01:01:33 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 12, 2020):

IMO at this point, there might be subtle regressions in our deps that we won't have enough runway to catch, and we might as well go with the known issues we currently have. Take for example the seemingly safe update to MUX 2.4 (in #5778). That secretly regressed AccentButtonStyle. I think at this point we'd rather the devil you know.

That's my 2¢

@zadjii-msft commented on GitHub (May 12, 2020): IMO at this point, there might be subtle regressions in our deps that we won't have enough runway to catch, and we might as well go with the known issues we currently have. Take for example the seemingly safe update to MUX 2.4 (in #5778). That secretly regressed `AccentButtonStyle`. I think at this point we'd rather the devil you know. That's my 2¢
claunia commented 2026-01-31 01:01:33 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (May 13, 2020):

I noticed a 2 line change in Chrome math seems to break things. But I was also testing it with other dep updates. Some seemed benign though

@WSLUser commented on GitHub (May 13, 2020): I noticed a 2 line change in Chrome math seems to break things. But I was also testing it with other dep updates. Some seemed benign though
claunia commented 2026-01-31 01:01:34 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (May 13, 2020):

for example, we should update wil. It would be nice if gsl could be as well but I saw why we can't. Alot of the deps could be made into git submodules. I think that would be the route to go to help update more easily.

@WSLUser commented on GitHub (May 13, 2020): for example, we should update wil. It would be nice if gsl could be as well but I saw why we can't. Alot of the deps could be made into git submodules. I think that would be the route to go to help update more easily.
claunia commented 2026-01-31 01:01:34 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 13, 2020):

So, many of the deps are transcluded instead of imported as submodules because this repository is ingested into the Windows build system (and the Windows repository) where we cannot use submodules. Packages that aren't part of Windows, but which we still need, are in /oss.

@DHowett-MSFT commented on GitHub (May 13, 2020): So, many of the deps are transcluded instead of imported as submodules because this repository is ingested into the Windows build system (and the Windows repository) where we cannot use submodules. Packages that aren't part of Windows, but which we still need, are in `/oss`.
claunia commented 2026-01-31 01:01:34 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (May 13, 2020):

So that leaves nuget as the other option if possible.

@WSLUser commented on GitHub (May 13, 2020): So that leaves nuget as the other option if possible.
claunia commented 2026-01-31 01:01:34 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 18, 2020):

You know what, we've bumped almost all our deps since this issue was originally filed in April, so I think we can close this out. I don't really think we need an open-ended generic work item for "bump our deps" 😄

@zadjii-msft commented on GitHub (Aug 18, 2020): You know what, we've bumped almost all our deps since this issue was originally filed in April, so I think we can close this out. I don't really think we need an open-ended generic work item for "bump our deps" 😄
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Task Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7344
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?