starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Font size can't be changed while using + and - from numeric keypad #10478

New Issue
Closed
opened 2026-01-31 02:22:40 +00:00 by claunia · 10 comments
claunia commented 2026-01-31 02:22:40 +00:00
Owner
Copy Link

Originally created by @amithegde on GitHub (Sep 3, 2020).

Environment

Microsoft Windows [Version 10.0.19041.450]
Windows Terminal version (if applicable): latest preview

Steps to reproduce

  • Hold Ctrl and press + or - from numeric keypad

Expected behavior

  • font size should increase or decrease

Actual behavior

  • nothing happens
Originally created by @amithegde on GitHub (Sep 3, 2020). # Environment Microsoft Windows [Version 10.0.19041.450] Windows Terminal version (if applicable): latest preview # Steps to reproduce - Hold Ctrl and press + or - from numeric keypad # Expected behavior - font size should increase or decrease # Actual behavior - nothing happens
claunia commented 2026-01-31 02:22:41 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 3, 2020):

Yup. + and Keypad + are different keys and generate different inputs to the OS. If you'd like to bind these specifically, you can add your own custom bindings for ctrl+numpad_plus and ctrl+numpad_minus.

@DHowett commented on GitHub (Sep 3, 2020): Yup. <kbd>+</kbd> and <kbd>Keypad +</kbd> are different keys and generate different inputs to the OS. If you'd like to bind these specifically, you can add your own custom bindings for `ctrl+numpad_plus` and `ctrl+numpad_minus`.
claunia commented 2026-01-31 02:22:41 +00:00
Author
Owner
Copy Link

@amithegde commented on GitHub (Sep 3, 2020):

  • and Keypad + are different keys and generate different inputs to the OS

@DHowett that is very interesting! It would be great to have these configured as default settings. I use terminal on at least 4 devices and it would be nice to have these included in the default settings as one doesn't have to do lot of manual configurations just to make it work.

On the other hand, I wonder how the numbers on the numeric keypad work without needing additional configuration 🤔🤔

@amithegde commented on GitHub (Sep 3, 2020): > + and Keypad + are different keys and generate different inputs to the OS @DHowett that is very interesting! It would be great to have these configured as default settings. I use terminal on at least 4 devices and it would be nice to have these included in the default settings as one doesn't have to do lot of manual configurations just to make it work. On the other hand, I wonder how the numbers on the numeric keypad work without needing additional configuration 🤔🤔
claunia commented 2026-01-31 02:22:42 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 3, 2020):

Terminal would rather not camp on any more of your keyboard keys than it really absolutely needs to! 😁

The numbers actually are different keys too (VK_NUMPAD0 through VK_NUMPAD9) and any bindings set on them need to be set for the numpad numbers specifically.

These keys work work normally when sent to the client application because while the terminal's key bindings operate on keys, the communication protocol relies on characters[1].

[1]: every key event comes with at least two things -- a virtual key number and a character.

key vkey character
1 VK_1 1
Numpad 1 VK_NUMPAD1 1
@DHowett commented on GitHub (Sep 3, 2020): Terminal would rather not camp on any more of your keyboard keys than it really absolutely needs to! :grin: The numbers actually are different keys too (`VK_NUMPAD0` through `VK_NUMPAD9`) and any bindings set on them need to be set for the numpad numbers specifically. These keys work work normally when sent to the client application because while the terminal's key bindings operate on _keys_, the communication protocol relies on _characters_[1]. [1]: every key event comes with at least two things -- a _virtual key number_ and a _character_. key|vkey|character -|-|- <kbd>1</kbd>|`VK_1`|`1` <kbd>Numpad 1</kbd>|`VK_NUMPAD1`|`1`
claunia commented 2026-01-31 02:22:42 +00:00
Author
Owner
Copy Link

@amithegde commented on GitHub (Sep 4, 2020):

I noticed VS code handles + on the numeric keypad👌

@amithegde commented on GitHub (Sep 4, 2020): I noticed VS code handles + on the numeric keypad👌
claunia commented 2026-01-31 02:22:42 +00:00
Author
Owner
Copy Link

@pstaag commented on GitHub (Sep 4, 2020):

(I literally signed up just to join the discussion in this particular thread. Uh...be gentle with me. I, well, need a markup crash course, among other things.)

@amithegde is on to something here. There ARE key bindings missing. But...I'd prefer to go one or perhaps several steps further.

First,

Yes. Absolutely do bind ctrl+numpad plus.

Why? Because it's bound in a lot of web browsers to have zoom behaviour. Consistency is sometimes about availing plenty different ways to do the same thing.

Second,

Also add other key bindings. Because,

  1. on portables without a numpad keyboard, it's flat out useless to have that binding. It offers no difference.

  2. Windows built in keyboard does not have a numpad. It's a change that does not help users relying on it.

  3. Cater better to the international user community.

For me, being friends with Swedish keyboard layouts in particular, there is a problem with producing ctrl+= because = is shift:ed on 0. Windows Terminal does not understand ctrl+shift+0 as ctrl+= (which is probably correct behaviour, I'm not complaining) and therefor, the official key binding is, literally, impossible to invoke (and THAT, that last bit, I totally am complaining about.)

For me, it's annoying like there is no tomorrow that ctrl++ is not bound to zoom alongside with ctrl+=

It also does not help that the Command Palette insists that Increase font size IS bound to <ctrl+shift+0

  1. Mimic behaviour from other types of software to cut down on the learning curve

Adding several key bindings to the same behaviour is sometimes the best way to remove a learning curve for new users. Web browsers typically add several key bindings that control zoom. Add a few more of them to the official list of bindings.

Navigating key bindings can prove to be a bit of a headache, because we also don't want to make the terminal useless in the process. But...

This last bit should probably be lifted to another thread, to not derail this discussion further:

While we are at it, have you noticed that the new Command Palette only shows the first defined key binding for a command? Even if I bind ctrl++ it still insists in showing JUST the defaults.json binding.

The command palette deserves standing ovations already, but it totally also needs more work.

@pstaag commented on GitHub (Sep 4, 2020): (I literally signed up **just** to join the discussion in this particular thread. Uh...be gentle with me. I, well, need a markup crash course, among other things.) @amithegde is on to something here. There ARE key bindings missing. But...I'd prefer to go one or perhaps several steps further. First, Yes. Absolutely do bind <kbd>ctrl</kbd>+<kbd>numpad plus</kbd>. Why? Because it's bound in a lot of web browsers to have zoom behaviour. Consistency is sometimes about availing plenty different ways to do the same thing. Second, Also add other key bindings. Because, 1. on portables without a numpad keyboard, it's flat out useless to have that binding. It offers no difference. 2. Windows built in keyboard does not have a numpad. It's a change that does not help users relying on it. 3. Cater better to the international user community. For me, being friends with Swedish keyboard layouts in particular, there is a problem with producing <kbd>ctrl</kbd>+<kbd>=</kbd> because <kbd>=</kbd> is <kbd>shift</kbd>:ed on <kbd>0</kbd>. Windows Terminal does not understand <kbd>ctrl</kbd>+<kbd>shift</kbd>+<kbd>0</kbd> as <kbd>ctrl</kbd>+<kbd>=</kbd> (which is probably correct behaviour, I'm not complaining) and therefor, the official key binding is, literally, impossible to invoke (and THAT, that last bit, I totally am complaining about.) For me, it's annoying like there is no tomorrow that <kbd>ctrl</kbd>+<kbd>+</kbd> is not bound to zoom alongside with <kbd>ctrl</kbd>+<kbd>=</kbd> It also does not help that the Command Palette insists that Increase font size IS bound to <kbd><ctrl</kbd>+<kbd>shift</kbd>+<kbd>0</kbd> 4. Mimic behaviour from other types of software to cut down on the learning curve Adding several key bindings to the same behaviour is sometimes the best way to remove a learning curve for new users. Web browsers typically add several key bindings that control zoom. **Add a few more of them to the official list of bindings.** Navigating key bindings can prove to be a bit of a headache, because we also don't want to make the terminal useless in the process. But... This last bit should probably be lifted to another thread, to not derail this discussion further: While we are at it, have you noticed that the new Command Palette only shows the *first* defined key binding for a command? Even if I bind <kbd>ctrl</kbd>+<kbd>+</kbd> it still insists in showing JUST the defaults.json binding. The command palette deserves standing ovations already, but it totally also needs more work.
claunia commented 2026-01-31 02:22:42 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 4, 2020):

@pstaag thanks :) those are all very valid points. I’ll reopen this and hit it again in triage tomorrow during the work day.

@DHowett commented on GitHub (Sep 4, 2020): @pstaag thanks :) those are all very valid points. I’ll reopen this and hit it again in triage tomorrow during the work day.
claunia commented 2026-01-31 02:22:42 +00:00
Author
Owner
Copy Link

@pstaag commented on GitHub (Sep 5, 2020):

After giving it some thought, I decided that how key bindings on numeric keys are handled in Terminal, is an actual, proper bug and deserved it's own thread. It's in #7539

@pstaag commented on GitHub (Sep 5, 2020): After giving it some thought, I decided that how key bindings on numeric keys are handled in Terminal, is an actual, proper bug and deserved it's own thread. It's in #7539
claunia commented 2026-01-31 02:22:43 +00:00
Author
Owner
Copy Link

@hessedoneen commented on GitHub (Apr 7, 2021):

Hello, this is my first time contributing to open source code. Could I try giving this zooming task a try? It seems like I could find reference code in a lot of places so that might make it a good first project.

@hessedoneen commented on GitHub (Apr 7, 2021): Hello, this is my first time contributing to open source code. Could I try giving this zooming task a try? It seems like I could find reference code in a lot of places so that might make it a good first project.
claunia commented 2026-01-31 02:22:43 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 7, 2021):

@hessedoneen Absolutely! This is probably the easiest one to implement. It should be as easy as adding the following two lines:

        { "command": { "action": "adjustFontSize", "delta": 1 }, "keys": "ctrl+numpad_plus" },
        { "command": { "action": "adjustFontSize", "delta": -1 }, "keys": "ctrl+numpad_minus" },

To this file:
cdf2630204/src/cascadia/TerminalSettingsModel/defaults.json (L362-L366)

@zadjii-msft commented on GitHub (Apr 7, 2021): @hessedoneen Absolutely! This is probably the easiest one to implement. It should be as easy as adding the following two lines: ```json { "command": { "action": "adjustFontSize", "delta": 1 }, "keys": "ctrl+numpad_plus" }, { "command": { "action": "adjustFontSize", "delta": -1 }, "keys": "ctrl+numpad_minus" }, ``` To this file: https://github.com/microsoft/terminal/blob/cdf2630204fdafc24237e5ebaf069c0b12a26aab/src/cascadia/TerminalSettingsModel/defaults.json#L362-L366
claunia commented 2026-01-31 02:22:43 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 14, 2021):

:tada:This issue was addressed in #9753, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.🎉

Handy links:

@ghost commented on GitHub (Apr 14, 2021): :tada:This issue was addressed in #9753, which has now been successfully released as `Windows Terminal Preview v1.8.1032.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1032.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings good first issue Help Wanted Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10478
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?