starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Do we still need to force the font on output codepage change? #14317

New Issue
Open
opened 2026-01-31 04:07:01 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 04:07:01 +00:00
Owner
Copy Link

Originally created by @alabuzhev on GitHub (Jun 22, 2021).

Description of the new feature/enhancement

Currently, when the user changes the console codepage (manually or via a script) the GDI engine tries to find and set the "best possible" font. The "best possible" here is charset-wise, it doesn't mean that the font is actually better or more eye-candy for the user.

Example:

  • Open cmd
  • Set the font to Consolas
  • Enter chcp 932
  • Suddenly, a wild MS Gothic appears!

This kind of makes sense ("if I'm changing the codepage I probably want to see the national characters") but it doesn't happen anywhere else - all other apps just substitute the missing glyphs.

After #10472 / #10478 this magic should finally work here as well. So, do we still need to change the whole font? Terminal doesn't do that after all.

Proposed technical implementation details

A quick and dirty hack, I'm sure there are better ways:

diff --git a/src/host/misc.cpp b/src/host/misc.cpp
index a89c982b..64f602d1 100644
--- a/src/host/misc.cpp
+++ b/src/host/misc.cpp
@@ -38,6 +38,7 @@ void SetConsoleCPInfo(const BOOL fOutput)
         // to pick a more appropriate font should the current one be unable to render in the new codepage.
         // To do this, we create a copy of the existing font but we change the codepage value to be the new one that was just set in the global structures.
         // NOTE: We need to do this only if everything is set up. This can get called while we're still initializing, so carefully check things for nullptr.
+#if 0
         if (gci.HasActiveOutputBuffer())
         {
             SCREEN_INFORMATION& screenInfo = gci.GetActiveOutputBuffer();
@@ -54,6 +55,7 @@ void SetConsoleCPInfo(const BOOL fOutput)
                            gci.OutputCP);
             screenInfo.UpdateFont(&fiNew);
         }
+#endif
 
         if (!GetCPInfo(gci.OutputCP, &gci.OutputCPInfo))
         {

Testing

Download 932.cmd.txt, rename to 932.cmd, run it, check if the output is still readable.

Originally created by @alabuzhev on GitHub (Jun 22, 2021). # Description of the new feature/enhancement Currently, when the user changes the console codepage (manually or via a script) the GDI engine tries to find and set the "best possible" font. The "best possible" here is charset-wise, it doesn't mean that the font is actually better or more eye-candy for the user. Example: - Open cmd - Set the font to Consolas - Enter `chcp 932` - Suddenly, a wild MS Gothic appears! This kind of makes sense (*"if I'm changing the codepage I probably want to see the national characters"*) but it doesn't happen anywhere else - all other apps just substitute the missing glyphs. After #10472 / #10478 this magic should finally work here as well. So, do we still need to change the whole font? Terminal doesn't do that after all. # Proposed technical implementation details A quick and dirty hack, I'm sure there are better ways: ```DIFF diff --git a/src/host/misc.cpp b/src/host/misc.cpp index a89c982b..64f602d1 100644 --- a/src/host/misc.cpp +++ b/src/host/misc.cpp @@ -38,6 +38,7 @@ void SetConsoleCPInfo(const BOOL fOutput) // to pick a more appropriate font should the current one be unable to render in the new codepage. // To do this, we create a copy of the existing font but we change the codepage value to be the new one that was just set in the global structures. // NOTE: We need to do this only if everything is set up. This can get called while we're still initializing, so carefully check things for nullptr. +#if 0 if (gci.HasActiveOutputBuffer()) { SCREEN_INFORMATION& screenInfo = gci.GetActiveOutputBuffer(); @@ -54,6 +55,7 @@ void SetConsoleCPInfo(const BOOL fOutput) gci.OutputCP); screenInfo.UpdateFont(&fiNew); } +#endif if (!GetCPInfo(gci.OutputCP, &gci.OutputCPInfo)) { ``` # Testing Download [932.cmd.txt](https://github.com/microsoft/terminal/files/6697577/932.cmd.txt), rename to 932.cmd, run it, check if the output is still readable.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Fonts Area-Rendering Issue-Task Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14317
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?