starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Investigate memory leak over time #1054

New Issue
Closed
opened 2026-01-30 22:15:25 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 22:15:25 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (May 14, 2019).

From discussion in #745

I do not have very concrete data on it yet, but I also see a massive memory leak in WindowsTerminal.exe, even with only ever having just one tab open.
I tend to see this memory consumption happen most aggressively with any sort of application that continuously updates the screen like mtr or htop (I'm using the version of OpenSSH bundled with Windows build 18362 to connect to a Linux machine to run these). A session that run for just under 40 minutes got up to over 1000 MB of memory usage according to Task Manager.

Another bit of information, all that memory seems to be released over time, that same session, now sitting at a shell over SSH calms down and now roughly 3 hours later, it is using an efficient and trim 8.5 MB of RAM according to Task Manager.

Originally created by @zadjii-msft on GitHub (May 14, 2019). From discussion in #745 > I do not have very concrete data on it yet, but I also see a massive memory leak in WindowsTerminal.exe, even with only ever having just one tab open. I tend to see this memory consumption happen most aggressively with any sort of application that continuously updates the screen like mtr or htop (I'm using the version of OpenSSH bundled with Windows build 18362 to connect to a Linux machine to run these). A session that run for just under 40 minutes got up to over 1000 MB of memory usage according to Task Manager. > Another bit of information, all that memory seems to be released over time, that same session, now sitting at a shell over SSH calms down and now roughly 3 hours later, it is using an efficient and trim 8.5 MB of RAM according to Task Manager.
claunia commented 2026-01-30 22:15:26 +00:00
Author
Owner
Copy Link

@Robo210 commented on GitHub (May 29, 2019):

It looks like at least one stack that's doing constant allocations is

Commit Stack Size (MB)
[Root] 3.609
ntdll.dll!RtlUserThreadStart 3.609
kernel32.dll!BaseThreadInitThunk 3.609
TerminalControl.dll!Microsoft::Console::Render::RenderThread::s_ThreadProc 3.609
TerminalControl.dll!Microsoft::Console::Render::Renderer::PaintFrame 3.609
TerminalControl.dll!Microsoft::Console::Render::Renderer::_PaintFrameForEngine 3.609
TerminalControl.dll!Microsoft::Console::Render::Renderer::_PaintBufferOutput 3.609
TerminalControl.dll!Microsoft::Console::Render::Renderer::_PaintBufferOutputHelper 3.609
TerminalControl.dll!Microsoft::Console::Render::DxEngine::PaintBufferLine 3.609
TerminalControl.dll!Microsoft::Console::Render::CustomTextLayout::_AnalyzeRuns 3.609
|- TerminalControl.dll!Microsoft::Console::Render::CustomTextLayout::_AnalyzeFontFallback 3.133
|    DWrite.dll!DWriteFontFallback::MapCharacters 3.133
|    DWrite.dll!FontFallback::MapCharacters 3.133
|    |- DWrite.dll!MatchFamilyToText 1.641
|    |- DWrite.dll!GetFontFamily 1.492

This came from 10 seconds of tracing while a progress bar was being printed to the console.

@Robo210 commented on GitHub (May 29, 2019): It looks like at least one stack that's doing constant allocations is |Commit Stack | Size (MB)| |-- | --| [Root] | 3.609 ntdll.dll!RtlUserThreadStart | 3.609 kernel32.dll!BaseThreadInitThunk | 3.609 TerminalControl.dll!Microsoft::Console::Render::RenderThread::s_ThreadProc | 3.609 TerminalControl.dll!Microsoft::Console::Render::Renderer::PaintFrame | 3.609 TerminalControl.dll!Microsoft::Console::Render::Renderer::_PaintFrameForEngine | 3.609 TerminalControl.dll!Microsoft::Console::Render::Renderer::_PaintBufferOutput | 3.609 TerminalControl.dll!Microsoft::Console::Render::Renderer::_PaintBufferOutputHelper | 3.609 TerminalControl.dll!Microsoft::Console::Render::DxEngine::PaintBufferLine | 3.609 TerminalControl.dll!Microsoft::Console::Render::CustomTextLayout::_AnalyzeRuns | 3.609 \|- TerminalControl.dll!Microsoft::Console::Render::CustomTextLayout::_AnalyzeFontFallback | 3.133 \|    DWrite.dll!DWriteFontFallback::MapCharacters | 3.133 \|    DWrite.dll!FontFallback::MapCharacters | 3.133 \|    \|- DWrite.dll!MatchFamilyToText | 1.641 \|    \|- DWrite.dll!GetFontFamily | 1.492 This came from 10 seconds of tracing while a progress bar was being printed to the console.
claunia commented 2026-01-30 22:15:26 +00:00
Author
Owner
Copy Link

@Biswa96 commented on GitHub (May 30, 2019):

How did you find?

@Biswa96 commented on GitHub (May 30, 2019): How did you find?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalConnection Area-TerminalControl Help Wanted Issue-Bug Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1054
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?