starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Remove deserialization of legacy json keys #1424

New Issue
Closed
opened 2026-01-30 22:26:48 +00:00 by claunia · 4 comments
claunia commented 2026-01-30 22:26:48 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (May 30, 2019).

Originally assigned to: @DHowett-MSFT on GitHub.

I'm thinking primarily of:

  • Globals in the root of the json object (which changed with #1005)
  • the table in a colorscheme as an array, not names
  • the entirely missing keybindings key (maybe we want to leave this however, or it could be fixed by #754 )
  • The legacy colorscheme key (changed to colorScheme with #1054 )
  • remove colorTable (#4091)
Originally created by @zadjii-msft on GitHub (May 30, 2019). Originally assigned to: @DHowett-MSFT on GitHub. I'm thinking primarily of: * Globals in the root of the json object (which changed with #1005) * the `table` in a colorscheme as an array, not names * the entirely missing keybindings key (maybe we want to leave this however, or it could be fixed by #754 ) * The legacy `colorscheme` key (changed to `colorScheme` with #1054 ) * remove `colorTable` (#4091)
claunia commented 2026-01-30 22:26:49 +00:00
Author
Owner
Copy Link

@bitcrazed commented on GitHub (Sep 24, 2019):

No longer required.

@bitcrazed commented on GitHub (Sep 24, 2019): No longer required.
claunia commented 2026-01-30 22:26:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 11, 2019):

Hey so I'm re-activating this to make sure we pull the old keybindings that we're not going to support in >=1.0. These were changed in #3391

@zadjii-msft commented on GitHub (Nov 11, 2019): Hey so I'm re-activating this to make sure we pull the old keybindings that we're not going to support in >=1.0. These were changed in #3391
claunia commented 2026-01-30 22:26:49 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jan 30, 2020):

I've begun work on a bunch of facets of this (i guess as indicated by the commits above!)

@DHowett-MSFT commented on GitHub (Jan 30, 2020): I've begun work on a bunch of facets of this (i guess as indicated by the commits above!)
claunia commented 2026-01-30 22:26:50 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 22, 2020):

:tada:This issue was addressed in #5190, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.🎉

Handy links:

@ghost commented on GitHub (Apr 22, 2020): :tada:This issue was addressed in #5190, which has now been successfully released as `Windows Terminal Preview v0.11.1121.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.11.1121.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Area-Settings Issue-Task Needs-Tag-Fix Priority-1 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1424
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?