starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Performance regression for Conhostv2 wrapped by ConEmu #1073

New Issue
Closed
opened 2026-01-30 22:15:48 +00:00 by claunia · 1 comment
claunia commented 2026-01-30 22:15:48 +00:00
Owner
Copy Link

Originally created by @miniksa on GitHub (May 14, 2019).

Ported from internal issue.

Repro Steps:
APIs that need to be further diagnosed by severity:

ReadConsoleOutputString - 24ms legacy, 442ms modern
FillConsoleOutput - 15ms legacy, 293ms modern
ReadConsoleOutput - 15ms legacy, 122ms modern

Maybe?
SetConsoleScreenBufferSize - 3ms legacy, 51ms modern

conhost.exe module is stamped 10.0.18345.1 which is one of the 19h1_release candidate builds.

Discussion:
@miniksa on Feb 26:
It appears that ConEmu is bulk reading a massive amount of state from the existing console host session before allowing things to proceed, probably synchronizing itself with the window it's wrapping.

We appear to have made that bulk read worse in recent days. We should institute performance tests with our new perf framework for these APIs and then work to optimize them back down

@miniksa on Mar 1:
OK. I've made a performance test for ReadConsoleOutputAttribute.

For v2 console, reading 9999 lines of ReadConsoleOutputAttribute appears to take ~3900ms.

For v1 console, the same takes ~300ms.

The goal now is to bring the time down.

@miniksa on Mar 1:
Sorry, that's a bad comparison. I was using debug code for v2.

This is release code comparison:

V2: ~400ms
V1: ~300ms

That's not that bad...

@miniksa on Mar 1:
OK I investigated the actual buffer dimensions and parameters used by ConEmu (81 wide x 32766 tall buffer) and reading 99 rows at a time worth of attribute data.

The new metrics for the closer matching test are:
v1 = 20-50ms
v2 = 130-170ms

@miniksa on Mar 1:
I made one for FillConsoleOutputAttribute too. Same dimensions.

v1 is 20-40ms

v2 is 120msish

@miniksa on Mar 1:
Added a third and final test for ReadConsoleOutputW and it seems to just straight up match the v1 perf.

Originally created by @miniksa on GitHub (May 14, 2019). Ported from internal issue. Repro Steps: APIs that need to be further diagnosed by severity: ReadConsoleOutputString - 24ms legacy, 442ms modern FillConsoleOutput - 15ms legacy, 293ms modern ReadConsoleOutput - 15ms legacy, 122ms modern Maybe? SetConsoleScreenBufferSize - 3ms legacy, 51ms modern conhost.exe module is stamped 10.0.18345.1 which is one of the 19h1_release candidate builds. Discussion: @miniksa on Feb 26: It appears that ConEmu is bulk reading a massive amount of state from the existing console host session before allowing things to proceed, probably synchronizing itself with the window it's wrapping. We appear to have made that bulk read worse in recent days. We should institute performance tests with our new perf framework for these APIs and then work to optimize them back down @miniksa on Mar 1: OK. I've made a performance test for ReadConsoleOutputAttribute. For v2 console, reading 9999 lines of ReadConsoleOutputAttribute appears to take ~3900ms. For v1 console, the same takes ~300ms. The goal now is to bring the time down. @miniksa on Mar 1: Sorry, that's a bad comparison. I was using debug code for v2. This is release code comparison: V2: ~400ms V1: ~300ms That's not that bad... @miniksa on Mar 1: OK I investigated the actual buffer dimensions and parameters used by ConEmu (81 wide x 32766 tall buffer) and reading 99 rows at a time worth of attribute data. The new metrics for the closer matching test are: v1 = 20-50ms v2 = 130-170ms @miniksa on Mar 1: I made one for FillConsoleOutputAttribute too. Same dimensions. v1 is 20-40ms v2 is 120msish @miniksa on Mar 1: Added a third and final test for ReadConsoleOutputW and it seems to just straight up match the v1 perf.
claunia commented 2026-01-30 22:15:50 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Oct 10, 2024):

With the ConsoleBench project we now have a way to track the performance in a more controlled and visual way. I'll be closing this issue then.

@lhecker commented on GitHub (Oct 10, 2024): With the ConsoleBench project we now have a way to track the performance in a more controlled and visual way. I'll be closing this issue then.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Performance Area-Server Issue-Bug Needs-Tag-Fix Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1073
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?