starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Feature Request - Copy with newline #2243

New Issue
Closed
opened 2026-01-30 22:50:26 +00:00 by claunia · 3 comments
claunia commented 2026-01-30 22:50:26 +00:00
Owner
Copy Link

Originally created by @philippeller on GitHub (Jun 25, 2019).

Originally assigned to: @carlos-zamora on GitHub.

Summary of the new feature/enhancement

As had been an issue with later versions of the WSL terminal, also in the new windows terminal selecting and copying multiple lines does not preserve newline characters, but instead is filled up with trailing whitespace to match the terminal width.

Proposed technical implementation details (optional)

Separate lines should result in clipboard text with newlines, wrapped lines without.

Example

Copying some output from the terminal and pasting here:

Expected behavior:

$ ll /usr/lib
total 206M
lrwxrwxrwx   1 root root   23 Oct  8  2012 libqimageblitz.so.4 -> libqimageblitz.so.4.0.0
-rw-r--r--   1 root root  99K Oct  8  2012 libqimageblitz.so.4.0.0
-rw-r--r--   1 root root 6.0K Feb  2  2013 libporttime.so.0.0.0
lrwxrwxrwx   1 root root   20 Feb  2  2013 libporttime.so.0 -> libporttime.so.0.0.0
-rw-r--r--   1 root root  36K Feb  2  2013 libportmidi.so.0.0.0
lrwxrwxrwx   1 root root   20 Feb  2  2013 libportmidi.so.0 -> libportmidi.so.0.0.0
lrwxrwxrwx   1 root root   20 Jan  4  2014 libmsgpackc.so.2 -> libmsgpackc.so.2.0.0
-rw-r--r--   1 root root  23K Jan  4  2014 libmsgpackc.so.2.0.0
lrwxrwxrwx   1 root root   15 Feb 28  2014 libfam.so.0 -> libfam.so.0.0.0
-rw-r--r--   1 root root  35K Feb 28  2014 libfam.so.0.0.0
...

Actual behavior:

$ ll /usr/lib                                                                                                              total 206M                                                                                                                                lrwxrwxrwx   1 root root   23 Oct  8  2012 libqimageblitz.so.4 -> libqimageblitz.so.4.0.0                                                 -rw-r--r--   1 root root  99K Oct  8  2012 libqimageblitz.so.4.0.0                                                                        -rw-r--r--   1 root root 6.0K Feb  2  2013 libporttime.so.0.0.0                                                                           lrwxrwxrwx   1 root root   20 Feb  2  2013 libporttime.so.0 -> libporttime.so.0.0.0                                                       -rw-r--r--   1 root root  36K Feb  2  2013 libportmidi.so.0.0.0                                                                           lrwxrwxrwx   1 root root   20 Feb  2  2013 libportmidi.so.0 -> libportmidi.so.0.0.0                                                       lrwxrwxrwx   1 root root   20 Jan  4  2014 libmsgpackc.so.2 -> libmsgpackc.so.2.0.0                                                       -rw-r--r--   1 root root  23K Jan  4  2014 libmsgpackc.so.2.0.0                                                                           lrwxrwxrwx   1 root root   15 Feb 28  2014 libfam.so.0 -> libfam.so.0.0.0                                                                 -rw-r--r--   1 root root  35K Feb 28  2014 libfam.so.0.0.0
Originally created by @philippeller on GitHub (Jun 25, 2019). Originally assigned to: @carlos-zamora on GitHub. # Summary of the new feature/enhancement <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> As had been an issue with later versions of the WSL terminal, also in the new windows terminal selecting and copying multiple lines does not preserve newline characters, but instead is filled up with trailing whitespace to match the terminal width. # Proposed technical implementation details (optional) <!-- A clear and concise description of what you want to happen. --> Separate lines should result in clipboard text _with_ newlines, wrapped lines without. # Example Copying some output from the terminal and pasting here: Expected behavior: ``` $ ll /usr/lib total 206M lrwxrwxrwx 1 root root 23 Oct 8 2012 libqimageblitz.so.4 -> libqimageblitz.so.4.0.0 -rw-r--r-- 1 root root 99K Oct 8 2012 libqimageblitz.so.4.0.0 -rw-r--r-- 1 root root 6.0K Feb 2 2013 libporttime.so.0.0.0 lrwxrwxrwx 1 root root 20 Feb 2 2013 libporttime.so.0 -> libporttime.so.0.0.0 -rw-r--r-- 1 root root 36K Feb 2 2013 libportmidi.so.0.0.0 lrwxrwxrwx 1 root root 20 Feb 2 2013 libportmidi.so.0 -> libportmidi.so.0.0.0 lrwxrwxrwx 1 root root 20 Jan 4 2014 libmsgpackc.so.2 -> libmsgpackc.so.2.0.0 -rw-r--r-- 1 root root 23K Jan 4 2014 libmsgpackc.so.2.0.0 lrwxrwxrwx 1 root root 15 Feb 28 2014 libfam.so.0 -> libfam.so.0.0.0 -rw-r--r-- 1 root root 35K Feb 28 2014 libfam.so.0.0.0 ... ``` Actual behavior: ``` $ ll /usr/lib total 206M lrwxrwxrwx 1 root root 23 Oct 8 2012 libqimageblitz.so.4 -> libqimageblitz.so.4.0.0 -rw-r--r-- 1 root root 99K Oct 8 2012 libqimageblitz.so.4.0.0 -rw-r--r-- 1 root root 6.0K Feb 2 2013 libporttime.so.0.0.0 lrwxrwxrwx 1 root root 20 Feb 2 2013 libporttime.so.0 -> libporttime.so.0.0.0 -rw-r--r-- 1 root root 36K Feb 2 2013 libportmidi.so.0.0.0 lrwxrwxrwx 1 root root 20 Feb 2 2013 libportmidi.so.0 -> libportmidi.so.0.0.0 lrwxrwxrwx 1 root root 20 Jan 4 2014 libmsgpackc.so.2 -> libmsgpackc.so.2.0.0 -rw-r--r-- 1 root root 23K Jan 4 2014 libmsgpackc.so.2.0.0 lrwxrwxrwx 1 root root 15 Feb 28 2014 libfam.so.0 -> libfam.so.0.0.0 -rw-r--r-- 1 root root 35K Feb 28 2014 libfam.so.0.0.0 ```
claunia added the Issue-BugArea-InteractionResolution-DuplicateProduct-Terminal labels 2026-01-30 22:50:26 +00:00
claunia commented 2026-01-30 22:50:27 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jun 26, 2019):

Wow. This is weird. Turns out this is a bug. Here's a repro:

  1. Open a Windows Terminal instance (trust me, close the one you have and open a new one)
  2. dir (or ls)
  3. make a selection of multiple lines
  4. right click to copy
  5. paste to notepad
  6. (this is where things get weird) THIS PASTE SHOULD BE FINE
  7. cls (or clear)
  8. repeat steps 2 - 5
  9. THIS PASTE SHOULD BE A MIX OF NEW SAME LINE AND NEW LINE TEXT

I did a bit of investigating. If you set a breakpoint on TermControl::CopySelectionToClipboard()s _terminal->ClearSelection();, use a debugger to take a look at the contents of copiedData.

On step 4 (both times you do it), you should hit this breakpoint. copiedData is different both times. I guess the problem is in Terminal::RetrieveSelectedTextFromBuffer()

@carlos-zamora commented on GitHub (Jun 26, 2019): Wow. This is weird. Turns out this is a bug. Here's a repro: 1. Open a Windows Terminal instance (trust me, close the one you have and open a new one) 2. `dir` (or `ls`) 3. make a selection of multiple lines 4. right click to copy 5. paste to notepad 6. (this is where things get weird) THIS PASTE SHOULD BE FINE 7. `cls` (or `clear`) 8. repeat steps 2 - 5 9. THIS PASTE SHOULD BE A MIX OF NEW SAME LINE AND NEW LINE TEXT I did a bit of investigating. If you set a breakpoint on `TermControl::CopySelectionToClipboard()`s `_terminal->ClearSelection();`, use a debugger to take a look at the contents of `copiedData`. On step 4 (both times you do it), you should hit this breakpoint. `copiedData` is different both times. I guess the problem is in `Terminal::RetrieveSelectedTextFromBuffer()`
claunia commented 2026-01-30 22:50:27 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jun 26, 2019):

Assigning myself but happy if anybody wants to take it off my plate since I won't get to it for a while :)

@carlos-zamora commented on GitHub (Jun 26, 2019): Assigning myself but happy if anybody wants to take it off my plate since I won't get to it for a while :)
claunia commented 2026-01-30 22:50:27 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jun 27, 2019):

Isn't this a duplicate of #1073?

@DHowett-MSFT commented on GitHub (Jun 27, 2019): Isn't this a duplicate of #1073?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Interaction Issue-Bug Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2243
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?