starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Glow text exploration #1075

New Issue
Closed
opened 2026-01-30 22:15:51 +00:00 by claunia · 5 comments
claunia commented 2026-01-30 22:15:51 +00:00
Owner
Copy Link

Originally created by @miniksa on GitHub (May 14, 2019).

OK. The glow text example I gave that's currently inside the code (but unused) isn't great.

I've received feedback from @MilesMSCohen that it has a fundamental flaw:

  • It loses all font hinting which makes it hard to read, especially at small sizes.

Ouch. I want hinting. The recommended alternative is to render the text to a command list and use the command list as input to an effect that can cause a glow.

@DHowett-MSFT already had a sample lump of code to do something like this that he was playing around with a few weeks ago because glow text is cool. It's around here somewhere.

Also, I got the warning from @MilesMSCohen that this might have worse performance, but we'd have to decide if that's worth it.

Originally created by @miniksa on GitHub (May 14, 2019). OK. The glow text example I gave that's currently inside the code (but unused) isn't great. I've received feedback from @MilesMSCohen that it has a fundamental flaw: - It loses all font hinting which makes it hard to read, especially at small sizes. Ouch. I want hinting. The recommended alternative is to render the text to a command list and use the command list as input to an effect that can cause a glow. @DHowett-MSFT already had a sample lump of code to do something like this that he was playing around with a few weeks ago because glow text is cool. It's around here somewhere. Also, I got the warning from @MilesMSCohen that this might have worse performance, but we'd have to decide if that's worth it.
claunia commented 2026-01-30 22:15:52 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (May 14, 2019):

This may be a duplicate of #621. I'm just putting all my internal notes/bugs into GitHub.

@miniksa commented on GitHub (May 14, 2019): This may be a duplicate of #621. I'm just putting all my internal notes/bugs into GitHub.
claunia commented 2026-01-30 22:15:52 +00:00
Author
Owner
Copy Link

@MilesMSCohen commented on GitHub (May 14, 2019):

Cool, let me know how it turns out.

-Miles

From: Michael Niksa notifications@github.com
Sent: Tuesday, May 14, 2019 9:56 AM
To: microsoft/Terminal Terminal@noreply.github.com
Cc: Miles Cohen Miles.Cohen@microsoft.com; Mention mention@noreply.github.com
Subject: [microsoft/Terminal] Glow text exploration (#781)

OK. The glow text example I gave that's currently inside the code (but unused) isn't great.

I've received feedback from @MilesMSCohenhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMilesMSCohen&data=01%7C01%7CMiles.Cohen%40microsoft.com%7Cf642b9b679dd4bd3058308d6d88d143d%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=8FvjCLBuTT2gxKWS%2BwNO11iGPYEGTfXFNWa4se6hRx4%3D&reserved=0 that it has a fundamental flaw:

  • It loses all font hinting which makes it hard to read, especially at small sizes.

Ouch. I want hinting. The recommended alternative is to render the text to a command list and use the command list as input to an effect that can cause a glow.

@DHowett-MSFThttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDHowett-MSFT&data=01%7C01%7CMiles.Cohen%40microsoft.com%7Cf642b9b679dd4bd3058308d6d88d143d%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=%2FJm5h%2BzWXhbkQRbfTb2uccLWB9wifBoW3dyWPLruUhw%3D&reserved=0 already had a sample lump of code to do something like this that he was playing around with a few weeks ago because glow text is cool. It's around here somewhere.

Also, I got the warning from @MilesMSCohenhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMilesMSCohen&data=01%7C01%7CMiles.Cohen%40microsoft.com%7Cf642b9b679dd4bd3058308d6d88d143d%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=8FvjCLBuTT2gxKWS%2BwNO11iGPYEGTfXFNWa4se6hRx4%3D&reserved=0 that this might have worse performance, but we'd have to decide if that's worth it.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTerminal%2Fissues%2F781%3Femail_source%3Dnotifications%26email_token%3DAJGBLHDF3NFUCPWUV3QUC5DPVLVK7A5CNFSM4HM33EZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GTXIDFA&data=01%7C01%7CMiles.Cohen%40microsoft.com%7Cf642b9b679dd4bd3058308d6d88d143d%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=pfxZ2d6qay%2BT38SJctZ4JuMiVZWp9fjh7osbeWNpxXI%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJGBLHB52Q3X7L25KP3DQATPVLVK7ANCNFSM4HM33EZA&data=01%7C01%7CMiles.Cohen%40microsoft.com%7Cf642b9b679dd4bd3058308d6d88d143d%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=XjHMX%2FpgH3dGtLkH1j%2BSH48TJEWHai847CpV5hBIvl4%3D&reserved=0.

@MilesMSCohen commented on GitHub (May 14, 2019): Cool, let me know how it turns out. -Miles From: Michael Niksa <notifications@github.com> Sent: Tuesday, May 14, 2019 9:56 AM To: microsoft/Terminal <Terminal@noreply.github.com> Cc: Miles Cohen <Miles.Cohen@microsoft.com>; Mention <mention@noreply.github.com> Subject: [microsoft/Terminal] Glow text exploration (#781) OK. The glow text example I gave that's currently inside the code (but unused) isn't great. I've received feedback from @MilesMSCohen<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMilesMSCohen&data=01%7C01%7CMiles.Cohen%40microsoft.com%7Cf642b9b679dd4bd3058308d6d88d143d%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=8FvjCLBuTT2gxKWS%2BwNO11iGPYEGTfXFNWa4se6hRx4%3D&reserved=0> that it has a fundamental flaw: * It loses all font hinting which makes it hard to read, especially at small sizes. Ouch. I want hinting. The recommended alternative is to render the text to a command list and use the command list as input to an effect that can cause a glow. @DHowett-MSFT<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDHowett-MSFT&data=01%7C01%7CMiles.Cohen%40microsoft.com%7Cf642b9b679dd4bd3058308d6d88d143d%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=%2FJm5h%2BzWXhbkQRbfTb2uccLWB9wifBoW3dyWPLruUhw%3D&reserved=0> already had a sample lump of code to do something like this that he was playing around with a few weeks ago because glow text is cool. It's around here somewhere. Also, I got the warning from @MilesMSCohen<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMilesMSCohen&data=01%7C01%7CMiles.Cohen%40microsoft.com%7Cf642b9b679dd4bd3058308d6d88d143d%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=8FvjCLBuTT2gxKWS%2BwNO11iGPYEGTfXFNWa4se6hRx4%3D&reserved=0> that this might have worse performance, but we'd have to decide if that's worth it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTerminal%2Fissues%2F781%3Femail_source%3Dnotifications%26email_token%3DAJGBLHDF3NFUCPWUV3QUC5DPVLVK7A5CNFSM4HM33EZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GTXIDFA&data=01%7C01%7CMiles.Cohen%40microsoft.com%7Cf642b9b679dd4bd3058308d6d88d143d%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=pfxZ2d6qay%2BT38SJctZ4JuMiVZWp9fjh7osbeWNpxXI%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJGBLHB52Q3X7L25KP3DQATPVLVK7ANCNFSM4HM33EZA&data=01%7C01%7CMiles.Cohen%40microsoft.com%7Cf642b9b679dd4bd3058308d6d88d143d%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=XjHMX%2FpgH3dGtLkH1j%2BSH48TJEWHai847CpV5hBIvl4%3D&reserved=0>.
claunia commented 2026-01-30 22:15:53 +00:00
Author
Owner
Copy Link

@weswigham commented on GitHub (Oct 24, 2019):

I'd love for the ability to declare glow parameters for text of specific colors (rather than for all text or none), mostly just to complete a synthwave terminal theme.

@weswigham commented on GitHub (Oct 24, 2019): I'd love for the ability to declare glow parameters for text of specific colors (rather than for all text or none), mostly just to complete a synthwave terminal theme.
claunia commented 2026-01-30 22:15:53 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Feb 11, 2020):

https://github.com/microsoft/terminal/pull/3468 added glow effects. Not sure if your original code was replaced in the process (but most likely). But this issue may be fixed already.

@WSLUser commented on GitHub (Feb 11, 2020): https://github.com/microsoft/terminal/pull/3468 added glow effects. Not sure if your original code was replaced in the process (but most likely). But this issue may be fixed already.
claunia commented 2026-01-30 22:15:53 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 22, 2021):

You know, with custom shaders (#7013), I don't think we really need to re-explore this. Let's just let folks do their own shader thing, that's been pretty dang flexible so far.

@zadjii-msft commented on GitHub (Nov 22, 2021): You know, with custom shaders (#7013), I don't think we really need to re-explore this. Let's just let folks do their own shader thing, that's been pretty dang flexible so far.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Extensibility Area-Rendering Issue-Task Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1075
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?