starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1107] [MERGED] Implement background image over acrylic or solid color #24478

New Issue
Open
opened 2026-01-31 09:03:32 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:03:32 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1107
Author: @Summon528
Created: 6/2/2019
Status: ✅ Merged
Merged: 7/10/2019
Merged by: @DHowett-MSFT

Base: master ← Head: acrylic-bg-img

📝 Commits (7)

  • 027c8bc Add acrylic background image
  • ab91a3d Background -> bg
  • 5d6860e Update comment
  • eda98df Use Controls::Image
  • d36d0d0 Update src/cascadia/TerminalControl/TermControl.h
  • 23e6b4c img on top of acrylic
  • b09b765 Simplify _BackgroundColorChanged()

📊 Changes

2 files changed (+34 additions, -56 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+33 -56)
📝 src/cascadia/TerminalControl/TermControl.h (+1 -0)

📄 Description

Summary of the Pull Request

Implement acrylic over background image. Also make backgroundImageOpacity works with respect to the profile's background color

References

PR Checklist

  • Closes #1075 Closes Icons flash for a frame when switching tabs (#1762)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Introduce a new root Element that holds the original container and a background image. The root element's background sits behind _bgImageLayer and is responsible for acrylic and solid background.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1107 **Author:** [@Summon528](https://github.com/Summon528) **Created:** 6/2/2019 **Status:** ✅ Merged **Merged:** 7/10/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `acrylic-bg-img` --- ### 📝 Commits (7) - [`027c8bc`](https://github.com/microsoft/terminal/commit/027c8bc4339c02465e8b2f1278b25e4af3d0ce2a) Add acrylic background image - [`ab91a3d`](https://github.com/microsoft/terminal/commit/ab91a3d08cf0bf647e5bd3a3ed7c7a175f6676e7) Background -> bg - [`5d6860e`](https://github.com/microsoft/terminal/commit/5d6860e38befa6f1467d962340553ef84a35b67f) Update comment - [`eda98df`](https://github.com/microsoft/terminal/commit/eda98df089e2a8a53a064c23d37acc3315250a52) Use Controls::Image - [`d36d0d0`](https://github.com/microsoft/terminal/commit/d36d0d0c04792bb8be52e790cf6a3cb4d05b22bb) Update src/cascadia/TerminalControl/TermControl.h - [`23e6b4c`](https://github.com/microsoft/terminal/commit/23e6b4c2633700d77fdbe87e4a1f2089c34d92b5) img on top of acrylic - [`b09b765`](https://github.com/microsoft/terminal/commit/b09b765cc8a68468b645b0f94d6a049daf0a8e70) Simplify _BackgroundColorChanged() ### 📊 Changes **2 files changed** (+34 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+33 -56) 📝 `src/cascadia/TerminalControl/TermControl.h` (+1 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Implement acrylic over background image. Also make backgroundImageOpacity works with respect to the profile's background color <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #1075 Closes #1762 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Introduce a new root Element that holds the original container and a background image. The root element's background sits behind `_bgImageLayer` and is responsible for acrylic and solid background. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:32 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24478
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?