starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Dragging a tab from Visual Studio Code onto Windows Terminal causes it to crash. #10853

New Issue
Closed
opened 2026-01-31 02:32:01 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 02:32:01 +00:00
Owner
Copy Link

Originally created by @bhelyer on GitHub (Oct 2, 2020).

Environment

Windows build number: Microsoft Windows NT 10.0.19041.0
Windows Terminal version (if applicable): 1.3.2651.0
VS Code: 1.49.2

Steps to reproduce

  1. Open Windows terminal (Powershell or Cmd, doesn't seem to matter)
  2. Open Visual Studio Code
  3. Drag the 'Welcome' tab (or any other) onto Windows Terminal

(Note that this occured because I missed when using VS Code, not because I thought it would do something meaningful.)

Expected behavior

Nothing, or an error to be generated. I don't rightly know what VS Code sends out when you drag a tab, I'm just expecting Windows Terminal not to crash.

Actual behavior

Windows Terminal closes, taking all my tabs with it as punishment for my failure to accurately use a mouse.

Originally created by @bhelyer on GitHub (Oct 2, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: Microsoft Windows NT 10.0.19041.0 Windows Terminal version (if applicable): 1.3.2651.0 VS Code: 1.49.2 ``` # Steps to reproduce 1. Open Windows terminal (Powershell or Cmd, doesn't seem to matter) 2. Open Visual Studio Code 3. Drag the 'Welcome' tab (or any other) onto Windows Terminal (Note that this occured because I missed when using VS Code, not because I thought it would do something meaningful.) # Expected behavior Nothing, or an error to be generated. I don't rightly know what VS Code sends out when you drag a tab, I'm just expecting Windows Terminal not to crash. # Actual behavior Windows Terminal closes, taking all my tabs with it as punishment for my failure to accurately use a mouse.
claunia commented 2026-01-31 02:32:03 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 2, 2020):

Whoa, that's wild. That's totally unexpected.

@DHowett commented on GitHub (Oct 2, 2020): Whoa, that's _wild_. That's totally unexpected.
claunia commented 2026-01-31 02:32:03 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 2, 2020):

Looks like VSCode generates a malformed clipboard/drop object; we should be more resilient.

The WinRT DataItems API is failing when we ask "give us the files you said were dropped on me" here (2852):

4a114971f9/src/cascadia/TerminalControl/TermControl.cpp (L2850-L2853)

@DHowett commented on GitHub (Oct 2, 2020): Looks like VSCode generates a malformed clipboard/drop object; we should be more resilient. The WinRT DataItems API is failing when we ask "give us the files you said were dropped on me" here (2852): https://github.com/microsoft/terminal/blob/4a114971f966be4d85113bf160a9a4603a62fc02/src/cascadia/TerminalControl/TermControl.cpp#L2850-L2853
claunia commented 2026-01-31 02:32:03 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (Oct 19, 2020):

I can easily reproduce this. And it is easy to fix the crash by simply catching it. But I kinda want it to work and haven't figured out a way to do so.

For reference, both Edge and Firefox handles the tab dropping from VSCode as a file URI (file://something). Surprisely explorer.exe handles it as an actual file and will paste it to the current directory.

A side note: Should we also support ApplicationLInk and WebLink? Then you can drag and drop an URL from browser and it will be pasted into the terminal. I've tested it and it works pretty well.

@skyline75489 commented on GitHub (Oct 19, 2020): I can easily reproduce this. And it is easy to fix the crash by simply catching it. But I kinda want it to *work* and haven't figured out a way to do so. For reference, both Edge and Firefox handles the tab dropping from VSCode as a file URI (file://something). Surprisely `explorer.exe` handles it as an *actual* file and will paste it to the current directory. A side note: Should we also support `ApplicationLInk` and `WebLink`? Then you can drag and drop an URL from browser and it will be pasted into the terminal. I've tested it and it works pretty well.
claunia commented 2026-01-31 02:32:03 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8461, which has now been successfully released as Windows Terminal v1.5.10271.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8461, which has now been successfully released as `Windows Terminal v1.5.10271.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.5.10271.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 02:32:04 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8461, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8461, which has now been successfully released as `Windows Terminal Preview v1.6.10272.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10272.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Priority-2 Product-Terminal Resolution-Fix-Committed Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10853
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?