[PR #10863] [MERGED] Fix setting wght axis font bugs #28267

Open
opened 2026-01-31 09:27:24 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10863
Author: @PankajBhojwani
Created: 8/3/2021
Status: Merged
Merged: 8/25/2021
Merged by: @undefined

Base: mainHead: dev/pabhoj/font_fixes


📝 Commits (10+)

📊 Changes

3 files changed (+96 additions, -11 deletions)

View changed files

📝 src/renderer/dx/CustomTextLayout.cpp (+9 -2)
📝 src/renderer/dx/DxFontRenderData.cpp (+80 -9)
📝 src/renderer/dx/DxFontRenderData.h (+7 -0)

📄 Description

  • When deciding whether to call _AnalyzeFontFallback, also check if the user set any font axes
  • Do not use the user set weight if we are setting the weight due to the bold attribute
  • When calling FontFaceWithAttribute, check if the user set the italic axis as well as the text attribute

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10863 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 8/3/2021 **Status:** ✅ Merged **Merged:** 8/25/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/font_fixes` --- ### 📝 Commits (10+) - [`2ef5957`](https://github.com/microsoft/terminal/commit/2ef595737e37a96414a9086f1fa7af44fa27df75) fixes - [`6519ae4`](https://github.com/microsoft/terminal/commit/6519ae46c358fbfaa4a36ef8b646f2e24749b6e1) Merge branch 'main' of https://github.com/microsoft/terminal into dev/pabhoj/font_fixes - [`b5f4599`](https://github.com/microsoft/terminal/commit/b5f4599ae48f21855e2e781902254901cacfdfb1) move suppress warning - [`9c2ec08`](https://github.com/microsoft/terminal/commit/9c2ec0897e4b1fee90629fede751aacb6d25c4d6) ignore user weight if text attribute is bold - [`5870897`](https://github.com/microsoft/terminal/commit/5870897432c1f295b338168652bf95dfca08503c) Merge branch 'main' of https://github.com/microsoft/terminal into dev/pabhoj/font_fixes - [`5b966cc`](https://github.com/microsoft/terminal/commit/5b966ccd556f581d9d67f588e40f4fdbd9ff6f68) check user italic - [`ecabb56`](https://github.com/microsoft/terminal/commit/ecabb56082676c927955bcc54a26fb8266e618af) routine descriptions - [`8a69027`](https://github.com/microsoft/terminal/commit/8a69027eb7c48975daad398523ba0bed616a2fe0) Merge branch 'main' of https://github.com/microsoft/terminal into dev/pabhoj/font_fixes - [`e5d2e74`](https://github.com/microsoft/terminal/commit/e5d2e7480f5d5707f5f1c03b48aea7cca6ff6fb3) set didUserSetAxes to false initially - [`3da4e81`](https://github.com/microsoft/terminal/commit/3da4e8193ed1bd28f5d80dc191ac50e9c494db1b) new temporary vector instead ### 📊 Changes **3 files changed** (+96 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/renderer/dx/CustomTextLayout.cpp` (+9 -2) 📝 `src/renderer/dx/DxFontRenderData.cpp` (+80 -9) 📝 `src/renderer/dx/DxFontRenderData.h` (+7 -0) </details> ### 📄 Description - When deciding whether to call `_AnalyzeFontFallback`, also check if the user set any font axes - Do not use the user set weight if we are setting the weight due to the bold attribute - When calling `FontFaceWithAttribute`, check if the user set the italic axis as well as the text attribute * [x] Closes #10852 * [x] Closes #10853 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:24 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28267