starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Impossible to set custom tab color after setting it to black #11057

New Issue
Closed
opened 2026-01-31 02:37:27 +00:00 by claunia · 15 comments
claunia commented 2026-01-31 02:37:27 +00:00
Owner
Copy Link

Originally created by @ItsMeSousuke on GitHub (Oct 16, 2020).

Environment

Windows build number: Win32NT, 10.0.18362.0 Microsoft Windows NT 10.0.18362.0
Windows Terminal version (if applicable): 1.3.2651.0

Steps to reproduce

  1. Right click on tab and select Color...
  2. Click Custom
  3. Click More
  4. Remove value from hex code field, tab background is set to black
  5. Try to pick any color from color picker

Expected behavior

User should be able to pick new color from color picker.

Actual behavior

Tab color is black and can't be change by picking color from color picker, it can be only change by selecting one from predefined list or by setting any other color hex code other than black
image

Originally created by @ItsMeSousuke on GitHub (Oct 16, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: Win32NT, 10.0.18362.0 Microsoft Windows NT 10.0.18362.0 Windows Terminal version (if applicable): 1.3.2651.0 ``` # Steps to reproduce 1. Right click on tab and select _Color..._ 1. Click _Custom_ 1. Click _More_ 1. Remove value from hex code field, tab background is set to black 1. Try to pick any color from color picker # Expected behavior User should be able to pick new color from color picker. # Actual behavior Tab color is black and can't be change by picking color from color picker, it can be only change by selecting one from predefined list or by setting any other color hex code other than black ![image](https://user-images.githubusercontent.com/13621655/96272672-b76d3800-0fce-11eb-9e16-d6197b2b27b0.png)
claunia commented 2026-01-31 02:37:28 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 16, 2020):

I can repro it:

image

@ghost commented on GitHub (Oct 16, 2020): I can repro it: ![image](https://user-images.githubusercontent.com/67918878/96273911-83edd600-0fed-11eb-8402-3a9da57e1a45.png)
claunia commented 2026-01-31 02:37:29 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 17, 2020):

I think this is an issue with the XAML ColorPicker control. Because I was able to reproduce this issue in XAML Controls Gallery

image

And a little more closer look:

image

@ghost commented on GitHub (Oct 17, 2020): I think this is an issue with the XAML ColorPicker control. Because I was able to reproduce this issue in XAML Controls Gallery ![image](https://user-images.githubusercontent.com/67918878/96326320-50429880-104d-11eb-8d89-fc32ddf6d2fd.png) And a little more closer look: ![image](https://user-images.githubusercontent.com/67918878/96326340-694b4980-104d-11eb-9a25-aa3aeb38e121.png)
claunia commented 2026-01-31 02:37:29 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 17, 2020):

This is what I think is the reason why this is not working

Look at this

Look at the slider. It is set to black. So if you change the color using that rainbow like thing, that slider is still at black.
You have to move the slider in order for it to work (and I have confirmed it).

This also explains why the color changes successfully when you choose a preset color or you give another hex value.

The funny thing is that Windows Terminal does not have this slider

This is probably because

The one with the slider:

image

The one that Windows Terminal be likely be using:

image

@ghost commented on GitHub (Oct 17, 2020): This is what I think is the reason why this is not working --- ![Look at this](https://user-images.githubusercontent.com/67918878/96326340-694b4980-104d-11eb-9a25-aa3aeb38e121.png) Look at the slider. It is set to black. So if you change the color using that rainbow like thing, that slider is still at black. You have to move the slider in order for it to work (and I have confirmed it). This also explains why the color changes successfully when you choose a preset color or you give another hex value. The funny thing is that Windows Terminal does not have this slider This is probably because The one with the slider: ![image](https://user-images.githubusercontent.com/67918878/96339185-9d0b8b00-10b0-11eb-9c6c-a4b1ed85b6ff.png) The one that Windows Terminal be likely be using: ![image](https://user-images.githubusercontent.com/67918878/96339213-d9d78200-10b0-11eb-8cb1-c598d98ecad5.png)
claunia commented 2026-01-31 02:37:29 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 17, 2020):

cc @DHowett @zadjii-msft

@ghost commented on GitHub (Oct 17, 2020): cc @DHowett @zadjii-msft
claunia commented 2026-01-31 02:37:29 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 19, 2020):

GIFing this problem:

(Sorry for my extremely bad GIFs. Especially the ColorPicker control 🤢)

The problem:

The problem

Demonstrating the problem and a possible fix in XAML Studio:

potential-fix

I think we can fix this by enabling Color Slider in the ColorPicker control.

I would like to make a PR on this if you agree on this fix (only if this fix is going to be as easy as I did in XAML Studio)

@ghost commented on GitHub (Oct 19, 2020): GIFing this problem: (Sorry for my extremely bad GIFs. Especially the ColorPicker control 🤢) The problem: ![The problem](https://user-images.githubusercontent.com/67918878/96421881-f55b9d80-1214-11eb-8f04-c81482947d64.gif) Demonstrating the problem and a possible fix in XAML Studio: ![potential-fix](https://user-images.githubusercontent.com/67918878/96422065-2dfb7700-1215-11eb-8da1-fae215383f17.gif) I think we can fix this by enabling Color Slider in the ColorPicker control. I would like to make a PR on this if you agree on this fix (only if this fix is going to be as easy as I did in XAML Studio)
claunia commented 2026-01-31 02:37:29 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Oct 19, 2020):

Is there an existing issue in https://github.com/microsoft/microsoft-ui-xaml/issues? This seems like a good workaround to add but ultimately this is a bug with the XAML framework and should be addressed by the WINUI team.

@WSLUser commented on GitHub (Oct 19, 2020): Is there an existing issue in https://github.com/microsoft/microsoft-ui-xaml/issues? This seems like a good workaround to add but ultimately this is a bug with the XAML framework and should be addressed by the WINUI team.
claunia commented 2026-01-31 02:37:30 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 19, 2020):

Yea, I think it's fine to fix locally for the Terminal with enabling the color slider, but I agree, we should file a follow-up on the WinUI repo that WSLUser linked.

@zadjii-msft commented on GitHub (Oct 19, 2020): Yea, I think it's fine to fix locally for the Terminal with enabling the color slider, but I agree, we should file a follow-up on the WinUI repo that WSLUser linked.
claunia commented 2026-01-31 02:37:30 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 19, 2020):

@zadjii-msft I will take up this issue

@ghost commented on GitHub (Oct 19, 2020): @zadjii-msft I will take up this issue
claunia commented 2026-01-31 02:37:30 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 19, 2020):

@zadjii-msft
Just point me to the right XAML file.

@ghost commented on GitHub (Oct 19, 2020): @zadjii-msft Just point me to the right XAML file.
claunia commented 2026-01-31 02:37:30 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 19, 2020):

https://github.com/microsoft/terminal/blob/master/src/cascadia/TerminalApp/ColorPickupFlyout.xaml

@zadjii-msft commented on GitHub (Oct 19, 2020): https://github.com/microsoft/terminal/blob/master/src/cascadia/TerminalApp/ColorPickupFlyout.xaml
claunia commented 2026-01-31 02:37:30 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 19, 2020):

@zadjii-msft

PR ready to be reviewed -> #7963

@ghost commented on GitHub (Oct 19, 2020): @zadjii-msft PR ready to be reviewed -> #7963
claunia commented 2026-01-31 02:37:30 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Oct 19, 2020):

So I did check and there isn't an existing issue on the WinUI repo. Please create a ticket and link to it here. The PR should be considered a workaround, not a "fix" and so this issue should be closed when we pick up a version of MUX with the fix. We should add the upstream-issue and workaround-available tags for tracking/visibility.

@WSLUser commented on GitHub (Oct 19, 2020): So I did check and there isn't an existing issue on the WinUI repo. Please create a ticket and link to it here. The PR should be considered a workaround, not a "fix" and so this issue should be closed when we pick up a version of MUX with the fix. We should add the `upstream-issue` and `workaround-available` tags for tracking/visibility.
claunia commented 2026-01-31 02:37:30 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 23, 2020):

I've filed https://github.com/microsoft/microsoft-ui-xaml/issues/3476 upstream, but I'm okay leaving this issue closed, because frankly, the picker is better off with the color slider visible. That makes it possible to pick both a lightness and a hue, which greatly increases the range of easily accessible tab colors.

Thanks for the investigation @alannt777!

@zadjii-msft commented on GitHub (Oct 23, 2020): I've filed https://github.com/microsoft/microsoft-ui-xaml/issues/3476 upstream, but I'm okay leaving this issue closed, because frankly, the picker is better off _with_ the color slider visible. That makes it possible to pick both a lightness and a hue, which greatly increases the range of easily accessible tab colors. Thanks for the investigation @alannt777!
claunia commented 2026-01-31 02:37:31 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 11, 2020):

:tada:This issue was addressed in #7963, which has now been successfully released as Windows Terminal v1.4.3141.0.🎉

Handy links:

@ghost commented on GitHub (Nov 11, 2020): :tada:This issue was addressed in #7963, which has now been successfully released as `Windows Terminal v1.4.3141.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.4.3141.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 02:37:31 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 11, 2020):

:tada:This issue was addressed in #7963, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.🎉

Handy links:

@ghost commented on GitHub (Nov 11, 2020): :tada:This issue was addressed in #7963, which has now been successfully released as `Windows Terminal Preview v1.5.3142.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.5.3142.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface good first issue Help Wanted Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11057
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?