starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Close an unfocused tab (using mouse) results in focus switched #1113

New Issue
Closed
opened 2026-01-30 22:16:46 +00:00 by claunia · 8 comments
claunia commented 2026-01-30 22:16:46 +00:00
Owner
Copy Link

Originally created by @bef178 on GitHub (May 15, 2019).

This bug comes with #737. Very sorry for not having a full test.

Repo:
open tab a,b,c,d
activate c
mouse close a
expected: c is shown and is the only highlight in tabview
actual: b is shown as focused tab

Originally created by @bef178 on GitHub (May 15, 2019). This bug comes with #737. Very sorry for not having a full test. Repo: open tab a,b,c,d activate c mouse close a expected: c is shown and is the only highlight in tabview actual: b is shown as focused tab
claunia added the Issue-BugNeeds-Tag-FixProduct-TerminalArea-UserInterface labels 2026-01-30 22:16:46 +00:00
claunia commented 2026-01-30 22:16:47 +00:00
Author
Owner
Copy Link

@bef178 commented on GitHub (May 15, 2019):

Manual test cases:

open tab a,b,c,d
activate a
ctrl-w
ctrl-w
expect c is shown and is the only highlight in tabview

open tab a,b,c,d
activate a
mouse close a
mouse close b
expect c is shown and is the only highlight in tabview

open tab a,b,c,d
activate c
mouse close a
expect c is shown and is the only highlight in tabview
alt-1
expect b is shown and is the only highlight in tabview

open tab a,b,c,d
activate c
mouse close a
expect c is shown and is the only highlight in tabview
mouse activate b
expect b is shown and is the only highlight in tabview

open tab a,b,c,d,e
activate c
ctrl-w
ctrl-w
ctrl-w
expect d is shown and is the only highlight in tabview
ctrl-w
expect e is shown and tabview is hided

@bef178 commented on GitHub (May 15, 2019): Manual test cases: open tab a,b,c,d activate a ctrl-w ctrl-w expect c is shown and is the only highlight in tabview open tab a,b,c,d activate a mouse close a mouse close b expect c is shown and is the only highlight in tabview open tab a,b,c,d activate c mouse close a expect c is shown and is the only highlight in tabview alt-1 expect b is shown and is the only highlight in tabview open tab a,b,c,d activate c mouse close a expect c is shown and is the only highlight in tabview mouse activate b expect b is shown and is the only highlight in tabview open tab a,b,c,d,e activate c ctrl-w ctrl-w ctrl-w expect d is shown and is the only highlight in tabview ctrl-w expect e is shown and tabview is hided
claunia commented 2026-01-30 22:16:47 +00:00
Author
Owner
Copy Link

@bef178 commented on GitHub (May 15, 2019):

And is there any place to put manual test cases? In case of unconsciously / accidentally breaking other features.

@bef178 commented on GitHub (May 15, 2019): And is there any place to put manual test cases? In case of unconsciously / accidentally breaking other features.
claunia commented 2026-01-30 22:16:48 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 15, 2019):

We actually don't have any UI tests set up quite yet, though I think someone is working on them, so you don't really need to worry about adding them yourself quite yet.

@zadjii-msft commented on GitHub (May 15, 2019): We actually don't have any UI tests set up quite yet, though I think someone is working on them, so you don't really need to worry about adding them yourself quite yet.
claunia commented 2026-01-30 22:16:48 +00:00
Author
Owner
Copy Link

@bef178 commented on GitHub (May 15, 2019):

I wish I will not break other features.

@bef178 commented on GitHub (May 15, 2019): I wish I will not break other features.
claunia commented 2026-01-30 22:16:48 +00:00
Author
Owner
Copy Link

@binarycrusader commented on GitHub (May 16, 2019):

I wish I will not break other features.

Any work worth doing always has a chance of bugs--the important thing is to record them when found, learn the cause, and work on getting them fixed 🙌

@binarycrusader commented on GitHub (May 16, 2019): > I wish I will not break other features. Any work worth doing always has a chance of bugs--the important thing is to record them when found, learn the cause, and work on getting them fixed 🙌
claunia commented 2026-01-30 22:16:48 +00:00
Author
Owner
Copy Link

@bef178 commented on GitHub (May 16, 2019):

You're right

@bef178 commented on GitHub (May 16, 2019): You're right
claunia commented 2026-01-30 22:16:48 +00:00
Author
Owner
Copy Link

@bef178 commented on GitHub (May 23, 2019):

The described behavior should be gone in master. Closing.

@bef178 commented on GitHub (May 23, 2019): The described behavior should be gone in master. Closing.
claunia commented 2026-01-30 22:16:49 +00:00
Author
Owner
Copy Link

@zeimao77 commented on GitHub (May 30, 2019):

linux vim ctrl-w
Switching the VIM window causes the terminal to close

@zeimao77 commented on GitHub (May 30, 2019): linux vim ctrl-w Switching the VIM window causes the terminal to close
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1113
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?