starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1113] [MERGED] Fix OpenConsole.psm1 to use vswhere #24486

New Issue
Open
opened 2026-01-31 09:03:35 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:03:35 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1113
Author: @strega-nil
Created: 6/3/2019
Status: ✅ Merged
Merged: 6/7/2019
Merged by: @undefined

Base: master ← Head: master

📝 Commits (5)

  • 2817e80 Fix OpenConsole.psm1 to use vswhere
  • e1d2be0 Do as @DHowett-MSFT says and use VSSetup
  • cc418f6 try to do what @heaths is recommending
  • 54e6916 fix Import-LocalModule
  • cb46849 fix openconsole.psm1 for hopefully the last time

📊 Changes

2 files changed (+75 additions, -6 deletions)

View changed files

📝 .gitignore (+3 -0)
📝 tools/OpenConsole.psm1 (+72 -6)

📄 Description

Summary of the Pull Request

I'm not sure this is good, since I don't write a lot of powershell, and
I don't know the project very well, but hopefully it's good!

PR Checklist

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1113 **Author:** [@strega-nil](https://github.com/strega-nil) **Created:** 6/3/2019 **Status:** ✅ Merged **Merged:** 6/7/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`2817e80`](https://github.com/microsoft/terminal/commit/2817e8007fd074376c170a2d5f7ad7b6ee1e50d4) Fix OpenConsole.psm1 to use vswhere - [`e1d2be0`](https://github.com/microsoft/terminal/commit/e1d2be08035507b02c43cdb4624563ed65fc3e1d) Do as @DHowett-MSFT says and use VSSetup - [`cc418f6`](https://github.com/microsoft/terminal/commit/cc418f6456df7927f08618a0545fd3e7545c90b7) try to do what @heaths is recommending - [`54e6916`](https://github.com/microsoft/terminal/commit/54e6916201bc144b8ccc6c41ac26b55d46414d6d) fix `Import-LocalModule` - [`cb46849`](https://github.com/microsoft/terminal/commit/cb4684944c2e411728386897806a2e0db0f3f6f2) fix openconsole.psm1 for hopefully the last time ### 📊 Changes **2 files changed** (+75 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+3 -0) 📝 `tools/OpenConsole.psm1` (+72 -6) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request I'm not sure this is good, since I don't write a lot of powershell, and I don't know the project very well, but hopefully it's good! <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #930 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:35 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24486
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?