starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Some panes stop resizing after other panes are closed #11345

New Issue
Closed
opened 2026-01-31 02:45:00 +00:00 by claunia · 12 comments
claunia commented 2026-01-31 02:45:00 +00:00
Owner
Copy Link

Originally created by @valorin on GitHub (Nov 12, 2020).

There appears to be an issue caused by animations when panes are closed. With animations enabled and multiple panes (3+) in use, when you close a panel and attempt to resize the remaining panes, some of the panes don't resize correctly. I haven't tested extensively, however it appears that the created panes are the ones that cannot resize, while the original pane does get resized.

This is on the new Preview that was released today.

UPDATE: This doesn't appear to require animations enabled. I've experienced it with animations disabled when moving around and closing panes. It seems to be triggered first by removing a pane, as everything works as expected until I close something. After that point, the behaviour is weird and some panes stop resizing.

I'll leave the steps below as-is, as that's the most reliable way to replicate that I've discovered.

Environment

Windows build number: 10.0.19041.0
Windows Terminal version: Preview 1.5.3142.0

Steps to reproduce

  1. Ensure animations are enabled in the config ("disableAnimations": false),
  2. Split the terminal into three panes. I've been using a vertical then a horizontal split: 
    { "command": { "action": "wt", "commandline": "split-pane -V ; split-pane -H" }, "keys": "ctrl+alt+shift+l" },
  3. Close the second panel. For me this is top-right. The third pane correctly resizes to fill the gap left from the closed panel.
  4. Resize the remaining pane divider

Expected behavior

The pane divider should resize, with both panes included.

Actual behavior

The first pane is resized, but the second (originally the third) stays where it is. As a result, you either have a gray gap between the two panes, or the first pane covers up the second pane.

Toggling "disableAnimations": true to disable animations fixes the issue and the panes resize correctly.

3 panes showing top before the second pane is closed

image

Remaining two panes showing the second pane no resizing with the the first:

image
image

Originally created by @valorin on GitHub (Nov 12, 2020). There appears to be an issue caused by animations when panes are closed. With animations enabled and multiple panes (3+) in use, when you close a panel and attempt to resize the remaining panes, some of the panes don't resize correctly. I haven't tested extensively, however it appears that the created panes are the ones that cannot resize, while the original pane does get resized. This is on the new Preview that was released today. **UPDATE:** This doesn't appear to require animations enabled. I've experienced it with animations disabled when moving around and closing panes. It seems to be triggered first by removing a pane, as everything works as expected until I close something. After that point, the behaviour is weird and some panes stop resizing. I'll leave the steps below as-is, as that's the most reliable way to replicate that I've discovered. # Environment ```none Windows build number: 10.0.19041.0 Windows Terminal version: Preview 1.5.3142.0 ``` # Steps to reproduce 1. Ensure animations are enabled in the config (`"disableAnimations": false`), 2. Split the terminal into three panes. I've been using a vertical then a horizontal split: ``` { "command": { "action": "wt", "commandline": "split-pane -V ; split-pane -H" }, "keys": "ctrl+alt+shift+l" }, ``` 3. Close the second panel. For me this is top-right. _The third pane correctly resizes to fill the gap left from the closed panel._ 4. Resize the remaining pane divider # Expected behavior The pane divider should resize, with both panes included. # Actual behavior The first pane is resized, but the second (originally the third) stays where it is. As a result, you either have a gray gap between the two panes, or the first pane covers up the second pane. Toggling `"disableAnimations": true` to disable animations fixes the issue and the panes resize correctly. **3 panes showing `top` before the second pane is closed** ![image](https://user-images.githubusercontent.com/897369/98879873-425c2800-24d2-11eb-9640-2615968dd260.png) **Remaining two panes showing the second pane no resizing with the the first:** ![image](https://user-images.githubusercontent.com/897369/98879968-6a4b8b80-24d2-11eb-900d-46e05490c7c1.png) ![image](https://user-images.githubusercontent.com/897369/98879974-6e77a900-24d2-11eb-8a3d-3ffd40351f06.png)
claunia commented 2026-01-31 02:45:02 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 12, 2020):

@valorin - for me the problem occurs only when animations are enabled. Could not reproduce it with animations disabled.
[Update] - was able to reproduce it without animations, but in more complex scenario.

@Don-Vito commented on GitHub (Nov 12, 2020): @valorin - for me the problem occurs only when animations are enabled. Could not reproduce it with animations disabled. [Update] - was able to reproduce it without animations, but in more complex scenario.
claunia commented 2026-01-31 02:45:03 +00:00
Author
Owner
Copy Link

@valorin commented on GitHub (Nov 12, 2020):

Yeah that's exactly what happened with me. It's simple with animations, but harder and more random without them.

@valorin commented on GitHub (Nov 12, 2020): Yeah that's exactly what happened with me. It's simple with animations, but harder and more random without them.
claunia commented 2026-01-31 02:45:03 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 12, 2020):

BTW, it looks that disabling animation applies only to the "close pane" animation, but not to pane entrance animation.
@zadjii-msft - is it intentional?

@Don-Vito commented on GitHub (Nov 12, 2020): BTW, it looks that disabling animation applies only to the "close pane" animation, but not to pane entrance animation. @zadjii-msft - is it intentional?
claunia commented 2026-01-31 02:45:04 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 12, 2020):

@Don-Vito It most certainly is not

@zadjii-msft commented on GitHub (Nov 12, 2020): @Don-Vito It most certainly is _not_
claunia commented 2026-01-31 02:45:04 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 12, 2020):

@Don-Vito It most certainly is not

NP. I am creating a PR to allow disabling 😊

@Don-Vito commented on GitHub (Nov 12, 2020): > > > @Don-Vito It most certainly is _not_ NP. I am creating a PR to allow disabling :blush:
claunia commented 2026-01-31 02:45:04 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 12, 2020):

In any case with animations fully disabled (both close and entrance), I am currently unable to reproduce the issue.. of course probably the issue is somewhere else and animations just increase the probability.

@Don-Vito commented on GitHub (Nov 12, 2020): In any case with animations fully disabled (both close and entrance), I am currently unable to reproduce the issue.. of course probably the issue is somewhere else and animations just increase the probability.
claunia commented 2026-01-31 02:45:05 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 12, 2020):

@zadjii-msft - I think I have a direction here 😊 This is a race. If you split the panes manually and slowly (aka after the animation has finished) no problem occurs.

My guess is that in the completion of the animation, when you access the pane, it already has other children.

I fixed it locally and it seems to work (although this is a race and you can never know 😊). Creating the PR for this one as well

@Don-Vito commented on GitHub (Nov 12, 2020): @zadjii-msft - I think I have a direction here 😊 This is a race. If you split the panes manually and slowly (aka after the animation has finished) no problem occurs. My guess is that in the completion of the animation, when you access the pane, it already has other children. I fixed it locally and it seems to work (although this is a race and you can never know :blush:). Creating the PR for this one as well
claunia commented 2026-01-31 02:45:05 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 12, 2020):

@zadjii-msft - actually I am not sure what is the best fix. What I am doing in PR is to ensure that the correct control gets the stretch alignment back.

However the problem is more severe: during the animation the pane children might change. This applies not just for entrance animation but for the close animation as well. I am not sure what should be the approach - to lock the panes during the animation?

@Don-Vito commented on GitHub (Nov 12, 2020): @zadjii-msft - actually I am not sure what is the best fix. What I am doing in PR is to ensure that the correct control gets the stretch alignment back. However the problem is more severe: during the animation the pane children might change. This applies not just for entrance animation but for the close animation as well. I am not sure what should be the approach - to lock the panes during the animation?
claunia commented 2026-01-31 02:45:06 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 12, 2020):

Related to https://github.com/microsoft/terminal/issues/7942

@Don-Vito commented on GitHub (Nov 12, 2020): Related to https://github.com/microsoft/terminal/issues/7942
claunia commented 2026-01-31 02:45:07 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 12, 2020):

You know, locking the panes during the animation sounds like a really good idea, one that would probably resolve a whole host of these issues.

@zadjii-msft commented on GitHub (Nov 12, 2020): You know, locking the panes during the animation _sounds_ like a really good idea, one that would probably resolve a whole host of these issues.
claunia commented 2026-01-31 02:45:07 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8241, which has now been successfully released as Windows Terminal v1.5.10271.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8241, which has now been successfully released as `Windows Terminal v1.5.10271.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.5.10271.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 02:45:07 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8241, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8241, which has now been successfully released as `Windows Terminal Preview v1.6.10272.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10272.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Priority-1 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11345
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?