starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #11345] [MERGED] Use the til::enumset type for the GridLines enum in the renderers #28507

New Issue
Open
opened 2026-01-31 09:28:59 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:28:59 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11345
Author: @j4james
Created: 9/28/2021
Status: ✅ Merged
Merged: 9/29/2021
Merged by: @undefined

Base: main ← Head: enumset-in-gridlines

📝 Commits (1)

  • 26af5be Use til::enumset for the renderer GridLines enum.

📊 Changes

15 files changed (+57 additions, -58 deletions)

View changed files

📝 src/interactivity/onecore/BgfxEngine.cpp (+1 -1)
📝 src/interactivity/onecore/BgfxEngine.hpp (+1 -1)
📝 src/renderer/base/renderer.cpp (+14 -14)
📝 src/renderer/base/renderer.hpp (+1 -1)
📝 src/renderer/dx/DxRenderer.cpp (+12 -12)
📝 src/renderer/dx/DxRenderer.hpp (+1 -1)
📝 src/renderer/gdi/gdirenderer.hpp (+1 -1)
📝 src/renderer/gdi/paint.cpp (+8 -8)
📝 src/renderer/inc/IRenderEngine.hpp (+12 -13)
📝 src/renderer/uia/UiaRenderer.cpp (+1 -1)
📝 src/renderer/uia/UiaRenderer.hpp (+1 -1)
📝 src/renderer/vt/paint.cpp (+1 -1)
📝 src/renderer/vt/vtrenderer.hpp (+1 -1)
📝 src/renderer/wddmcon/WddmConRenderer.cpp (+1 -1)
📝 src/renderer/wddmcon/WddmConRenderer.hpp (+1 -1)

📄 Description

Summary of the Pull Request

This replaces the GridLines enum in the renderers with a til::enumset type, avoiding the need for the various WI_IsFlagSet macros and flag operators.

References

This is followup to PR #10492 which introduced the enumset class.

PR Checklist

  • Closes #xxx
  • CLA signed.
  • Tests added/passed
  • Documentation updated.
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.

Validation Steps Performed

I've manually confirmed that all the different gridlines are still rendering correctly in both the GDI and DX renderers.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11345 **Author:** [@j4james](https://github.com/j4james) **Created:** 9/28/2021 **Status:** ✅ Merged **Merged:** 9/29/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `enumset-in-gridlines` --- ### 📝 Commits (1) - [`26af5be`](https://github.com/microsoft/terminal/commit/26af5be0071c80fa415205843fd519173add1636) Use til::enumset for the renderer GridLines enum. ### 📊 Changes **15 files changed** (+57 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `src/interactivity/onecore/BgfxEngine.cpp` (+1 -1) 📝 `src/interactivity/onecore/BgfxEngine.hpp` (+1 -1) 📝 `src/renderer/base/renderer.cpp` (+14 -14) 📝 `src/renderer/base/renderer.hpp` (+1 -1) 📝 `src/renderer/dx/DxRenderer.cpp` (+12 -12) 📝 `src/renderer/dx/DxRenderer.hpp` (+1 -1) 📝 `src/renderer/gdi/gdirenderer.hpp` (+1 -1) 📝 `src/renderer/gdi/paint.cpp` (+8 -8) 📝 `src/renderer/inc/IRenderEngine.hpp` (+12 -13) 📝 `src/renderer/uia/UiaRenderer.cpp` (+1 -1) 📝 `src/renderer/uia/UiaRenderer.hpp` (+1 -1) 📝 `src/renderer/vt/paint.cpp` (+1 -1) 📝 `src/renderer/vt/vtrenderer.hpp` (+1 -1) 📝 `src/renderer/wddmcon/WddmConRenderer.cpp` (+1 -1) 📝 `src/renderer/wddmcon/WddmConRenderer.hpp` (+1 -1) </details> ### 📄 Description ## Summary of the Pull Request This replaces the `GridLines` enum in the renderers with a `til::enumset` type, avoiding the need for the various `WI_IsFlagSet` macros and flag operators. ## References This is followup to PR #10492 which introduced the `enumset` class. ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. ## Validation Steps Performed I've manually confirmed that all the different gridlines are still rendering correctly in both the GDI and DX renderers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:28:59 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28507
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?