starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Crash opening/closing close... submenu multiple times #11355

New Issue
Closed
opened 2026-01-31 02:45:25 +00:00 by claunia · 10 comments
claunia commented 2026-01-31 02:45:25 +00:00
Owner
Copy Link

Originally created by @mpela81 on GitHub (Nov 12, 2020).

Environment

Windows 10.0.19041.572
Windows Terminal Preview Version: 1.5.3142.0

Steps to reproduce

The application exits when you:

  • right click a tab to open context menu
  • hover to open the Close... submenu
  • click away to close the menu
  • repeat until it crashes

crash1

Expected behavior

It does not crash

Actual behavior

It crashes

Other info

Feedback hub link: https://aka.ms/AAabnvq

See also https://github.com/microsoft/terminal/pull/7728#issuecomment-701365493 and https://github.com/microsoft/terminal/pull/7728#issuecomment-704909853. Unfortunately I don't know how to debug it myself...

Originally created by @mpela81 on GitHub (Nov 12, 2020). # Environment ```none Windows 10.0.19041.572 Windows Terminal Preview Version: 1.5.3142.0 ``` # Steps to reproduce The application exits when you: - right click a tab to open context menu - hover to open the Close... submenu - click away to close the menu - repeat until it crashes ![crash1](https://user-images.githubusercontent.com/1140981/98926692-ed231500-24d7-11eb-8ff4-dd220f445029.gif) # Expected behavior It does not crash # Actual behavior It crashes # Other info Feedback hub link: https://aka.ms/AAabnvq See also https://github.com/microsoft/terminal/pull/7728#issuecomment-701365493 and https://github.com/microsoft/terminal/pull/7728#issuecomment-704909853. Unfortunately I don't know how to debug it myself...
claunia commented 2026-01-31 02:45:26 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 12, 2020):

Oh hey, I'm glad there's an actual issue for this now. We've known about this for some time, just never filed an issue for it.

We're pretty confident that this is a XAML Islands bug, but it'll be good to have a thread tracking it on our side.

@zadjii-msft commented on GitHub (Nov 12, 2020): Oh hey, I'm glad there's an actual issue for this now. We've known about this for some time, just never filed an issue for it. We're pretty confident that this is a XAML Islands bug, but it'll be good to have a thread tracking it on our side.
claunia commented 2026-01-31 02:45:26 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 8, 2021):

I'm punting this to 2.0, because we don't have LoS on a fix from the Terminal side. It might need a system XAML fix, which would be especially annoying.

@zadjii-msft commented on GitHub (Jan 8, 2021): I'm punting this to 2.0, because we don't have LoS on a fix from the Terminal side. It might need a system XAML fix, which would be especially annoying.
claunia commented 2026-01-31 02:45:26 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 12, 2021):

Oh NO. This is also gonna have to block #1571. People really want to stick their profile in nested menus. As soon as this is available, people are going to use it, and inevitably hit this. Yikes.

@zadjii-msft commented on GitHub (Jan 12, 2021): Oh NO. This is also gonna have to block #1571. People really want to stick their profile in nested menus. As soon as this is available, people are going to use it, and inevitably hit this. Yikes.
claunia commented 2026-01-31 02:45:26 +00:00
Author
Owner
Copy Link

@sylveon commented on GitHub (Jan 19, 2021):

It would be awesome if you could push internally for a fix because this is blocking on my app too.

@sylveon commented on GitHub (Jan 19, 2021): It would be awesome if you could push internally for a fix because this is blocking on my app too.
claunia commented 2026-01-31 02:45:27 +00:00
Author
Owner
Copy Link

@NeilMacMullen commented on GitHub (Feb 1, 2021):

FWIW I think there is an easier repro case if you need one. Just open the context menu and move the mouse up and down...
termreproc

This is on 1.6.10272.0

@NeilMacMullen commented on GitHub (Feb 1, 2021): FWIW I think there is an easier repro case if you need one. Just open the context menu and move the mouse up and down... ![termreproc](https://user-images.githubusercontent.com/9131337/106490226-82b5bb80-64ad-11eb-8bb1-30974d35b85e.gif) This is on 1.6.10272.0
claunia commented 2026-01-31 02:45:27 +00:00
Author
Owner
Copy Link

@mpela81 commented on GitHub (Apr 10, 2021):

I suppose this is going to take some time to be fixed at the system XAML level. Considering the context menu is not so crowded at the moment, would it be bad placing the items right above the Close one, for the time being? At least people could use the feature.
immagine

@mpela81 commented on GitHub (Apr 10, 2021): I suppose this is going to take some time to be fixed at the system XAML level. Considering the context menu is not so crowded at the moment, would it be bad placing the items right above the Close one, for the time being? At least people could use the feature. ![immagine](https://user-images.githubusercontent.com/1140981/114271501-f0ccb080-9a11-11eb-9e2c-3426cda95f28.png)
claunia commented 2026-01-31 02:45:27 +00:00
Author
Owner
Copy Link

@sylveon commented on GitHub (Apr 10, 2021):

Seeing as the upstream issue is flagged needs-winui-3, I don't even expect it to get ever fixed in system Xaml islands (which is annoying me because I can't migrate to WinUI 3 right away it's missing features from system Xaml I rely on)

@sylveon commented on GitHub (Apr 10, 2021): Seeing as the upstream issue is flagged needs-winui-3, I don't even expect it to get ever fixed in system Xaml islands (which is annoying me because I can't migrate to WinUI 3 right away it's missing features from system Xaml I rely on)
claunia commented 2026-01-31 02:45:27 +00:00
Author
Owner
Copy Link

@mpela81 commented on GitHub (Apr 16, 2021):

Considering the context menu is not so crowded at the moment, would it be bad placing the items right above the Close one, for the time being? At least people could use the feature.

I'm sending a PR for this, feel free to throw it away if you don't like it 😄

@mpela81 commented on GitHub (Apr 16, 2021): > Considering the context menu is not so crowded at the moment, would it be bad placing the items right above the Close one, for the time being? At least people could use the feature. I'm sending a PR for this, feel free to throw it away if you don't like it 😄
claunia commented 2026-01-31 02:45:27 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #9859, which has now been successfully released as Windows Terminal v1.8.1444.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #9859, which has now been successfully released as `Windows Terminal v1.8.1444.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1444.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 02:45:28 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #9859, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #9859, which has now been successfully released as `Windows Terminal Preview v1.9.1445.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.9.1445.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Priority-1 Product-Terminal Resolution-Fix-Committed Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11355
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?