starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Check status of TextBuffer Unit Tests in CI #1163

New Issue
Closed
opened 2026-01-30 22:17:54 +00:00 by claunia · 3 comments
claunia commented 2026-01-30 22:17:54 +00:00
Owner
Copy Link

Originally created by @miniksa on GitHub (May 16, 2019).

Originally assigned to: @miniksa on GitHub.

If the TextBuffer unit tests aren't named .Unit.Tests. then I'm pretty sure the CI isn't running them.

Originally posted by @miniksa in https://github.com/microsoft/terminal/pull/843

Originally created by @miniksa on GitHub (May 16, 2019). Originally assigned to: @miniksa on GitHub. If the TextBuffer unit tests aren't named `.Unit.Tests.` then I'm pretty sure the CI isn't running them. _Originally posted by @miniksa in https://github.com/microsoft/terminal/pull/843_
claunia added the Resolution-Fix-AvailableIssue-BugProduct-MetaArea-Build labels 2026-01-30 22:17:54 +00:00
claunia commented 2026-01-30 22:17:55 +00:00
Author
Owner
Copy Link

@metathinker commented on GitHub (May 17, 2019):

Unfortunately, you are right. I looked at test results for my PR here:
https://dev.azure.com/ms/Terminal/_build/results?buildId=15717&view=ms.vss-test-web.build-test-results-tab

  • Searching for "defaultcolor" should find TextBuffer.UnitTests.dll!TextColorTests::TestDefaultColor , but in fact matches nothing.
  • Searching for "boxarea" should find Terminal.Core.Unit.Tests.dll!TerminalCoreUnitTests::SelectionTest::SelectBoxArea , and it does.
@metathinker commented on GitHub (May 17, 2019): Unfortunately, you are right. I looked at test results for my PR here: https://dev.azure.com/ms/Terminal/_build/results?buildId=15717&view=ms.vss-test-web.build-test-results-tab - Searching for "defaultcolor" should find TextBuffer.UnitTests.dll!TextColorTests::TestDefaultColor , but in fact matches nothing. - Searching for "boxarea" should find Terminal.Core.Unit.Tests.dll!TerminalCoreUnitTests::SelectionTest::SelectBoxArea , and it does.
claunia commented 2026-01-30 22:17:55 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 17, 2019):

So, question. Is it better to change this:

fd98145af2/build/pipelines/templates/build-console-steps.yml (L52-L54)

or to change this:

fd98145af2/src/buffer/out/ut_textbuffer/TextBuffer.Unittests.vcxproj (L25)

?

@DHowett-MSFT commented on GitHub (May 17, 2019): So, question. Is it better to change this: https://github.com/microsoft/terminal/blob/fd98145af268dffff0125d18d4ac48d2012aa205/build/pipelines/templates/build-console-steps.yml#L52-L54 or to change this: https://github.com/microsoft/terminal/blob/fd98145af268dffff0125d18d4ac48d2012aa205/src/buffer/out/ut_textbuffer/TextBuffer.Unittests.vcxproj#L25 ?
claunia commented 2026-01-30 22:17:55 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (May 21, 2019):

So, question. Is it better to change this:

fd98145af2/build/pipelines/templates/build-console-steps.yml (L52-L54)

or to change this:

fd98145af2/src/buffer/out/ut_textbuffer/TextBuffer.Unittests.vcxproj (L25)

?

The latter, @DHowett-MSFT, is what I want to do. I commented on your PR #913 earlier that we should make this consistent across all testing projects. And the latter works toward consistency.

@miniksa commented on GitHub (May 21, 2019): > So, question. Is it better to change this: > > https://github.com/microsoft/terminal/blob/fd98145af268dffff0125d18d4ac48d2012aa205/build/pipelines/templates/build-console-steps.yml#L52-L54 > > or to change this: > > https://github.com/microsoft/terminal/blob/fd98145af268dffff0125d18d4ac48d2012aa205/src/buffer/out/ut_textbuffer/TextBuffer.Unittests.vcxproj#L25 > > ? The latter, @DHowett-MSFT, is what I want to do. I commented on your PR #913 earlier that we should make this consistent across all testing projects. And the latter works toward consistency.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Issue-Bug Product-Meta Resolution-Fix-Available
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1163
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?