starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add keybinding for moving up/down an entire page at a time #913

New Issue
Closed
opened 2026-01-30 22:09:55 +00:00 by claunia · 9 comments
claunia commented 2026-01-30 22:09:55 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (May 9, 2019).

Ctrl+Shift+PgUp/Dn should move an entire page at a time

Ctrl+Shift+Up/Dn Arrow should move one (N) lines at a time

Originally created by @zadjii-msft on GitHub (May 9, 2019). Ctrl+Shift+PgUp/Dn should move an entire page at a time Ctrl+Shift+Up/Dn Arrow should move one (N) lines at a time
claunia commented 2026-01-30 22:09:57 +00:00
Author
Owner
Copy Link

@Kapperchino commented on GitHub (May 10, 2019):

@zadjii-msft Can I be assigned this issue?
Also how do I contact you guys for help when needed?

@Kapperchino commented on GitHub (May 10, 2019): @zadjii-msft Can I be assigned this issue? Also how do I contact you guys for help when needed?
claunia commented 2026-01-30 22:09:57 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (May 10, 2019):

@zadjii-msft, can you follow a similar outline to https://github.com/microsoft/Terminal/issues/576#issuecomment-491129438 to get @Kapperchino started when you see this presuming you're good with it?

@miniksa commented on GitHub (May 10, 2019): @zadjii-msft, can you follow a similar outline to https://github.com/microsoft/Terminal/issues/576#issuecomment-491129438 to get @Kapperchino started when you see this presuming you're good with it?
claunia commented 2026-01-30 22:09:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 10, 2019):

Absolutely!

  • I'd first take a look at how to add a new keybinding event. Take a look at #623, where someone's adding a keybinding for alt+num to go to a particular tab as reference.
  • I'd also take a look at the existing keybinding for Ctrl+Shift+pgup/dn as a reference how to scroll one line at a time. See src/cascadia/terminalapp/app.cpp for the implementation of _DoScroll.
  • I'd add another method like DoScroll, but instead of scrolling by a specified amount, only specify a direction, and have the method query the active terminal control for how tall it is, and scroll by that amount.
  • as an additional note, this involves changing the current keybindings for scroll up/down to Ctrl+Shift+Up/Dn Arrow. Those are setup in CascadiaSettings.cpp I believe.

As @miniksa mentioned, you're going to be among the first people we assign to do a feature that aren't on our direct team. It might be rough and neither we nor you know exactly what to expect. Bear with us. We're learning how to be open as much as you're learning how to work in our code.

If you need any help, please feel free to ping me on this thread. I'm happy to help.

@zadjii-msft commented on GitHub (May 10, 2019): Absolutely! * I'd first take a look at how to add a new keybinding event. Take a look at #623, where someone's adding a keybinding for alt+num to go to a particular tab as reference. * I'd also take a look at the existing keybinding for Ctrl+Shift+pgup/dn as a reference how to scroll one line at a time. See `src/cascadia/terminalapp/app.cpp` for the implementation of `_DoScroll`. * I'd add another method like `DoScroll`, but instead of scrolling by a specified amount, only specify a direction, and have the method query the active terminal control for how tall it is, and scroll by that amount. * as an additional note, this involves changing the current keybindings for scroll up/down to Ctrl+Shift+Up/Dn Arrow. Those are setup in `CascadiaSettings.cpp` I believe. As @miniksa mentioned, you're going to be among the first people we assign to do a feature that aren't on our direct team. It might be rough and neither we nor you know exactly what to expect. Bear with us. We're learning how to be open as much as you're learning how to work in our code. If you need any help, please feel free to ping me on this thread. I'm happy to help.
claunia commented 2026-01-30 22:09:57 +00:00
Author
Owner
Copy Link

@Kapperchino commented on GitHub (May 11, 2019):

@zadjii-msft For the height of the terminal, do I get the view height and then calculate how many lines that would be? Or is there a way to get how many lines of text the terminal has?

@Kapperchino commented on GitHub (May 11, 2019): @zadjii-msft For the height of the terminal, do I get the view height and then calculate how many lines that would be? Or is there a way to get how many lines of text the terminal has?
claunia commented 2026-01-30 22:09:58 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 12, 2019):

I think that Terminal::GetViewport().Height() would bet you the height of the terminal in rows. You might need to plumb that up through the TermControl somehow.

@zadjii-msft commented on GitHub (May 12, 2019): I think that `Terminal::GetViewport().Height()` would bet you the height of the terminal in rows. You might need to plumb that up through the `TermControl` somehow.
claunia commented 2026-01-30 22:09:58 +00:00
Author
Owner
Copy Link

@Kapperchino commented on GitHub (May 13, 2019):

@zadjii-msft how do I make a test for this? I did some manual testing.

@Kapperchino commented on GitHub (May 13, 2019): @zadjii-msft how do I make a test for this? I did some manual testing.
claunia commented 2026-01-30 22:09:58 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 13, 2019):

You know, I don't think we actually have any test for this particular area of the code. So I think you're probably fine making a PR without the tests for now. That's on me to add the testing infrastructure :P

@zadjii-msft commented on GitHub (May 13, 2019): You know, I don't think we actually have any test for this particular area of the code. So I think you're probably fine making a PR without the tests for now. That's on me to add the testing infrastructure :P
claunia commented 2026-01-30 22:09:58 +00:00
Author
Owner
Copy Link

@Kapperchino commented on GitHub (May 13, 2019):

alright, I'll be doing the pr then, thanks for your help!

@Kapperchino commented on GitHub (May 13, 2019): alright, I'll be doing the pr then, thanks for your help!
claunia commented 2026-01-30 22:09:59 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (May 21, 2019):

Looks like the related PR was completed. Resolving.

@miniksa commented on GitHub (May 21, 2019): Looks like the related PR was completed. Resolving.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted Issue-Feature Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#913
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?