[PR #913] Switch to v5 UUIDs as profile GUIDs for the default profiles #24400

Closed
opened 2026-01-31 09:03:04 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/913

State: closed
Merged: Yes


Summary of the Pull Request

This pull request switches the GUIDs for default profiles from being randomly generated to being version 5 UUIDs. More info in #870.

PR Checklist

Detailed Description of the Pull Request / Additional comments

This pull request has a number of changes that seem ancillary, but they're general goodness. Let me explain:

  • I've added a whole new Types test library with only two tests in
  • Since UUIDv5 generation requires SHA1, we needed to take a dependency on bcrypt
  • I honestly don't think we should have to link bcrypt in conhost, but LTO should take care of that
    • I considered adding a new Terminal-specific Utils/Types library, but that seemed like a waste
  • The best way to link bcrypt turned out to be in line with a discussion @miniksa and I had, where we decided we both love APISets and think that the console should link against them exclusively... so I've added onecore_apiset.lib to the front of the link line, where it will deflect the linker away from most of the other libs automagically.
StartGroup: UuidTests::TestV5UuidU8String
Verify: AreEqual(uuidExpected, uuidActual)
EndGroup: UuidTests::TestV5UuidU8String [Passed]

StartGroup: UuidTests::TestV5UuidU16String
Verify: AreEqual(uuidExpected, uuidActual)
EndGroup: UuidTests::TestV5UuidU16String [Passed]
**Original Pull Request:** https://github.com/microsoft/terminal/pull/913 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request This pull request switches the GUIDs for default profiles from being randomly generated to being version 5 UUIDs. More info in #870. ## PR Checklist * [x] Closes #870 * [x] CLA signed * [x] Tests added/passed * [x] Requires documentation to be updated (#883) * [x] I've discussed this with core contributors already. ## Detailed Description of the Pull Request / Additional comments This pull request has a number of changes that seem ancillary, but they're general goodness. Let me explain: * I've added a whole new Types test library with only two tests in * Since UUIDv5 generation requires SHA1, we needed to take a dependency on bcrypt * I honestly don't think we should have to link bcrypt in conhost, but LTO should take care of that * I considered adding a new Terminal-specific Utils/Types library, but that seemed like a waste * The best way to link bcrypt turned out to be in line with a discussion @miniksa and I had, where we decided we both love APISets and think that the console should link against them exclusively... so I've added `onecore_apiset.lib` to the front of the link line, where it will deflect the linker away from most of the other libs automagically. ``` StartGroup: UuidTests::TestV5UuidU8String Verify: AreEqual(uuidExpected, uuidActual) EndGroup: UuidTests::TestV5UuidU8String [Passed] StartGroup: UuidTests::TestV5UuidU16String Verify: AreEqual(uuidExpected, uuidActual) EndGroup: UuidTests::TestV5UuidU16String [Passed] ```
claunia added the pull-request label 2026-01-31 09:03:04 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24400