starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Screen Reader - Windows Powershell]: A button must support one of these patterns: Invoke, Toggle or ExpandCollapse. #11685

New Issue
Closed
opened 2026-01-31 02:54:43 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 02:54:43 +00:00
Owner
Copy Link

Originally created by @Chandresh1007 on GitHub (Dec 3, 2020).

Originally assigned to: @carlos-zamora on GitHub.

User Experience:
When standard controls from accessible technologies are not used and if the user interface elements are not used according to specification, Assistive Technologies (AT) will not be able to gather information about, activate(or set) and keep up to date on the status of user interface controls in the content.

Test Environment:
OS: Win 10 2004 Build (20262.1010)
App: Windows Terminal
App version: 1.4.3243.0
Tool: Accessibility Insights for Windows

Repro Steps:

  1. Open Windows terminal app.
  2. Press "Ctrl+Shift+T" to open multiple tabs.
  3. Now run accessibility insight tool on the application.
  4. Observe the issue.

Actual Result:
A button must support one of these patterns: Invoke, Toggle or ExpandCollapse.

Expected Result:
Modify the button to support exactly one of the following patterns:
· Support the Invoke pattern if the button performs a command at the request of the user.
· Support the Toggle pattern if the button can cycle through a series of up to three states.
· Support the ExpandCollapse pattern if the button shows or hides additional content.

MAS Reference:
MAS4.1.2
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc=%7B248054a6-5e68-4771-9e1e-242fb5025730%7D&cid=e71aec14-4173-423e-aecb-2472bbc751e8

MAS4 1 2_button must support pattern_How to fix

MAS4 1 2_button must support pattern_Details

Originally created by @Chandresh1007 on GitHub (Dec 3, 2020). Originally assigned to: @carlos-zamora on GitHub. **User Experience:** When standard controls from accessible technologies are not used and if the user interface elements are not used according to specification, Assistive Technologies (AT) will not be able to gather information about, activate(or set) and keep up to date on the status of user interface controls in the content. **Test Environment:** OS: Win 10 2004 Build (20262.1010) App: Windows Terminal App version: 1.4.3243.0 Tool: Accessibility Insights for Windows **Repro Steps:** 1. Open Windows terminal app. 2. Press "Ctrl+Shift+T" to open multiple tabs. 3. Now run accessibility insight tool on the application. 4. Observe the issue. **Actual Result:** A button must support one of these patterns: Invoke, Toggle or ExpandCollapse. **Expected Result:** Modify the button to support exactly one of the following patterns: · Support the Invoke pattern if the button performs a command at the request of the user. · Support the Toggle pattern if the button can cycle through a series of up to three states. · Support the ExpandCollapse pattern if the button shows or hides additional content. **MAS Reference:** **MAS4.1.2** https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc=%7B248054a6-5e68-4771-9e1e-242fb5025730%7D&cid=e71aec14-4173-423e-aecb-2472bbc751e8 ![MAS4 1 2_button must support pattern_How to fix](https://user-images.githubusercontent.com/53220700/101023812-4b07c180-3599-11eb-89fa-ee433929599c.png) ![MAS4 1 2_button must support pattern_Details](https://user-images.githubusercontent.com/53220700/101023821-4cd18500-3599-11eb-9b14-76d7118fd980.png)
claunia commented 2026-01-31 02:54:45 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 3, 2020):

What the heck? I don't think there should be a button there...

I guess I don't even know where this button is. I'm pretty sure there isn't one in the XAML tree

@zadjii-msft commented on GitHub (Dec 3, 2020): What the heck? I don't think there should be a button there... I guess I don't even know where this button is. I'm pretty sure there isn't one in the XAML tree
claunia commented 2026-01-31 02:54:46 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Dec 3, 2020):

The only buttons I'm seeing there are the Min/Max/Close buttons:
Inspect.exe UIA Tree

Even using Accessibility Insights to traverse the tree, I'm seeing those same 3 buttons:
Accessibility Insights UIA Tree

I just ran the automated tests from Accessibility Insights and I'm getting a different test failure:
Accessibility Insights Test Failure

These might be different manifestations of the same issue? Not sure... Either way, settings IsControlElement to true shouldn't be too difficult, I think.

@carlos-zamora commented on GitHub (Dec 3, 2020): The only buttons I'm seeing there are the Min/Max/Close buttons: ![Inspect.exe UIA Tree](https://user-images.githubusercontent.com/11050425/101069757-45858980-354f-11eb-9bf5-35e6773635cf.png) Even using Accessibility Insights to traverse the tree, I'm seeing those same 3 buttons: ![Accessibility Insights UIA Tree](https://user-images.githubusercontent.com/11050425/101069957-8e3d4280-354f-11eb-8cd8-68ba26ecd3d1.png) I just ran the automated tests from Accessibility Insights and I'm getting a different test failure: ![Accessibility Insights Test Failure](https://user-images.githubusercontent.com/11050425/101070229-ed02bc00-354f-11eb-85c8-11e8c0fa959f.png) These might be different manifestations of the same issue? Not sure... Either way, settings `IsControlElement` to `true` shouldn't be too difficult, I think.
claunia commented 2026-01-31 02:54:46 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 23, 2021):

@Chandresh1007 We cannot locate the button that you have reported here in Windows Terminal 1.5, 1.6, 1.7.

@DHowett commented on GitHub (Feb 23, 2021): @Chandresh1007 We cannot locate the button that you have reported here in Windows Terminal 1.5, 1.6, 1.7.
claunia commented 2026-01-31 02:54:46 +00:00
Author
Owner
Copy Link

@Chandresh1007 commented on GitHub (Feb 24, 2021):

Issue is fixed. Verified on following Test Environment:
OS: Win 10 2004 Build (21301.1010)
App: Windows Terminal
App version: 1.5.10411.0
Tool: Accessibility Insights for Windows
Hence, closing the bug.

@Chandresh1007 commented on GitHub (Feb 24, 2021): Issue is fixed. Verified on following Test Environment: OS: Win 10 2004 Build (21301.1010) App: Windows Terminal App version: 1.5.10411.0 Tool: Accessibility Insights for Windows Hence, closing the bug.
claunia commented 2026-01-31 02:54:46 +00:00
Author
Owner
Copy Link

@Priyanka-Chauhan123 commented on GitHub (Jan 9, 2024):

Closing the bug as issue has been fixed.

@Priyanka-Chauhan123 commented on GitHub (Jan 9, 2024): Closing the bug as issue has been fixed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11yCO A11ySev3 A11yTTValidated A11yWCAG Area-Accessibility HCL-E+D HCL-WindowsTerminal Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11685
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?