[PR #11685] [MERGED] Remove unused rendering settings from profile #28706

Open
opened 2026-01-31 09:30:16 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11685
Author: @PankajBhojwani
Created: 11/4/2021
Status: Merged
Merged: 11/4/2021
Merged by: @DHowett

Base: mainHead: dev/pabhoj/profile_rendering_settings


📝 Commits (1)

  • 0a3e6e4 remove rendering settings from profile

📊 Changes

6 files changed (+0 additions, -14 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/Profiles.h (+0 -2)
📝 src/cascadia/TerminalSettingsEditor/Profiles.idl (+0 -2)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (+0 -2)
📝 src/cascadia/TerminalSettingsModel/Profile.cpp (+0 -2)
📝 src/cascadia/TerminalSettingsModel/Profile.h (+0 -4)
📝 src/cascadia/TerminalSettingsModel/Profile.idl (+0 -2)

📄 Description

The ForceFullRepaintRendering and SoftwareRendering are global only and for some reason were in profile. This commit removes them.

Reference: https://github.com/microsoft/terminal/pull/11416#discussion_r742030103


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11685 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 11/4/2021 **Status:** ✅ Merged **Merged:** 11/4/2021 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/pabhoj/profile_rendering_settings` --- ### 📝 Commits (1) - [`0a3e6e4`](https://github.com/microsoft/terminal/commit/0a3e6e42c628eb2be37942f68eb68535fc46167c) remove rendering settings from profile ### 📊 Changes **6 files changed** (+0 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/Profiles.h` (+0 -2) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.idl` (+0 -2) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp` (+0 -2) 📝 `src/cascadia/TerminalSettingsModel/Profile.cpp` (+0 -2) 📝 `src/cascadia/TerminalSettingsModel/Profile.h` (+0 -4) 📝 `src/cascadia/TerminalSettingsModel/Profile.idl` (+0 -2) </details> ### 📄 Description The `ForceFullRepaintRendering` and `SoftwareRendering` are global only and for some reason were in profile. This commit removes them. Reference: https://github.com/microsoft/terminal/pull/11416#discussion_r742030103 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:30:16 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28706