starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

FontSize setting control should only accept a number between 0 and 128 #12038

New Issue
Closed
opened 2026-01-31 03:04:38 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 03:04:38 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Jan 12, 2021).

Originally assigned to: @zadjii-msft on GitHub.

Steps to reproduce

  1. Go to "Appearance"
  2. Get into the font size box.
  3. Press Ctrl+Tab and it starts inserting literal tabs. Keep doing it and it becomes a super long boi to the right instead of wrapping like the same behavior in the Font Face text block.

Expected behavior

non-numeric content should not be allowed. We should only accept a number between 0 and 128.

Actual behavior

Expands to the right and tabs are inserted.

Additional Details

This is probably a simple fix. Just a matter of adding the wrap styling to CommonResources.xaml. Take a look at what wrap styling was already added to other controls. In fact, if any of the other control styles support wrap styling, feel free to add them there too.
We need to look into what kind of restrictions we can put on this control. Hopefully it supports limiting content to numbers and limiting the range to 0 and 128. Some of this may have to be filed upstream.

Originally created by @carlos-zamora on GitHub (Jan 12, 2021). Originally assigned to: @zadjii-msft on GitHub. # Steps to reproduce 1. Go to "Appearance" 2. Get into the font size box. 3. Press Ctrl+Tab and it starts inserting literal tabs. Keep doing it and it becomes a super long boi to the right instead of wrapping like the same behavior in the Font Face text block. # Expected behavior non-numeric content should not be allowed. We should only accept a number between 0 and 128. # Actual behavior Expands to the right and tabs are inserted. # Additional Details ~This is probably a simple fix. Just a matter of adding the wrap styling to CommonResources.xaml. Take a look at what wrap styling was already added to other controls. In fact, if any of the other control styles support wrap styling, feel free to add them there too.~ We need to look into what kind of restrictions we can put on this control. Hopefully it supports limiting content to numbers and limiting the range to 0 and 128. Some of this may have to be filed upstream.
claunia commented 2026-01-31 03:04:40 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 12, 2021):

Sorry, is the bug that it doesn't wrap or that you can enter non-numeric content in it such that it needs to wrap? It only ever contains a single number between 0 and 128. There's no need for it to wrap.

@DHowett commented on GitHub (Jan 12, 2021): Sorry, is the bug that it doesn't wrap or that you can enter non-numeric content in it such that it needs to wrap? It only ever contains a single number between 0 and 128. There's no need for it to wrap.
claunia commented 2026-01-31 03:04:40 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jan 12, 2021):

Sorry, is the bug that it doesn't wrap or that you can enter non-numeric content in it such that it needs to wrap? It only ever contains a single number between 0 and 128. There's no need for it to wrap.

Good point. If we only ever accept a value between 0 and 128. We should make the control enforce that (if possible). Updating issue appropriately.

@carlos-zamora commented on GitHub (Jan 12, 2021): > Sorry, is the bug that it doesn't wrap or that you can enter non-numeric content in it such that it needs to wrap? It only ever contains a single number between 0 and 128. There's no need for it to wrap. Good point. If we only ever accept a value between 0 and 128. We should make the control enforce that (if possible). Updating issue appropriately.
claunia commented 2026-01-31 03:04:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 12, 2021):

Alright so 90% of this issue is tracked upstream at microsoft/microsoft-ui-xaml#3466.

The Min/Max thing, that we can do.

@zadjii-msft commented on GitHub (Jan 12, 2021): Alright so 90% of this issue is tracked upstream at microsoft/microsoft-ui-xaml#3466. The Min/Max thing, that we _can_ do.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Issue-Bug Priority-2 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12038
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?