[PR #13575] [a11y] Announce new tab/pane upon creation #29639

Open
opened 2026-01-31 09:36:04 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13575
Author: @carlos-zamora
Created: 7/22/2022
Status: 🔄 Open

Base: mainHead: dev/cazamor/a11y-sev3/new-profile-announcement


📝 Commits (5)

  • 2cb1ff7 [a11y] Announce new tab/pane upon creation
  • 0473430 fix announcement for duplicate tab/pane
  • fd19751 don't notify on commandline args; don't cache autoPeer
  • 6112345 don't use GetProfileForArgs!
  • c189754 Migrate spelling-0.0.21 changes from main

📊 Changes

18 files changed (+948 additions, -676 deletions)

View changed files

📝 .github/actions/spelling/README.md (+1 -0)
📝 .github/actions/spelling/advice.md (+1 -1)
📝 .github/actions/spelling/allow/allow.txt (+10 -2)
📝 .github/actions/spelling/allow/apis.txt (+13 -4)
.github/actions/spelling/candidate.patterns (+523 -0)
📝 .github/actions/spelling/excludes.txt (+27 -11)
📝 .github/actions/spelling/expect/alphabet.txt (+0 -7)
📝 .github/actions/spelling/expect/expect.txt (+106 -611)
📝 .github/actions/spelling/expect/web.txt (+0 -2)
📝 .github/actions/spelling/line_forbidden.patterns (+28 -2)
📝 .github/actions/spelling/patterns/patterns.txt (+56 -1)
📝 .github/actions/spelling/reject.txt (+4 -23)
📝 .github/workflows/spelling2.yml (+96 -8)
📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+17 -2)
📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+9 -1)
📝 src/cascadia/TerminalApp/TabManagement.cpp (+26 -1)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+29 -0)
📝 src/cascadia/TerminalApp/TerminalPage.h (+2 -0)

📄 Description

Summary of the Pull Request

Makes the automation peer for the TerminalPage announce that a new tab/pane was created successfully. In order to do this, we need to store the automation peer for TerminalPage. Then we have easy access to dispatch notifications from it.

Closes #12038

Validation Steps Performed

Open a new tab/pane with Narrator active.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13575 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 7/22/2022 **Status:** 🔄 Open **Base:** `main` ← **Head:** `dev/cazamor/a11y-sev3/new-profile-announcement` --- ### 📝 Commits (5) - [`2cb1ff7`](https://github.com/microsoft/terminal/commit/2cb1ff753fef7276cd36330438ea8cc8fc732342) [a11y] Announce new tab/pane upon creation - [`0473430`](https://github.com/microsoft/terminal/commit/0473430282c01be361f4d0711612ca5d6b5d394d) fix announcement for duplicate tab/pane - [`fd19751`](https://github.com/microsoft/terminal/commit/fd19751aef2c736edaa4103363292f2bc12f23b7) don't notify on commandline args; don't cache autoPeer - [`6112345`](https://github.com/microsoft/terminal/commit/6112345f621145f18f4a5cff2a903fc8d467b673) don't use GetProfileForArgs! - [`c189754`](https://github.com/microsoft/terminal/commit/c1897546770ba3e482b67c69f1059e60ff296a79) Migrate spelling-0.0.21 changes from main ### 📊 Changes **18 files changed** (+948 additions, -676 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/README.md` (+1 -0) 📝 `.github/actions/spelling/advice.md` (+1 -1) 📝 `.github/actions/spelling/allow/allow.txt` (+10 -2) 📝 `.github/actions/spelling/allow/apis.txt` (+13 -4) ➕ `.github/actions/spelling/candidate.patterns` (+523 -0) 📝 `.github/actions/spelling/excludes.txt` (+27 -11) 📝 `.github/actions/spelling/expect/alphabet.txt` (+0 -7) 📝 `.github/actions/spelling/expect/expect.txt` (+106 -611) 📝 `.github/actions/spelling/expect/web.txt` (+0 -2) 📝 `.github/actions/spelling/line_forbidden.patterns` (+28 -2) 📝 `.github/actions/spelling/patterns/patterns.txt` (+56 -1) 📝 `.github/actions/spelling/reject.txt` (+4 -23) 📝 `.github/workflows/spelling2.yml` (+96 -8) 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+17 -2) 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+9 -1) 📝 `src/cascadia/TerminalApp/TabManagement.cpp` (+26 -1) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+29 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+2 -0) </details> ### 📄 Description ## Summary of the Pull Request Makes the automation peer for the `TerminalPage` announce that a new tab/pane was created successfully. In order to do this, we need to store the automation peer for `TerminalPage`. Then we have easy access to dispatch notifications from it. Closes #12038 ## Validation Steps Performed Open a new tab/pane with Narrator active. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:04 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29639