starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Code Cleanup - termDispatch.hpp & adaptDispatch.hpp overrides #1216

New Issue
Closed
opened 2026-01-30 22:19:23 +00:00 by claunia · 4 comments
claunia commented 2026-01-30 22:19:23 +00:00
Owner
Copy Link

Originally created by @dlong11 on GitHub (May 19, 2019).

Originally assigned to: @subhasan on GitHub.

Minor code cleanup

The ITermDispatch overridden methods in terminal/src/terminal/adapter/termDispatch.hpp & terminal/src/terminal/adapter/adaptDispatch.hpp do not follow
C.128: Virtual functions should specify exactly one of virtual, override, or final guideline.

Originally created by @dlong11 on GitHub (May 19, 2019). Originally assigned to: @subhasan on GitHub. Minor code cleanup The ITermDispatch overridden methods in terminal/src/terminal/adapter/termDispatch.hpp & terminal/src/terminal/adapter/adaptDispatch.hpp do not follow [C.128: Virtual functions should specify exactly one of virtual, override, or final guideline. ](http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c128-virtual-functions-should-specify-exactly-one-of-virtual-override-or-final)
claunia commented 2026-01-30 22:19:24 +00:00
Author
Owner
Copy Link

@dlong11 commented on GitHub (May 19, 2019):

I just noticed that InteractDispatch.hpp has the same issue. (in this case, it is the IInterractDispatch overrides). I can modify this issue or create a new issue. Let me know what you think is best.

Side note - I noticed these when doing a code review. I am assuming the Core guideline analyzer isn't being run as part of the CI process. Is the plan to do this?

@dlong11 commented on GitHub (May 19, 2019): I just noticed that InteractDispatch.hpp has the same issue. (in this case, it is the IInterractDispatch overrides). I can modify this issue or create a new issue. Let me know what you think is best. Side note - I noticed these when doing a code review. I am assuming the Core guideline analyzer isn't being run as part of the CI process. Is the plan to do this?
claunia commented 2026-01-30 22:19:24 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 20, 2019):

You're right, they probably shouldn't be virtual.

I believe we never turned the analyzer on because so much of the code was written before we started conforming to that standard, that we'd have spent entire releases just cleaning it up. @adiviness can comment more.

@zadjii-msft commented on GitHub (May 20, 2019): You're right, they probably shouldn't be `virtual`. I believe we never turned the analyzer on because so much of the code was written before we started conforming to that standard, that we'd have spent entire releases just cleaning it up. @adiviness can comment more.
claunia commented 2026-01-30 22:19:25 +00:00
Author
Owner
Copy Link

@adiviness commented on GitHub (May 21, 2019):

Currently we don't have a static analyzer looking at the cpp core check stuff. In /src there is a ruleset file that I think is empty and it was only set up on the /buffer/out directory when the AuditCode configuration was specified.

@adiviness commented on GitHub (May 21, 2019): Currently we don't have a static analyzer looking at the cpp core check stuff. In `/src` there is a ruleset file that I think is empty and it was only set up on the `/buffer/out` directory when the `AuditCode` configuration was specified.
claunia commented 2026-01-30 22:19:25 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 25, 2019):

This was fixed in #1004.

@DHowett-MSFT commented on GitHub (May 25, 2019): This was fixed in #1004.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Help Wanted Issue-Bug Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1216
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?