starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

coding standards issue, _Upper should be banned #1004

New Issue
Open
opened 2026-01-30 22:13:47 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 22:13:47 +00:00
Owner
Copy Link

Originally created by @ChrisGuzak on GitHub (May 12, 2019).

the language standard reserves _Upper and __doubleUnderscore symbols for itself. windows coding standards recognize this as well, all _ prefixes on methods and other things with an upper case second letter should be renamed.

Originally created by @ChrisGuzak on GitHub (May 12, 2019). the language standard reserves _Upper and __doubleUnderscore symbols for itself. windows coding standards recognize this as well, all _ prefixes on methods and other things with an upper case second letter should be renamed.
claunia added the Help WantedProduct-ConhostIssue-BugProduct-TerminalArea-Build labels 2026-01-30 22:13:48 +00:00
claunia commented 2026-01-30 22:13:49 +00:00
Author
Owner
Copy Link

@adiviness commented on GitHub (May 12, 2019):

I've been saying this for years :D

@adiviness commented on GitHub (May 12, 2019): I've been saying this for years :D
claunia commented 2026-01-30 22:13:49 +00:00
Author
Owner
Copy Link

@jsoref commented on GitHub (Jun 23, 2025):

Fwiw, check-spelling's forbidden patterns can enforce rules like this.

The way I'd do it (and this is a note for myself, since I'm likely to do it at some point) is to add:

  1. patterns for specific standard things which are used
  2. replace all things that violate the rule
  3. add a forbidden pattern to enforce the rule with a comment above that suggests a correct token and explains how to add a C/C++ standard instance item to the acceptable list (in the unlikely event that such things need to be referenced)
@jsoref commented on GitHub (Jun 23, 2025): Fwiw, check-spelling's [forbidden patterns](https://github.com/microsoft/terminal/blob/main/.github/actions/spelling/line_forbidden.patterns) can enforce rules like this. The way I'd do it (and this is a note for myself, since I'm likely to do it at some point) is to add: 1. [patterns](https://github.com/microsoft/terminal/blob/main/.github/actions/spelling/patterns/patterns.txt) for specific standard things which are used 2. replace all things that violate the rule 3. add a forbidden pattern to enforce the rule with a comment above that suggests a correct token and explains how to add a C/C++ standard instance item to the acceptable list (in the unlikely event that such things need to be referenced)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Help Wanted Issue-Bug Product-Conhost Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1004
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?