starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Browse buttons crash when running as admin #12299

New Issue
Closed
opened 2026-01-31 03:11:39 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 03:11:39 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Jan 29, 2021).

Originally assigned to: @DHowett on GitHub.

The optional graphical settings editor worked properly when I ran Windows Terminal as a regular user. However, if I ran Windows Terminal as Administrator, the app would crash if I clicked the "Browse..." button for either "Command line" or "Starting directory".

Originally posted by @huang63 in https://github.com/microsoft/terminal/issues/6800#issuecomment-769568274

Originally created by @carlos-zamora on GitHub (Jan 29, 2021). Originally assigned to: @DHowett on GitHub. The optional graphical settings editor worked properly when I ran Windows Terminal as a regular user. However, if I ran Windows Terminal as Administrator, the app would crash if I clicked the "Browse..." button for either "Command line" or "Starting directory". _Originally posted by @huang63 in https://github.com/microsoft/terminal/issues/6800#issuecomment-769568274_
claunia commented 2026-01-31 03:11:41 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jan 29, 2021):

Did a bit of digging on this one. Here's my findings:

Relevant PR: #8391

The culprit is this call right here:
e7d32625be/src/cascadia/TerminalSettingsEditor/Profiles.cpp (L348)

I'm not exactly sure what is going on though. Looks like PickSingleFolderAsync() failed, and GetResults() returns a bad HRESULT.

Assigning @DHowett for now to provide some ideas/insight on next steps.

@carlos-zamora commented on GitHub (Jan 29, 2021): Did a bit of digging on this one. Here's my findings: Relevant PR: #8391 The culprit is this call right here: https://github.com/microsoft/terminal/blob/e7d32625befb85e5b40380de20c62172e7275c5e/src/cascadia/TerminalSettingsEditor/Profiles.cpp#L348 I'm not exactly sure what is going on though. Looks like `PickSingleFolderAsync()` failed, and `GetResults()` returns a bad HRESULT. Assigning @DHowett for now to provide some ideas/insight on next steps.
claunia commented 2026-01-31 03:11:41 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 29, 2021):

You’re gonna need to give me that HRESULT!

I’m guessing this is the same class of problem as “i can’t drag tabs in admin mode”. Same team, same APIs...

@DHowett commented on GitHub (Jan 29, 2021): You’re gonna need to give me that HRESULT! I’m guessing this is the same class of problem as “i can’t drag tabs in admin mode”. Same team, same APIs...
claunia commented 2026-01-31 03:11:41 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Jan 29, 2021):

I'm now betting https://github.com/microsoft/terminal/issues/8950 is extremely related. It didn't matter if it was elevated or not so I think invalid paths are still an issue that likely correlate to this bug. Perhaps they have the same fix (one can hope).

@WSLUser commented on GitHub (Jan 29, 2021): I'm now betting https://github.com/microsoft/terminal/issues/8950 is extremely related. It didn't matter if it was elevated or not so I think invalid paths are still an issue that likely correlate to this bug. Perhaps they have the same fix (one can hope).
claunia commented 2026-01-31 03:11:41 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jan 29, 2021):

You’re gonna need to give me that HRESULT!

I’m guessing this is the same class of problem as “i can’t drag tabs in admin mode”. Same team, same APIs...

-2147467259 --> 0x80004005 : 'Unspecified error'. --> E_FAIL is returned from the GetResults() call.

@carlos-zamora commented on GitHub (Jan 29, 2021): > You’re gonna need to give me that HRESULT! > > I’m guessing this is the same class of problem as “i can’t drag tabs in admin mode”. Same team, same APIs... `-2147467259` --> `0x80004005 : 'Unspecified error'.` --> `E_FAIL` is returned from the `GetResults()` call.
claunia commented 2026-01-31 03:11:42 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Feb 11, 2021):

@DHowett friendly bump on this thread to get it on your radar

@carlos-zamora commented on GitHub (Feb 11, 2021): @DHowett friendly bump on this thread to get it on your radar
claunia commented 2026-01-31 03:11:42 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 2, 2021):

In #9341, @rileysea was also seeing this unelevated 😬

@zadjii-msft commented on GitHub (Mar 2, 2021): In #9341, @rileysea was also seeing this _unelevated_ 😬
claunia commented 2026-01-31 03:11:42 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 14, 2021):

:tada:This issue was addressed in #9760, which has now been successfully released as Windows Terminal v1.7.1033.0.🎉

Handy links:

@ghost commented on GitHub (Apr 14, 2021): :tada:This issue was addressed in #9760, which has now been successfully released as `Windows Terminal v1.7.1033.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.7.1033.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 03:11:42 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 14, 2021):

:tada:This issue was addressed in #9760, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.🎉

Handy links:

@ghost commented on GitHub (Apr 14, 2021): :tada:This issue was addressed in #9760, which has now been successfully released as `Windows Terminal Preview v1.8.1032.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1032.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Issue-Bug Priority-1 Product-Terminal Resolution-Fix-Committed Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12299
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?