[PR #12299] [MERGED] Add a11y names to more controls #28965

Open
opened 2026-01-31 09:31:54 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12299
Author: @zadjii-msft
Created: 1/31/2022
Status: Merged
Merged: 1/31/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/11996-a11y-names-pt-2


📝 Commits (3)

  • 11b458c I think this is all of them. Gotta merge main
  • 8145e03 Merge remote-tracking branch 'origin/main' into dev/migrie/b/11996-a11y-names-pt-2
  • f7ba158 add names even though this doesn't work

📊 Changes

3 files changed (+95 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+5 -1)
📝 src/cascadia/TerminalSettingsEditor/Profiles_Appearance.xaml (+2 -0)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+88 -0)

📄 Description

Summary of the Pull Request

This adds names to more of our focusable elements. This should be the rest of them that I missed in #11364

References

  • #9990: a11y megathread
  • #11155: original version of this

PR Checklist

  • Should take care of #11996 once confirmed
  • I work here

Validation Steps Performed

Used Accessibility Insights to verify.

Detailed Description of the Pull Request / Additional comments

There is one other weird bit. All the expanders that have content below the expander (not inline), show up as focusable, but don't have names. Even when I add names to them. I believe this is due to https://github.com/microsoft/microsoft-ui-xaml/issues/5820, which is fixed in https://github.com/microsoft/microsoft-ui-xaml/pull/6032, in https://github.com/microsoft/microsoft-ui-xaml/releases/tag/v2.8.0-prerelease.220118001. Unfortunately, we're on a 2.7 prerelease, so we don't have that fix yet. I may see how painful moving to that is, because we're gonna get another a11y ping as soon as 1.13 ships.

I pre-emptively added names to these guys in f7ba158dc, so that the new MUX should just fix this without any thinking on our part.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12299 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/31/2022 **Status:** ✅ Merged **Merged:** 1/31/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/11996-a11y-names-pt-2` --- ### 📝 Commits (3) - [`11b458c`](https://github.com/microsoft/terminal/commit/11b458cea91a0872a4b8af9aeba3afb26c083bc7) I think this is all of them. Gotta merge main - [`8145e03`](https://github.com/microsoft/terminal/commit/8145e0335e2a78e71d4ebe87d865e3c1dc8fcdf5) Merge remote-tracking branch 'origin/main' into dev/migrie/b/11996-a11y-names-pt-2 - [`f7ba158`](https://github.com/microsoft/terminal/commit/f7ba158dc0bdc404d8fd192d49df3a24bd162f0a) add names even though this doesn't work ### 📊 Changes **3 files changed** (+95 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+5 -1) 📝 `src/cascadia/TerminalSettingsEditor/Profiles_Appearance.xaml` (+2 -0) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+88 -0) </details> ### 📄 Description ## Summary of the Pull Request This adds names to more of our focusable elements. This should be the rest of them that I missed in #11364 ## References * #9990: a11y megathread * #11155: original version of this ## PR Checklist * [x] Should take care of #11996 once confirmed * [x] I work here ## Validation Steps Performed Used Accessibility Insights to verify. ## Detailed Description of the Pull Request / Additional comments There is one other weird bit. All the expanders that have content below the expander (not inline), show up as focusable, but don't have names. Even when I add names to them. I believe this is due to https://github.com/microsoft/microsoft-ui-xaml/issues/5820, which is fixed in https://github.com/microsoft/microsoft-ui-xaml/pull/6032, in https://github.com/microsoft/microsoft-ui-xaml/releases/tag/v2.8.0-prerelease.220118001. Unfortunately, we're on a 2.7 prerelease, so we don't have that fix yet. I may see how painful moving to that is, because we're gonna get another a11y ping as soon as 1.13 ships. I pre-emptively added names to these guys in f7ba158dc, so that the new MUX should just fix this without any thinking on our part. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:54 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28965