starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Terminal crashes when settings.json has an unnamed "scheme". #12400

New Issue
Closed
opened 2026-01-31 03:14:40 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 03:14:40 +00:00
Owner
Copy Link

Originally created by @danrozenberg on GitHub (Feb 4, 2021).

Environment

Microsoft Windows [Version 10.0.18363.1316]

Steps to reproduce

I had a settings.json file generated, then modified by Windows Terminal 1.5.10271.0
After updating to latest, Terminal would open and instantly crash.

Upon resetting the json and experimenting, it turns out that the culprit was the following element of my schemes array:

{"colorScheme": "Solarized Dark"}

Further inspection leads me to believe that Windows terminal will crash as long as there is any element in the schemes array without a name. Thus, the scheme

{ "name": "So Dark", "colorScheme": "Solarized Dark" }

does not make the application crash.

Expected behavior

Terminal should open and function normally, and/or complain about any incorrect configurations in settings.json (for example "a scheme must have a name").

Actual behavior

Terminal simply crashes after loading the json. Subsequent attempts to open Terminal fail since it keeps trying to use the afflicted settings.json

Originally created by @danrozenberg on GitHub (Feb 4, 2021). # Environment Microsoft Windows [Version 10.0.18363.1316] # Steps to reproduce I had a `settings.json` file generated, then modified by Windows Terminal `1.5.10271.0` After updating to latest, Terminal would open and instantly crash. Upon resetting the json and experimenting, it turns out that the culprit was the following element of my `schemes` array: `{"colorScheme": "Solarized Dark"}` Further inspection leads me to believe that Windows terminal will crash as long as there is any element in the `schemes` array _without_ a name. Thus, the scheme `` { "name": "So Dark", "colorScheme": "Solarized Dark" } `` does not make the application crash. # Expected behavior Terminal should open and function normally, and/or complain about any incorrect configurations in `settings.json` (for example "a scheme must have a name"). # Actual behavior Terminal simply crashes after loading the json. Subsequent attempts to open Terminal fail since it keeps trying to use the afflicted `settings.json`
claunia added the Resolution-Duplicate label 2026-01-31 03:14:40 +00:00
claunia commented 2026-01-31 03:14:41 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Feb 4, 2021):

@danrozenberg - I guess this can be related to https://github.com/microsoft/terminal/issues/8986, which was fixed two days ago and was not released yet.

@Don-Vito commented on GitHub (Feb 4, 2021): @danrozenberg - I guess this can be related to https://github.com/microsoft/terminal/issues/8986, which was fixed two days ago and was not released yet.
claunia commented 2026-01-31 03:14:41 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 4, 2021):

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #8986 for more discussion.

/dup #8986

@zadjii-msft commented on GitHub (Feb 4, 2021): Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #8986 for more discussion. /dup #8986
claunia commented 2026-01-31 03:14:41 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 4, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Feb 4, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12400
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?