[PR #12608] [MERGED] Make the Scrollbar 16dips again #29133

Open
opened 2026-01-31 09:33:00 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12608
Author: @zadjii-msft
Created: 3/1/2022
Status: ✅ Merged
Merged: 3/9/2022
Merged by: @undefined

Base: main ← Head: dev/migrie/b/12395-scrollbar-width


📝 Commits (6)

📊 Changes

2 files changed (+1145 additions, -0 deletions)

View changed files

📝 .github/actions/spelling/allow/allow.txt (+4 -0)
📝 src/cascadia/TerminalControl/TermControl.xaml (+1141 -0)

📄 Description

BODGY: Controlsv2 changed the size of the scrollbars from 16dips to
12dips. This is harder for folks to hit with the mouse, and isn't
consistent with the rest of the scrollbars on the platform (as much
as they can be).

To work around this, we have to entirely copy the template for the
ScrollBar into our XAML file. We're then also re-defining
ScrollBarSize here to 16, so that the new template will pick up on
the new value.

This is kinda a pain, and we have to be careful to be sure to ingest
an updated version of the template any time we update MUX. The
latest Controlsv2 version of the template can be found at:
https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/ScrollBar_themeresources.xaml#L218

We're also planning on making this adjustable in the future
(GH#9218), where we might need this anyways.

after, before:

image

after overlayed on top of before

image

comparison

image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12608 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/1/2022 **Status:** ✅ Merged **Merged:** 3/9/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/12395-scrollbar-width` --- ### 📝 Commits (6) - [`d866f87`](https://github.com/microsoft/terminal/commit/d866f87a15b3a7b33f2675f7032bb7d593592668) very simple update the TermControl to have a copy of the ScrollBar template - [`c074e97`](https://github.com/microsoft/terminal/commit/c074e974d189bd0f7e7dda5c92ebe1fab3fb411d) Update the width, add comments - [`a3a91f2`](https://github.com/microsoft/terminal/commit/a3a91f2b025c82a9d5577ac73a84b93631f2edc5) spell - [`6b609b3`](https://github.com/microsoft/terminal/commit/6b609b3a2977f8ef338c1ee57cdc3109c189e8be) whatever, it doesn't matter - [`b636c7c`](https://github.com/microsoft/terminal/commit/b636c7c60e7efc9a438b9bcd0a082f550745568a) sneak - [`63ab142`](https://github.com/microsoft/terminal/commit/63ab142cb1f78be4c450737d4014d9dddc2c4e4c) MUCH better ### 📊 Changes **2 files changed** (+1145 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/allow/allow.txt` (+4 -0) 📝 `src/cascadia/TerminalControl/TermControl.xaml` (+1141 -0) </details> ### 📄 Description BODGY: Controlsv2 changed the size of the scrollbars from 16dips to 12dips. This is harder for folks to hit with the mouse, and isn't consistent with the rest of the scrollbars on the platform (as much as they can be). To work around this, we have to entirely copy the template for the ScrollBar into our XAML file. We're then also re-defining ScrollBarSize here to 16, so that the new template will pick up on the new value. This is kinda a pain, and we have to be careful to be sure to ingest an updated version of the template any time we update MUX. The latest Controlsv2 version of the template can be found at: https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/ScrollBar_themeresources.xaml#L218 We're also planning on making this adjustable in the future (GH#9218), where we might need this anyways. ##### after, before: ![image](https://user-images.githubusercontent.com/18356694/156254464-1a9080f6-51ce-4619-b002-2a3c607cdf5f.png) ##### after overlayed on top of before ![image](https://user-images.githubusercontent.com/18356694/156254546-fccc3cee-12a3-4e1a-8fd7-7470f1ec93ad.png) ##### comparison ![image](https://user-images.githubusercontent.com/18356694/156257934-ec4ac840-c8ca-4fca-a848-08a32b1c55c3.png) * reported originally in #12395 * upstream: https://github.com/microsoft/microsoft-ui-xaml/issues/6684 * closes an element of #12400 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:33:00 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29133