starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Crash on exit #1243

New Issue
Closed
opened 2026-01-30 22:20:01 +00:00 by claunia · 6 comments
claunia commented 2026-01-30 22:20:01 +00:00
Owner
Copy Link

Originally created by @andy-yx-chen on GitHub (May 22, 2019).

Environment

Windows build number: [run "ver" at a command prompt]
Microsoft Windows [Version 10.0.18362.53]   
Windows Terminal version (if applicable):
build from master branch
Any other software?
none

Steps to reproduce

close the terminal and you will get it, double Release call

Expected behavior

Actual behavior

Originally created by @andy-yx-chen on GitHub (May 22, 2019). <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: [run "ver" at a command prompt] Microsoft Windows [Version 10.0.18362.53] Windows Terminal version (if applicable): build from master branch Any other software? none ``` # Steps to reproduce close the terminal and you will get it, double Release call <!-- A description of how to trigger this bug. --> # Expected behavior <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior <!-- What's actually happening? -->
claunia commented 2026-01-30 22:20:03 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 22, 2019):

I would have thought that this was #627, which should have been fixed by #746. Can you post a stack of the double release you're seeing?

@zadjii-msft commented on GitHub (May 22, 2019): I would have thought that this was #627, which should have been fixed by #746. Can you post a stack of the double release you're seeing?
claunia commented 2026-01-30 22:20:03 +00:00
Author
Owner
Copy Link

@andy-yx-chen commented on GitHub (May 22, 2019):

Microsoft.UI.Xaml.Markup.dll!winrt::impl::root_implementswinrt::Microsoft::UI::Xaml::Markup::implementation::XamlApplication,winrt::Microsoft::UI::Xaml::Markup::XamlApplication,winrt::Microsoft::UI::Xaml::Markup::IXamlMetadataProviderContainer,winrt::Windows::Foundation::IClosable,winrt::composable,winrt::composing,winrt::Windows::UI::Xaml::IApplicationOverrides,winrt::Windows::UI::Xaml::IApplicationOverrides2,winrt::Windows::UI::Xaml::Markup::IXamlMetadataProvider::Release() Line 6413 C++
Microsoft.UI.Xaml.Markup.dll!winrt::implementswinrt::Microsoft::UI::Xaml::Markup::implementation::XamlApplication,winrt::Microsoft::UI::Xaml::Markup::XamlApplication,winrt::Microsoft::UI::Xaml::Markup::IXamlMetadataProviderContainer,winrt::Windows::Foundation::IClosable,winrt::composable,winrt::composing,winrt::Windows::UI::Xaml::IApplicationOverrides,winrt::Windows::UI::Xaml::IApplicationOverrides2,winrt::Windows::UI::Xaml::Markup::IXamlMetadataProvider::Release() Line 6954 C++
Microsoft.UI.Xaml.Markup.dll!winrt::impl::produce_basewinrt::Microsoft::UI::Xaml::Markup::implementation::XamlApplication,winrt::Microsoft::UI::Xaml::Markup::IXamlApplication,void::Release() Line 6085 C++

The problem could be solved by Increase the reference for TerminalApp, but that does not make sense to me though

@andy-yx-chen commented on GitHub (May 22, 2019): > Microsoft.UI.Xaml.Markup.dll!winrt::impl::root_implements<winrt::Microsoft::UI::Xaml::Markup::implementation::XamlApplication,winrt::Microsoft::UI::Xaml::Markup::XamlApplication,winrt::Microsoft::UI::Xaml::Markup::IXamlMetadataProviderContainer,winrt::Windows::Foundation::IClosable,winrt::composable,winrt::composing,winrt::Windows::UI::Xaml::IApplicationOverrides,winrt::Windows::UI::Xaml::IApplicationOverrides2,winrt::Windows::UI::Xaml::Markup::IXamlMetadataProvider>::Release() Line 6413 C++ Microsoft.UI.Xaml.Markup.dll!winrt::implements<winrt::Microsoft::UI::Xaml::Markup::implementation::XamlApplication,winrt::Microsoft::UI::Xaml::Markup::XamlApplication,winrt::Microsoft::UI::Xaml::Markup::IXamlMetadataProviderContainer,winrt::Windows::Foundation::IClosable,winrt::composable,winrt::composing,winrt::Windows::UI::Xaml::IApplicationOverrides,winrt::Windows::UI::Xaml::IApplicationOverrides2,winrt::Windows::UI::Xaml::Markup::IXamlMetadataProvider>::Release() Line 6954 C++ Microsoft.UI.Xaml.Markup.dll!winrt::impl::produce_base<winrt::Microsoft::UI::Xaml::Markup::implementation::XamlApplication,winrt::Microsoft::UI::Xaml::Markup::IXamlApplication,void>::Release() Line 6085 C++ The problem could be solved by Increase the reference for TerminalApp, but that does not make sense to me though
claunia commented 2026-01-30 22:20:03 +00:00
Author
Owner
Copy Link

@andy-yx-chen commented on GitHub (May 22, 2019):

namespace winrt::TerminalApp::implementation
{

    App::App() :
        App(winrt::TerminalApp::XamlMetaDataProvider())
    {
    }

    App::App(Windows::UI::Xaml::Markup::IXamlMetadataProvider const& parentProvider) :
        base_type(parentProvider),
        _settings{  },
        _tabs{  },
        _loadedInitialSettings{ false }
    {
        // For your own sanity, it's better to do setup outside the ctor.
        // If you do any setup in the ctor that ends up throwing an exception,
        // then it might look like App just failed to activate, which will
        // cause you to chase down the rabbit hole of "why is App not
        // registered?" when it definitely is.
        **this->AddRef();**
    }
@andy-yx-chen commented on GitHub (May 22, 2019): ``` namespace winrt::TerminalApp::implementation { App::App() : App(winrt::TerminalApp::XamlMetaDataProvider()) { } App::App(Windows::UI::Xaml::Markup::IXamlMetadataProvider const& parentProvider) : base_type(parentProvider), _settings{ }, _tabs{ }, _loadedInitialSettings{ false } { // For your own sanity, it's better to do setup outside the ctor. // If you do any setup in the ctor that ends up throwing an exception, // then it might look like App just failed to activate, which will // cause you to chase down the rabbit hole of "why is App not // registered?" when it definitely is. **this->AddRef();** } ```
claunia commented 2026-01-30 22:20:03 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 22, 2019):

That's almost certainly not the correct solution to this bug, even if it might work.

I am seeing some other problems on exit, so we can use this to track following up on this issue.

I got some RoOriginateError in App::_RemoveTabViewItem on this line:

_tabs.erase(_tabs.begin() + tabIndexFromControl);
@zadjii-msft commented on GitHub (May 22, 2019): That's almost certainly not the correct solution to this bug, even if it might work. I am seeing some other problems on `exit`, so we can use this to track following up on this issue. I got some RoOriginateError in `App::_RemoveTabViewItem` on this line: ``` _tabs.erase(_tabs.begin() + tabIndexFromControl); ```
claunia commented 2026-01-30 22:20:04 +00:00
Author
Owner
Copy Link

@metathinker commented on GitHub (May 23, 2019):

Could this be the same issue as #457? @DHowett-MSFT said about that bug:

This is also the cause of a crash when closeOnExit is true and you exit the last shell.

And since PR #599 was merged, closeOnExit is indeed the default behavior.

@metathinker commented on GitHub (May 23, 2019): Could this be the same issue as #457? @DHowett-MSFT said about that bug: > This is also the cause of a crash when `closeOnExit` is true and you exit the last shell. And since PR #599 was merged, `closeOnExit` is indeed the default behavior.
claunia commented 2026-01-30 22:20:04 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 23, 2019):

Oh yea, this probably is a dupe of that one. Good catch!

@zadjii-msft commented on GitHub (May 23, 2019): Oh yea, this probably is a dupe of that one. Good catch!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Product-Terminal Resolution-Duplicate Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1243
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?