starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

RS4+: v2 console: WriteConsoleA returns lpNumberOfBytesWritten==0 during selection #457

New Issue
Closed
opened 2026-01-30 21:52:48 +00:00 by claunia · 3 comments
claunia commented 2026-01-30 21:52:48 +00:00
Owner
Copy Link

Originally created by @DHowett-MSFT on GitHub (Nov 21, 2018).

Originally assigned to: @miniksa on GitHub.

Using a modified version of @rprichard's test from #40:

#pragma comment(lib, "user32.lib") 

#include <windows.h>
#include <stdio.h>
#include <string.h>

#include <thread>

// Send "Select All", then spawn a thread to hit ESC a moment later.
static void start_selection() {
    const HWND hwnd = GetConsoleWindow();
    const int SC_CONSOLE_SELECT_ALL = 0xFFF5;
    SendMessage(hwnd, WM_SYSCOMMAND, SC_CONSOLE_SELECT_ALL, 0);
    auto press_escape = std::thread([=]() {
        Sleep(500);
        SendMessage(hwnd, WM_CHAR, 27, 0x00010001);
    });
    press_escape.detach();
}

template <typename T>
static void do_write_test(
        const char *api_name,
        T *api_ptr,
        bool use_selection) {
    if (use_selection)
        start_selection();
    char buf[] = "1234567890567890567890567890\n";
    DWORD actual = 0;
    const BOOL ret = api_ptr(
        GetStdHandle(STD_OUTPUT_HANDLE),
        buf, strlen(buf), &actual, NULL);
    const DWORD last_error = GetLastError();
    printf("%s: %s returned %d: actual=%u LastError=%u (%s)\n",
        ((ret && actual == strlen(buf)) ? "SUCCESS" : "ERROR"),
        api_name, ret, actual, last_error,
        use_selection ? "select" : "no-select");
}

int main() {
    do_write_test("WriteConsoleA", WriteConsoleA, false);
    do_write_test("WriteConsoleA", WriteConsoleA, true);
    do_write_test("WriteFile", WriteFile, true);
    return 0;
}

We get the following output:

1234567890567890567890567890
SUCCESS: WriteConsoleA returned 1: actual=29 LastError=0 (no-select)
1234567890567890567890567890
ERROR: WriteConsoleA returned 1: actual=0 LastError=0 (select)
1234567890567890567890567890
SUCCESS: WriteFile returned 1: actual=29 LastError=0 (select)
Originally created by @DHowett-MSFT on GitHub (Nov 21, 2018). Originally assigned to: @miniksa on GitHub. Using a modified version of @rprichard's test from #40: ```cpp #pragma comment(lib, "user32.lib") #include <windows.h> #include <stdio.h> #include <string.h> #include <thread> // Send "Select All", then spawn a thread to hit ESC a moment later. static void start_selection() { const HWND hwnd = GetConsoleWindow(); const int SC_CONSOLE_SELECT_ALL = 0xFFF5; SendMessage(hwnd, WM_SYSCOMMAND, SC_CONSOLE_SELECT_ALL, 0); auto press_escape = std::thread([=]() { Sleep(500); SendMessage(hwnd, WM_CHAR, 27, 0x00010001); }); press_escape.detach(); } template <typename T> static void do_write_test( const char *api_name, T *api_ptr, bool use_selection) { if (use_selection) start_selection(); char buf[] = "1234567890567890567890567890\n"; DWORD actual = 0; const BOOL ret = api_ptr( GetStdHandle(STD_OUTPUT_HANDLE), buf, strlen(buf), &actual, NULL); const DWORD last_error = GetLastError(); printf("%s: %s returned %d: actual=%u LastError=%u (%s)\n", ((ret && actual == strlen(buf)) ? "SUCCESS" : "ERROR"), api_name, ret, actual, last_error, use_selection ? "select" : "no-select"); } int main() { do_write_test("WriteConsoleA", WriteConsoleA, false); do_write_test("WriteConsoleA", WriteConsoleA, true); do_write_test("WriteFile", WriteFile, true); return 0; } ``` We get the following output: ``` 1234567890567890567890567890 SUCCESS: WriteConsoleA returned 1: actual=29 LastError=0 (no-select) 1234567890567890567890567890 ERROR: WriteConsoleA returned 1: actual=0 LastError=0 (select) 1234567890567890567890567890 SUCCESS: WriteFile returned 1: actual=29 LastError=0 (select) ```
claunia added the Product-ConhostResolution-Fix-Available labels 2026-01-30 21:52:48 +00:00
claunia commented 2026-01-30 21:52:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 26, 2018):

MSFT:19723646 internally.

@zadjii-msft commented on GitHub (Nov 26, 2018): MSFT:19723646 internally.
claunia commented 2026-01-30 21:52:49 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Dec 21, 2018):

OK checked this in today.

@miniksa commented on GitHub (Dec 21, 2018): OK checked this in today.
claunia commented 2026-01-30 21:52:49 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jan 16, 2019):

This went out in 18315!

@DHowett-MSFT commented on GitHub (Jan 16, 2019): This went out in 18315!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Product-Conhost Resolution-Fix-Available
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#457
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?