starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Doc issue: Spectre mitigated libraries needed? #1274

New Issue
Open
opened 2026-01-30 22:20:45 +00:00 by claunia · 7 comments
claunia commented 2026-01-30 22:20:45 +00:00
Owner
Copy Link

Originally created by @metathinker on GitHub (May 23, 2019).

Yesterday, I tried installing Visual Studio 2019 (16.1.0) on a new computer and cloning and building the terminal repo. When installing VS, I made sure to select the "desktop dev with C++" and "universal Windows dev" profiles, and the v141 compiler and universal Windows tools.

However, building from the command line with bz reliably failed. While I don't have the exact text on hand, I remember MSBuild showed the following:

  • Warnings in an MSBuild-built-in settings file (in C:\Program Files or similar, not in the terminal repo) that Spectre-mitigated libraries were chosen but not installed.
  • Errors that the linker could not find the import .lib for the C runtime or C++ library DLLs (msvcrt.lib , msvcprt.lib , ...). After observing with Process Monitor, I saw that link.exe did seem to be looking only in "Spectre" folders for these files.

Is it expected that Spectre-mitigated C runtimes are required? Could it be documented if so? And if not, could it be corrected?

Originally created by @metathinker on GitHub (May 23, 2019). Yesterday, I tried installing Visual Studio 2019 (16.1.0) on a new computer and cloning and building the terminal repo. When installing VS, I made sure to select the "desktop dev with C++" and "universal Windows dev" profiles, and the v141 compiler and universal Windows tools. However, building from the command line with `bz` reliably failed. While I don't have the exact text on hand, I remember MSBuild showed the following: - Warnings in an MSBuild-built-in settings file (in `C:\Program Files` or similar, not in the terminal repo) that Spectre-mitigated libraries were chosen but not installed. - Errors that the linker could not find the import .lib for the C runtime or C++ library DLLs (`msvcrt.lib` , `msvcprt.lib` , ...). After observing with [Process Monitor](https://docs.microsoft.com/sysinternals/downloads/procmon), I saw that link.exe did seem to be looking only in "Spectre" folders for these files. Is it expected that Spectre-mitigated C runtimes are required? Could it be documented if so? And if not, could it be corrected?
claunia added the Issue-DocsProduct-MetaArea-Build labels 2026-01-30 22:20:45 +00:00
claunia commented 2026-01-30 22:20:46 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 23, 2019):

Spectre mitigation is enabled by default if you’ve installed the WDK. I believe there’s an ongoing UserVoice or DevCommunity discussion about it. Apologies, I can’t dig up the link at the moment.

@DHowett-MSFT commented on GitHub (May 23, 2019): Spectre mitigation is enabled by default if you’ve installed the WDK. I believe there’s an ongoing UserVoice or DevCommunity discussion about it. Apologies, I can’t dig up the link at the moment.
claunia commented 2026-01-30 22:20:46 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 23, 2019):

Here you go.

Do you have the WDK installed?

@DHowett-MSFT commented on GitHub (May 23, 2019): [Here](https://developercommunity.visualstudio.com/content/problem/348985/installing-wdk-1809-enabled-spectre-mitigation-fla.html) you go. Do you have the WDK installed?
claunia commented 2026-01-30 22:20:47 +00:00
Author
Owner
Copy Link

@metathinker commented on GitHub (May 23, 2019):

Yes, I did have the Windows Driver Kit installed on the box. Good guess!

I do think this problem - that if you have the WDK installed, you must also install the Spectre-mitigated libs or modify the MSBuild defaults, per the discussion thread you linked - does need to be documented, either in the doc markdown files or in the "Guide for build" issue thread (#489). What do you think? If it should go in the .md files I would be happy to submit a PR for that.

@metathinker commented on GitHub (May 23, 2019): Yes, I did have the Windows Driver Kit installed on the box. Good guess! I do think this problem - that if you have the WDK installed, you must also install the Spectre-mitigated libs or modify the MSBuild defaults, per the discussion thread you linked - does need to be documented, either in the doc markdown files or in the "Guide for build" issue thread (#489). What do you think? If it should go in the .md files I would be happy to submit a PR for that.
claunia commented 2026-01-30 22:20:47 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 28, 2019):

Given that this is a widespread issue, I don't see the value in documenting it. Here's my thoughts:
Documenting this for our project specifically is like documenting "if you install the wrong tools, it will behave poorly" -- it's not specific to us, and we might run the risk of accumulating a bunch of documentation callouts that aren't specific to us. They'll age, go stale, and become annoying vestigial limbs.

@DHowett-MSFT commented on GitHub (May 28, 2019): Given that this is a widespread issue, I don't see the value in documenting it. Here's my thoughts: Documenting this for our project specifically is like documenting "if you install the wrong tools, it will behave poorly" -- it's not specific to us, and we might run the risk of accumulating a bunch of documentation callouts that aren't specific to us. They'll age, go stale, and become annoying vestigial limbs.
claunia commented 2026-01-30 22:20:47 +00:00
Author
Owner
Copy Link

@metathinker commented on GitHub (May 28, 2019):

I don't agree with this resolution (and I notice I can't reopen the issue either, but I'm not really interested in fighting hard on this issue so I'll leave that be). Yes, the problem is not specific to this project and is fairly general, but I say making people figure it out themselves places unnecessary roadblocks in the new contributor process. Ultimately there is a balance that has to be struck between excessive and/or misleading hand-holding and leaving people out in the cold and we'll have to agree to disagree on where that balance point is placed.

@metathinker commented on GitHub (May 28, 2019): I don't agree with this resolution (and I notice I can't reopen the issue either, but I'm not really interested in fighting hard on this issue so I'll leave that be). Yes, the problem is not specific to this project and is fairly general, but I say making people figure it out themselves places unnecessary roadblocks in the new contributor process. Ultimately there is a balance that has to be struck between excessive and/or misleading hand-holding and leaving people out in the cold and we'll have to agree to disagree on where that balance point is placed.
claunia commented 2026-01-30 22:20:47 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 29, 2019):

You've made a good point.

@DHowett-MSFT commented on GitHub (May 29, 2019): You've made a good point.
claunia commented 2026-01-30 22:20:47 +00:00
Author
Owner
Copy Link

@TheCrazyLion commented on GitHub (Nov 20, 2020):

i have same problem. tryng to fix it for weeks. sadly there is not any solution online

@TheCrazyLion commented on GitHub (Nov 20, 2020): i have same problem. tryng to fix it for weeks. sadly there is not any solution online
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Issue-Docs Product-Meta
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1274
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?