starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

UseDx option no longer works in conhost #2870

New Issue
Closed
opened 2026-01-30 23:07:34 +00:00 by claunia · 3 comments
claunia commented 2026-01-30 23:07:34 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Jul 21, 2019).

Environment

Windows build number: Version 10.0.18362.175
Windows Terminal version (if applicable): Locally built from commit dca0ffe

Steps to reproduce

  1. Set the DWORD registry value HKCU\Console\UseDx to 1 to enable the DirectX renderer that supports font fallback.
  2. Build the latest source (or at least commit dca0ffe).
  3. Start a bash shell in conhost with the tools\openbash script.
  4. Try outputting a character that would usually require font fallback, for example:
    echo -e "\u273f"

Expected behavior

I'd expect to see the actual glyph requested. In the case of the U+273F example above, a black florette.

Actual behavior

The font fallback doesn't work and you just see a question mark error glyph.

I believe this is a regression caused by the Windows 8.1 version check introduced in PR #1274. I'm guessing it might be because VerifyVersionInfo returns false when called by applications that do not have a compatibility manifest (according to the docs here).

Whatever the reason, removing the version check fixes the problem for me. Not that I'm suggesting that's the solution - just confirming what I believe is the source of the problem.

Originally created by @j4james on GitHub (Jul 21, 2019). # Environment Windows build number: Version 10.0.18362.175 Windows Terminal version (if applicable): Locally built from [commit dca0ffe](https://github.com/microsoft/terminal/commit/dca0ffe6dd0f76ca7997807424a2c08684e07751) # Steps to reproduce 1. Set the DWORD registry value `HKCU\Console\UseDx` to `1` to enable the DirectX renderer that supports font fallback. 2. Build the latest source (or at least [commit dca0ffe](https://github.com/microsoft/terminal/commit/dca0ffe6dd0f76ca7997807424a2c08684e07751)). 3. Start a bash shell in conhost with the `tools\openbash` script. 4. Try outputting a character that would usually require font fallback, for example: ```echo -e "\u273f"``` # Expected behavior I'd expect to see the actual glyph requested. In the case of the U+273F example above, a [black florette](https://unicode-table.com/en/273F/). # Actual behavior The font fallback doesn't work and you just see a question mark error glyph. I believe this is a regression caused by the Windows 8.1 version check introduced in PR #1274. I'm guessing it might be because `VerifyVersionInfo` returns false when called by applications that do not have a compatibility manifest (according to the docs [here](https://docs.microsoft.com/en-gb/windows/win32/api/winbase/nf-winbase-verifyversioninfoa#remarks)). Whatever the reason, removing the [version check](https://github.com/dgriffen/terminal/blob/cfa32c34b5bab09fd011d07c369f9bb18d4c6f1a/src/renderer/dx/CustomTextLayout.cpp#L139) fixes the problem for me. Not that I'm suggesting that's the solution - just confirming what I believe is the source of the problem.
claunia commented 2026-01-30 23:07:36 +00:00
Author
Owner
Copy Link

@fcharlie commented on GitHub (Jul 22, 2019):

If supportedOS is not set in the application manifest, then IsWindows8Point1OrGreater will fail. Currently, conhost does not link any manifest files, and the manifest file in the conhost source directory is not set to supportedOS.

I created a commit to fix the application manifest file, but it has not been tested yet, so I haven't created PR yet: 4c6280ca35

@fcharlie commented on GitHub (Jul 22, 2019): If `supportedOS` is not set in the application manifest, then `IsWindows8Point1OrGreater` will fail. Currently, conhost does not link any manifest files, and the manifest file in the conhost source directory is not set to `supportedOS`. I created a commit to fix the application manifest file, but it has not been tested yet, so I haven't created PR yet: https://github.com/fcharlie/terminal/commit/4c6280ca35fff9eac0041c94385574bedc5f2a27
claunia commented 2026-01-30 23:07:36 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jul 22, 2019):

/cc @dgriffen (just fyi)

@DHowett-MSFT commented on GitHub (Jul 22, 2019): /cc @dgriffen (just fyi)
claunia commented 2026-01-30 23:07:36 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 23, 2019):

@DHowett-MSFT I didn't realize that conhost didn't have its own application manifest. Unfortunately there is no good way to test OS version that doesn't rely on the application manifest since Windows will try its best to report an old OS number if you don't have a manifest.

@ghost commented on GitHub (Jul 23, 2019): @DHowett-MSFT I didn't realize that conhost didn't have its own application manifest. Unfortunately there is no good way to test OS version that doesn't rely on the application manifest since Windows will try its best to report an old OS number if you don't have a manifest.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Help Wanted Issue-Bug Needs-Tag-Fix Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2870
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?