The Settings context menu still uses the BIG close icon #12772

Closed
opened 2026-01-31 03:24:32 +00:00 by claunia · 3 comments
Owner

Originally created by @zadjii-msft on GitHub (Mar 1, 2021).

Originally assigned to: @carlos-zamora on GitHub.

The Settings context menu still uses the old icon.
closeicon2
Wouldn't it be better to have a single menu for all tabs?

Originally posted by @gabrielconl in https://github.com/microsoft/terminal/issues/8419#issuecomment-788035770


Originally fixed in #8424, but not for SettingsTab. Really should be fixed in TabBase

Originally created by @zadjii-msft on GitHub (Mar 1, 2021). Originally assigned to: @carlos-zamora on GitHub. The Settings context menu still uses the old icon. ![closeicon2](https://user-images.githubusercontent.com/78622729/109518910-63fa1300-7ab3-11eb-9379-58d761410ff2.png) Wouldn't it be better to have a single menu for all tabs? _Originally posted by @gabrielconl in https://github.com/microsoft/terminal/issues/8419#issuecomment-788035770_ <hr> Originally fixed in #8424, but not for SettingsTab. Really should be fixed in `TabBase`
Author
Owner

@zadjii-msft commented on GitHub (Mar 1, 2021):

Tossing this in 2.0, since this is a p3 bug.

@zadjii-msft commented on GitHub (Mar 1, 2021): Tossing this in 2.0, since this is a p3 bug.
Author
Owner

@ghost commented on GitHub (Apr 14, 2021):

:tada:This issue was addressed in #9324, which has now been successfully released as Windows Terminal v1.7.1033.0.🎉

Handy links:

@ghost commented on GitHub (Apr 14, 2021): :tada:This issue was addressed in #9324, which has now been successfully released as `Windows Terminal v1.7.1033.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.7.1033.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Author
Owner

@ghost commented on GitHub (Apr 14, 2021):

:tada:This issue was addressed in #9324, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.🎉

Handy links:

@ghost commented on GitHub (Apr 14, 2021): :tada:This issue was addressed in #9324, which has now been successfully released as `Windows Terminal Preview v1.8.1032.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1032.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12772