starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Option to confirm before closing a tab #12999

New Issue
Closed
opened 2026-01-31 03:31:02 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 03:31:02 +00:00
Owner
Copy Link

Originally created by @ercius on GitHub (Mar 12, 2021).

Description of the new feature/enhancement

I accidentally clicked the x on a running Ubuntu terminal (instead of activating that tab) and closed an important ssh session losing all work. There was no confirmation to close the running session.

Can an option to confirm on exit for a single tab be added? There is already an option to confirm when closing many tabs, but not for a single tab.

BTW: Windows Terminal is awesome. Where has this been all my life?

Originally created by @ercius on GitHub (Mar 12, 2021). # Description of the new feature/enhancement I accidentally clicked the x on a running Ubuntu terminal (instead of activating that tab) and closed an important ssh session losing all work. There was no confirmation to close the running session. Can an option to confirm on exit for a single tab be added? There is already an option to confirm when closing many tabs, but not for a single tab. BTW: Windows Terminal is awesome. Where has this been all my life?
claunia added the Issue-FeatureResolution-Duplicate labels 2026-01-31 03:31:02 +00:00
claunia commented 2026-01-31 03:31:03 +00:00
Author
Owner
Copy Link

@Nacimota commented on GitHub (Mar 14, 2021):

This seems pretty reasonable to me as an optional feature, disabled by default. Perhaps we could even have it as a per-profile setting? So for instance if you have a profile you mostly use for SSH or something important you don't want to accidentally close you could set warnOnClose (or whatever) to true.

@Nacimota commented on GitHub (Mar 14, 2021): This seems pretty reasonable to me as an optional feature, disabled by default. Perhaps we could even have it as a per-profile setting? So for instance if you have a profile you mostly use for SSH or something important you don't want to accidentally close you could set `warnOnClose` (or whatever) to `true`.
claunia commented 2026-01-31 03:31:03 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Mar 14, 2021):

@Nacimota - great idea.

@ercius - consider using read-only panes for important stuff (https://docs.microsoft.com/en-us/windows/terminal/customize-settings/actions#mark-a-pane-as-read-only-preview).

In addition, there is https://github.com/microsoft/terminal/issues/3335, suggesting to hide the "x" button to prevent such faulty clicks.

@Don-Vito commented on GitHub (Mar 14, 2021): @Nacimota - great idea. @ercius - consider using read-only panes for important stuff (https://docs.microsoft.com/en-us/windows/terminal/customize-settings/actions#mark-a-pane-as-read-only-preview). In addition, there is https://github.com/microsoft/terminal/issues/3335, suggesting to hide the "x" button to prevent such faulty clicks.
claunia commented 2026-01-31 03:31:04 +00:00
Author
Owner
Copy Link

@ercius commented on GitHub (Mar 14, 2021):

warnOnClose is a great option to have per tab.

Ill also check out the read-only panes in Preview and see how they work. Thanks!

@ercius commented on GitHub (Mar 14, 2021): `warnOnClose` is a great option to have per tab. Ill also check out the read-only panes in Preview and see how they work. Thanks!
claunia commented 2026-01-31 03:31:04 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 15, 2021):

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #6549 for more discussion.

/dup #6549

@zadjii-msft commented on GitHub (Mar 15, 2021): Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #6549 for more discussion. /dup #6549
claunia commented 2026-01-31 03:31:04 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Mar 15, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Mar 15, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Feature Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12999
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?