starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Coalesce adjacent glyph scale corrections to reduce total run count and split activity #6549

New Issue
Open
opened 2026-01-31 00:41:27 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 00:41:27 +00:00
Owner
Copy Link

Originally created by @miniksa on GitHub (Feb 20, 2020).

To correct the scaling factor of glyphs (the vertical height) to fit inside a single cell, a correction factor is added in CustomTextLayout.

This takes the form of filling the _glyphScaleCorrections vector as we do _CorrectGlyphRun and then turns into splits around each glyph in the parent _CorrectGlyphRuns.

This represents identifying when two or more adjacent characters need the same scale factor and reducing the number of corrections/splits created as the original algorithm is relatively naive.

Example:
If B and C both need a scale factor of 0.5...

A   B   C   D
1   .5  .5   1

_glyphScaleCorrections will have two values
IDX = 1, SCALE = 0.5 (for the B)
IDX = 2, SCALE = 0.5 (for the C)

and 4 runs will be created
Run0 = A @ 1
Run1 = B @ 0.5
Run2 = C @ 0.5
Run3 = D @ 0.5

The thought here is that we could collapse _glyphScaleCorrections into one record
IDX = 1, SCALE = 0.5, LEN = 2 (for the B and C together)

and then only 3 runs would be created
Run0 = A @ 1
Run1 = B C @ 0.5
Run2 = D @ 1

Originally created by @miniksa on GitHub (Feb 20, 2020). To correct the scaling factor of glyphs (the vertical height) to fit inside a single cell, a correction factor is added in `CustomTextLayout`. This takes the form of filling the `_glyphScaleCorrections` vector as we do `_CorrectGlyphRun` and then turns into splits around each glyph in the parent `_CorrectGlyphRuns`. This represents identifying when two or more adjacent characters need the same scale factor and reducing the number of corrections/splits created as the original algorithm is relatively naive. Example: If B and C both need a scale factor of 0.5... ``` A B C D 1 .5 .5 1 ``` `_glyphScaleCorrections` will have two values IDX = 1, SCALE = 0.5 (for the B) IDX = 2, SCALE = 0.5 (for the C) and 4 runs will be created Run0 = A @ 1 Run1 = B @ 0.5 Run2 = C @ 0.5 Run3 = D @ 0.5 The thought here is that we could collapse `_glyphScaleCorrections` into one record IDX = 1, SCALE = 0.5, LEN = 2 (for the B and C together) and then only 3 runs would be created Run0 = A @ 1 Run1 = B C @ 0.5 Run2 = D @ 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Performance Area-Rendering Help Wanted Issue-Task Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6549
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?