starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add a switch to disable closing a tab if it is not active #17433

New Issue
Closed
opened 2026-01-31 05:42:20 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 05:42:20 +00:00
Owner
Copy Link

Originally created by @trajano on GitHub (May 9, 2022).

Description of the new feature/enhancement

Sometimes when switching tabs, I accidentally hit the close button when I am expecting to switch tabs. I am asking if we can add a switch that is disabled by default to disable closing the tab if is it not presently active, as such if I want to close an inactive tab I have to press the close button twice.

Proposed technical implementation details (optional)

Assuming the setting is present. It's a matter of

on close tab
  if not active
    return or just set tab to foreground
  else 
   close the tab
  endif
Originally created by @trajano on GitHub (May 9, 2022). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement Sometimes when switching tabs, I accidentally hit the close button when I am expecting to switch tabs. I am asking if we can add a switch that is disabled by default to disable closing the tab if is it not presently active, as such if I want to close an inactive tab I have to press the close button twice. # Proposed technical implementation details (optional) Assuming the setting is present. It's a matter of ``` on close tab if not active return or just set tab to foreground else close the tab endif ```
claunia added the Issue-FeatureNeeds-TriageNeeds-AttentionResolution-Duplicate labels 2026-01-31 05:42:20 +00:00
claunia commented 2026-01-31 05:42:21 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 16, 2022):

Huh. This seems like a variation on #3335. In addition to the proposed

"tab.showCloseButton": "always"|"hover"|"never"

maybe something like "tab.showCloseButton": "active" to make it only visible when the tab is the active tab? That has the added complication though - is there a activeAndHover version? inactiveAndHover? activeNoHover? That might be too complicated.

Maybe the better solution is just some version of the warnings proposed in https://github.com/microsoft/terminal/issues/6549#issuecomment-675494526. Does that seem like a viable solution to this workflow/?

@zadjii-msft commented on GitHub (May 16, 2022): Huh. This seems like a variation on #3335. In addition to the proposed ``` "tab.showCloseButton": "always"|"hover"|"never" ``` maybe something like `"tab.showCloseButton": "active"` to make it only visible when the tab is the active tab? That has the added complication though - is there a `activeAndHover` version? `inactiveAndHover`? `activeNoHover`? That might be too complicated. Maybe the better solution is just some version of the warnings proposed in https://github.com/microsoft/terminal/issues/6549#issuecomment-675494526. Does that seem like a viable solution to this workflow/?
claunia commented 2026-01-31 05:42:22 +00:00
Author
Owner
Copy Link

@trajano commented on GitHub (May 16, 2022):

I think we can merge this into one user story that collects all of the scenarios and lists it out like https://github.com/microsoft/terminal/issues/6549#issuecomment-675494526

@trajano commented on GitHub (May 16, 2022): I think we can merge this into one user story that collects all of the scenarios and lists it out like https://github.com/microsoft/terminal/issues/6549#issuecomment-675494526
claunia commented 2026-01-31 05:42:22 +00:00
Author
Owner
Copy Link

@trajano commented on GitHub (May 16, 2022):

merge with #3335 and #6549 please

@trajano commented on GitHub (May 16, 2022): merge with #3335 and #6549 please
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Feature Needs-Attention Needs-Triage Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17433
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?