Progress state doesn't update correctly between panes #13353

Closed
opened 2026-01-31 03:40:30 +00:00 by claunia · 4 comments
Owner

Originally created by @zadjii-msft on GitHub (Apr 7, 2021).

  1. Set the progress to indeterminate state in a pane.
  2. Open a new tab. Note that the taskbar and tabs display as expected.
  3. Switch back to the first tab. Note that the taskbar and tabs display as expected.
  4. Open a new pane. Note that the tab and taskbar still display the progress state!
  5. Switch to the second tab. Note that the taskbar and tabs display as expected.
  6. Switch back to the first tab. Note that the taskbar and tabs display as expected. (no progress, because the second pane does not have progress state)
  7. Switch to the first pane. Note that the tab and taskbar still have no progress state!

Seemingly the progress state doesn't update when the active pane changes, only when the active tab does.

I might have a fix for this that's paired with #6842, but do we want to bite off a 30 file PR just for this fix?

Originally created by @zadjii-msft on GitHub (Apr 7, 2021). 1. Set the progress to indeterminate state in a pane. 2. Open a new tab. Note that the taskbar and tabs display as expected. 3. Switch back to the first tab. Note that the taskbar and tabs display as expected. 4. Open a new pane. Note that the tab and taskbar _still display the progress state!_ 5. Switch to the second tab. Note that the taskbar and tabs display as expected. 6. Switch back to the first tab. Note that the taskbar and tabs display as expected. (no progress, because the second pane does not have progress state) 7. Switch to the first pane. Note that the tab and taskbar _still have no progress state!_ Seemingly the progress state doesn't update when the active pane changes, only when the active tab does. I might have a fix for this that's paired with #6842, but do we want to bite off a 30 file PR just for this fix?
Author
Owner

@DHowett commented on GitHub (Apr 7, 2021):

do we want to bite off

Well, not exactly, but one takes the fix out of the 30 file PR ;)

@DHowett commented on GitHub (Apr 7, 2021): > do we want to bite off Well, not exactly, but one takes the fix out of the 30 file PR ;)
Author
Owner

@Don-Vito commented on GitHub (Apr 12, 2021):

I guess I don't fully understand the logic, but I am not sure why TaskbarProgressChanged is not called upon pane activation. I will create a draft PR with this :)

@Don-Vito commented on GitHub (Apr 12, 2021): I guess I don't fully understand the logic, but I am not sure why `TaskbarProgressChanged` is not called upon pane activation. I will create a draft PR with this :)
Author
Owner

@ghost commented on GitHub (Apr 14, 2021):

:tada:This issue was addressed in #9779, which has now been successfully released as Windows Terminal v1.7.1033.0.🎉

Handy links:

@ghost commented on GitHub (Apr 14, 2021): :tada:This issue was addressed in #9779, which has now been successfully released as `Windows Terminal v1.7.1033.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.7.1033.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Author
Owner

@ghost commented on GitHub (Apr 14, 2021):

:tada:This issue was addressed in #9779, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.🎉

Handy links:

@ghost commented on GitHub (Apr 14, 2021): :tada:This issue was addressed in #9779, which has now been successfully released as `Windows Terminal Preview v1.8.1032.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1032.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13353