starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[megathread] Deleting profiles is often confusing #13674

New Issue
Closed
opened 2026-01-31 03:49:07 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 03:49:07 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Apr 29, 2021).

Deleting profiles is often confusing. There are builtin, dynamic, and user profiles. Profiles can be hidden or deleted (as of #10910)

  • If WSL fails to respond (it does this from time to time), but you customized WSL, then the SUI won't have the profile in its list of profiles, and saving the SUI won't write out the WSL profile. That's bad.
    • We should still write it out to the settings file
    • We should indicate that it's a dynamic profile where we couldn't find the source
  • Dynamic profiles should be able to be deleted in the SUI, and have them removed from the settings file. The tombstone in state.json will let us know "the user does not want to see this".
  • Built-in profiles cannot be deleted, but maybe we should have a "hidden" toggle more prominent on the "General" page
  • The Extensions page (#10436) should allow users to recreate profiles that have been deleted for dynamic profiles.
    • i.e. The user deletes "Debian" from their settings.json. the Debian profile doesn't show up in the SUI. However, on the extensions page, where it lists WSL generator, there's a little ↩ button to recreate the profile in the settings
  • Dynamic profiles are just a little different than normal profiles. They should be clearly identified with a link back to the extension page that generated them. (#10707)

relevant discussions:

Relevant discussions on "WSL slow to start":

Originally created by @zadjii-msft on GitHub (Apr 29, 2021). Deleting profiles is often confusing. There are builtin, dynamic, and user profiles. Profiles can be hidden or deleted (as of #10910) * [x] If WSL fails to respond (it does this from time to time), but you customized WSL, then the SUI won't have the profile in its list of profiles, and saving the SUI _won't write out the WSL profile_. That's bad. * [x] We should still write it out to the settings file * [x] We should indicate that it's a dynamic profile where we couldn't find the source * [x] Dynamic profiles should be able to be deleted in the SUI, and have them _removed from the settings file_. The tombstone in `state.json` will let us know "the user does not want to see this". - This may have been #11007 * [x] Built-in profiles cannot be deleted, but maybe we should have a "hidden" toggle more prominent on the "General" page * [ ] The Extensions page (#10436) should allow users to recreate profiles that have been deleted for dynamic profiles. - i.e. The user deletes "Debian" from their `settings.json`. the Debian profile doesn't show up in the SUI. However, on the extensions page, where it lists WSL generator, there's a little `↩` button to recreate the profile in the settings * [ ] Dynamic profiles are just a little different than normal profiles. They should be clearly identified with a link back to the extension page that generated them. (#10707) relevant discussions: * https://github.com/microsoft/terminal/pull/10910#issuecomment-897795957 * [x] https://github.com/microsoft/terminal/issues/8270#issuecomment-883704914 * #8270 was fixed by #10910 * [x] https://github.com/microsoft/terminal/issues/10547#issuecomment-883698812 * also https://github.com/microsoft/terminal/issues/10547#issuecomment-884118826 Relevant discussions on "WSL slow to start": * [ ] #6160 * [x] #7199 * [x] #9905 * [x] https://github.com/microsoft/terminal/issues/10964#issuecomment-900357472 * These were all fixed by #10967
claunia commented 2026-01-31 03:49:09 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 15, 2024):

Yea, I'll count this as completed by #18188. I think we display enough at this point where it's no longer confusing.

@zadjii-msft commented on GitHub (Nov 15, 2024): Yea, I'll count this as completed by #18188. I think we display enough at this point where it's no longer confusing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Area-SettingsUI Issue-Scenario Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13674
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?