starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13674] [MERGED] Use only one tab color picker for all tabs, delay load it #29697

New Issue
Open
opened 2026-01-31 09:36:23 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:36:23 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13674
Author: @PankajBhojwani
Created: 8/4/2022
Status: ✅ Merged
Merged: 8/5/2022
Merged by: @undefined

Base: main ← Head: dev/pabhoj/wt_start

📝 Commits (3)

📊 Changes

5 files changed (+70 additions, -22 deletions)

View changed files

📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+1 -1)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+14 -0)
📝 src/cascadia/TerminalApp/TerminalPage.h (+1 -0)
📝 src/cascadia/TerminalApp/TerminalTab.cpp (+45 -19)
📝 src/cascadia/TerminalApp/TerminalTab.h (+9 -2)

📄 Description

Summary of the Pull Request

  • We only ever have 1 color picker now, instead of each tab having its own
  • TerminalPage constructs this color picker (upon first request for it)
  • TerminalPage attaches the color picker to the tab that requested for it
  • TerminalTab detaches the color picker when it is done with it, so that TerminalPage can attach it to another tab later on

References

#5907

Validation Steps Performed

User-end behaviour is the same

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13674 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 8/4/2022 **Status:** ✅ Merged **Merged:** 8/5/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/wt_start` --- ### 📝 Commits (3) - [`5515c17`](https://github.com/microsoft/terminal/commit/5515c1744bba91604d0782d1494f4edb8a10e301) works - [`617a578`](https://github.com/microsoft/terminal/commit/617a5783c90a6ee6fbc6b6f19bda371cf35a7b97) cmd pal - [`b30be98`](https://github.com/microsoft/terminal/commit/b30be989b82244fafc77c80ddfcc073c39d751ed) mtd desc ### 📊 Changes **5 files changed** (+70 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+14 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+1 -0) 📝 `src/cascadia/TerminalApp/TerminalTab.cpp` (+45 -19) 📝 `src/cascadia/TerminalApp/TerminalTab.h` (+9 -2) </details> ### 📄 Description ## Summary of the Pull Request - We only ever have 1 color picker now, instead of each tab having its own - `TerminalPage` constructs this color picker (upon first request for it) - `TerminalPage` attaches the color picker to the tab that requested for it - `TerminalTab` detaches the color picker when it is done with it, so that `TerminalPage` can attach it to another tab later on ## References #5907 ## Validation Steps Performed User-end behaviour is the same --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29697
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?