SettingsUI: Add new ... StartingDirectory/Browse greyed out #13702

claunia commented

@PankajBhojwani commented on GitHub (May 3, 2021):

This sounds similar to #9847 (but that was fixed...), have you set the default directory under 'defaults' in your settings.json file?

@PankajBhojwani commented on GitHub (May 3, 2021): This sounds similar to #9847 (but that was fixed...), have you set the default directory under 'defaults' in your settings.json file?

claunia commented

@vefatica commented on GitHub (May 3, 2021):

No, a default directory is not specified in 'defaults'.

@vefatica commented on GitHub (May 3, 2021): No, a default directory is **not** specified in 'defaults'.

claunia commented

@PankajBhojwani commented on GitHub (May 3, 2021):

Hm I can't seem to repro this (I am on WT 1.9 though). Could you share what is in the 'profiles' section of your settings file?

@PankajBhojwani commented on GitHub (May 3, 2021): Hm I can't seem to repro this (I am on WT 1.9 though). Could you share what is in the 'profiles' section of your settings file?

claunia commented

@vefatica commented on GitHub (May 3, 2021):

Sure (see below). Here's a bigger pic.

Interesting: Inthe JSON file, I don't see "commandline" (or a GUID) for the "Hidden" profile (shown in the pic).

"profiles": 
 {
     "defaults": 
     {
         "closeOnExit": "always",
         "colorScheme": "Vintage",
         "cursorColor": "#C0C0C0",
         "cursorHeight": 25,
         "cursorShape": "vintage",
         "fontFace": "Consolas",
         "fontSize": 13,
         "padding": "8,8,8,8",
         "tabColor": "#A0A0A0"
     },
     "list": 
     [
         {
             "commandline": "d:\\tc26\\tcc.exe",
             "guid": "{ecfa30ac-7c15-41c5-9f0f-886fff57c6ba}",
             "hidden": false,
             "icon": "d:\\tc26\\icon1.ico",
             "name": "TCC26",
             "startingDirectory": "v:\\"
         },
         {
             "commandline": "powershell.exe -NoLogo",
             "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
             "hidden": false,
             "icon": "U:\\Icons\\Powershell.png",
             "name": "PowerShell",
             "startingDirectory": "v:\\"
         },
         {
             "commandline": "cmd.exe",
             "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
             "hidden": false,
             "icon": "u:\\icons\\cmd.png",
             "name": "CMD",
             "startingDirectory": "v:\\"
         },
         {
             "commandline": "s:\\openssh\\ssh.exe vefatica@zz",
             "guid": "{c181173e-364d-4f45-ba0b-283730051162}",
             "hidden": false,
             "name": "ZZ-SSH"
         },
         {
             "commandline": "ssh vefatica@jj",
             "guid": "{e9e07f85-cbe3-46e5-af68-138a37ed8f4d}",
             "hidden": false,
             "name": "JJ-SSH"
         },
         {
             "commandline": "d:\\tc27\\tcc.exe",
             "guid": "{2345dfcd-6e9b-4897-b32d-40bb2d6c8039}",
             "hidden": false,
             "icon": "u:\\icons\\tccicon1.ico",
             "name": "TCC27",
             "startingDirectory": "v:\\"
         },
         {
             "commandline": "wsl.exe",
             "guid": "{4ba2fd44-db0a-44c1-95c2-ee4e55916fa1}",
             "hidden": false,
             "name": "**Ubuntu**"
         },
         {
             "closeOnExit": "never",
             "hidden": true,
             "name": "Hidden",
             "tabTitle": "Hidden"
         }
     ]
 }

@vefatica commented on GitHub (May 3, 2021): Sure (see below). Here's a bigger pic. Interesting: Inthe JSON file, I don't see "commandline" (or a GUID) for the "Hidden" profile (shown in the pic). ![image](https://user-images.githubusercontent.com/61856645/116839538-bda8b780-aba0-11eb-9e16-9d00e2519545.png) ``` "profiles": { "defaults": { "closeOnExit": "always", "colorScheme": "Vintage", "cursorColor": "#C0C0C0", "cursorHeight": 25, "cursorShape": "vintage", "fontFace": "Consolas", "fontSize": 13, "padding": "8,8,8,8", "tabColor": "#A0A0A0" }, "list": [ { "commandline": "d:\\tc26\\tcc.exe", "guid": "{ecfa30ac-7c15-41c5-9f0f-886fff57c6ba}", "hidden": false, "icon": "d:\\tc26\\icon1.ico", "name": "TCC26", "startingDirectory": "v:\\" }, { "commandline": "powershell.exe -NoLogo", "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}", "hidden": false, "icon": "U:\\Icons\\Powershell.png", "name": "PowerShell", "startingDirectory": "v:\\" }, { "commandline": "cmd.exe", "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}", "hidden": false, "icon": "u:\\icons\\cmd.png", "name": "CMD", "startingDirectory": "v:\\" }, { "commandline": "s:\\openssh\\ssh.exe vefatica@zz", "guid": "{c181173e-364d-4f45-ba0b-283730051162}", "hidden": false, "name": "ZZ-SSH" }, { "commandline": "ssh vefatica@jj", "guid": "{e9e07f85-cbe3-46e5-af68-138a37ed8f4d}", "hidden": false, "name": "JJ-SSH" }, { "commandline": "d:\\tc27\\tcc.exe", "guid": "{2345dfcd-6e9b-4897-b32d-40bb2d6c8039}", "hidden": false, "icon": "u:\\icons\\tccicon1.ico", "name": "TCC27", "startingDirectory": "v:\\" }, { "commandline": "wsl.exe", "guid": "{4ba2fd44-db0a-44c1-95c2-ee4e55916fa1}", "hidden": false, "name": "**Ubuntu**" }, { "closeOnExit": "never", "hidden": true, "name": "Hidden", "tabTitle": "Hidden" } ] } ```

claunia commented

@vefatica commented on GitHub (May 3, 2021):

Really strange! I restarted WIndows Terminal and I still see a command line for "Hidden" in the UI and I don't see one in the JSON file.

{
"closeOnExit": "never",
"hidden": true,
"name": "Hidden",
"tabTitle": "Hidden"
}

@vefatica commented on GitHub (May 3, 2021): Really strange! I restarted WIndows Terminal and I still see a command line for "Hidden" in the UI and I don't see one in the JSON file. ![image](https://user-images.githubusercontent.com/61856645/116840246-2002b780-aba3-11eb-9a04-0b1e51c371aa.png) { "closeOnExit": "never", "hidden": true, "name": "Hidden", "tabTitle": "Hidden" }

claunia commented

@PankajBhojwani commented on GitHub (May 3, 2021):

Really strange! I restarted WIndows Terminal and I still see a command line for "Hidden" in the UI and I don't see one in the JSON file.

That is expected! When a profile in the settings file does not explicitly define a commandline, we give it a 'default' commandline, which is cmd (that is technically an oversimplification of the way we handle settings but the gist is there).

@PankajBhojwani commented on GitHub (May 3, 2021): > Really strange! I restarted WIndows Terminal and I still see a command line for "Hidden" in the UI and I don't see one in the JSON file. That is expected! When a profile in the settings file does not explicitly define a commandline, we give it a 'default' commandline, which is cmd (that is technically an oversimplification of the way we handle settings but the gist is there).

claunia commented

@vefatica commented on GitHub (May 3, 2021):

I typed "cmd.exe" in the "Command line" field of the UI. It still doesn't appear in the JSON file.

I changed it to c:\windows\system32\cmd.exe and it appeared in the JSON file.

I changed it back to "cmd.exe". Now it appears as "cmd.exe" in the JSON file.

And all the time, "Starting Directory" and "Browse" are greyed out.

@vefatica commented on GitHub (May 3, 2021): I typed "cmd.exe" in the "Command line" field of the UI. It still doesn't appear in the JSON file. I changed it to c:\windows\system32\cmd.exe and it appeared in the JSON file. I changed it back to "cmd.exe". Now it appears as "cmd.exe" in the JSON file. And all the time, "Starting Directory" and "Browse" are greyed out.

claunia commented

@gokulyc commented on GitHub (May 3, 2021):

Windows Terminal Preview : Version: 1.8.1032.0

Unable to modify starting directory, everything else is working fine:

@gokulyc commented on GitHub (May 3, 2021): Windows Terminal Preview : Version: 1.8.1032.0 Unable to modify starting directory, everything else is working fine: ![WindowsTerminal_tvcAzLUBSF](https://user-images.githubusercontent.com/13468848/116852572-2f6d1980-ac12-11eb-9963-48f202db7246.png)

claunia commented

@vefatica commented on GitHub (May 3, 2021):

Hmmm! I use "Add new". "Cmd.exe" is automatically placed in the UI field but not in the JSON file. In the UI, I erase it and enter "cmd.exe"; it still does not go into the JSON file. In the UI, I change it to "s:\cmd.exe"; now it's in the JSON file. In the UI, I change it back to "cmd.exe"; now it's in the JSON file (the same string that wasn't in the JSON file in the first place). Isn't that a bit goofy? Can't it simply always go into the JSON file?

And what about GUIDs? You don't get one with "Add new". Are GUIDs necessary, ever?

@vefatica commented on GitHub (May 3, 2021): Hmmm! I use "Add new". "Cmd.exe" is automatically placed in the UI field but not in the JSON file. In the UI, I erase it and enter "cmd.exe"; it still does not go into the JSON file. In the UI, I change it to "s:\cmd.exe"; now it's in the JSON file. In the UI, I change it back to "cmd.exe"; now it's in the JSON file (the same string that wasn't in the JSON file in the first place). Isn't that a bit goofy? Can't it simply always go into the JSON file? And what about GUIDs? You don't get one with "Add new". Are GUIDs necessary, ever?

claunia commented

@htcfreek commented on GitHub (May 3, 2021):

Same for me:

no guid in json
can't change starting directory

@htcfreek commented on GitHub (May 3, 2021): Same for me: - no guid in json - can't change starting directory

claunia commented