starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13702] [MERGED] Stop writing optional theme fields #29719

New Issue
Open
opened 2026-01-31 09:36:30 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:36:30 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13702
Author: @lhecker
Created: 8/9/2022
Status: ✅ Merged
Merged: 8/10/2022
Merged by: @undefined

Base: main ← Head: dev/lhecker/13544-theme-optionals

📝 Commits (1)

  • 9610ac8 Stop writing all optional theme fields

📊 Changes

2 files changed (+34 additions, -30 deletions)

View changed files

📝 src/cascadia/TerminalSettingsModel/Theme.cpp (+30 -13)
📝 src/cascadia/TerminalSettingsModel/Theme.h (+4 -17)

📄 Description

Other settings model classes call JsonUtils::SetValueForKey with the
private _##value member as the value. Since _##value is an optional,
this prevented writing out unset, optional fields. The new Themes class
deviated from this and this commit brings it back in line with the others.

Closes #13544

Validation Steps Performed

  • Create a { "name": "test" } theme
  • Save settings via the UI
  • Optional/Defaulted fields aren't written ✅

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13702 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 8/9/2022 **Status:** ✅ Merged **Merged:** 8/10/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/13544-theme-optionals` --- ### 📝 Commits (1) - [`9610ac8`](https://github.com/microsoft/terminal/commit/9610ac817b9b03414ba11b2480ba94e12e0e8b11) Stop writing all optional theme fields ### 📊 Changes **2 files changed** (+34 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsModel/Theme.cpp` (+30 -13) 📝 `src/cascadia/TerminalSettingsModel/Theme.h` (+4 -17) </details> ### 📄 Description Other settings model classes call `JsonUtils::SetValueForKey` with the private `_##value` member as the value. Since `_##value` is an optional, this prevented writing out unset, optional fields. The new `Themes` class deviated from this and this commit brings it back in line with the others. Closes #13544 ## Validation Steps Performed * Create a `{ "name": "test" }` theme * Save settings via the UI * Optional/Defaulted fields aren't written ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:30 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29719
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?