starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Settings> Add a new profile]: The Name property must not include the element's control type. #15102

New Issue
Closed
opened 2026-01-31 04:28:39 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 04:28:39 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Sep 6, 2021).

Windows Terminal version (or Windows build number)

1.10.2383.0

Other Software

Test Environment:
OS: Windows 11 Version 21H2 (OS Build 22000.168)
Screen Reader: Narrator
Tool: Accessibility Insights for Windows Version 1.1.1689.01

Steps to reproduce

Repro Steps:

  1. Open Windows Terminal.
  2. Open Settings page using "Ctrl + ',' ".
  3. Run Accessibility insights for Window on Settings Add a new Profile tab page and observe the issue.

User Experience: -> Priority 3
Screen Reader user are impacted here as control type is announced twice with control name which is confusing.

Guideline Reference:
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value

Attachments:
The Name property must not include the element's control type..zip

Expected Behavior

The Name property must not include the element's control type. For 'New Empty Profile' Screen Reader should announce 'Create new Empty Profile button' and for 'Duplicate' Screen Reader should announce 'Duplicate button'.

Actual Behavior

The Name property has the element's control type. For 'New Empty Profile' button Screen Reader is announcing 'Create new button button' and For 'Duplicate' button Screen Reader is announcing 'Duplicate button button'.

Note Issue: The Name must not include the same text as the LocalizedControlType.

Originally created by @ghost on GitHub (Sep 6, 2021). ### Windows Terminal version (or Windows build number) 1.10.2383.0 ### Other Software **Test Environment:** OS: Windows 11 Version 21H2 (OS Build 22000.168) Screen Reader: Narrator Tool: Accessibility Insights for Windows Version 1.1.1689.01 ### Steps to reproduce **Repro Steps:** 1. Open Windows Terminal. 2. Open Settings page using "Ctrl + ',' ". 3. Run Accessibility insights for Window on Settings Add a new Profile tab page and observe the issue. **User Experience: -> Priority 3** Screen Reader user are impacted here as control type is announced twice with control name which is confusing. **Guideline Reference:** https://www.w3.org/WAI/WCAG21/Understanding/name-role-value **Attachments:** [The Name property must not include the element's control type..zip](https://github.com/microsoft/terminal/files/7115865/The.Name.property.must.not.include.the.element.s.control.type.zip) ### Expected Behavior The Name property must not include the element's control type. For 'New Empty Profile' Screen Reader should announce 'Create new Empty Profile button' and for 'Duplicate' Screen Reader should announce 'Duplicate button'. ### Actual Behavior The Name property has the element's control type. For 'New Empty Profile' button Screen Reader is announcing 'Create new button button' and For 'Duplicate' button Screen Reader is announcing 'Duplicate button button'. **Note Issue:** The Name must not include the same text as the LocalizedControlType.
claunia commented 2026-01-31 04:28:41 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Dec 21, 2021):

Issue repro in Windows Terminal Preview Version: 1.12.3472.0

Actual: For 'New Empty Profile' Screen Reader is announcing 'Create New button button' and For 'Duplicate' control Screen Reader is announcing 'Duplicate button button'.

Expected: For 'New Empty Profile' Screen Reader should announce 'New Empty Profile button' and for 'Duplicate' control Screen Reader should announce 'Duplicate Profile button'.

@ghost commented on GitHub (Dec 21, 2021): Issue repro in Windows Terminal Preview Version: 1.12.3472.0 **Actual:** For 'New Empty Profile' Screen Reader is announcing 'Create New button button' and For 'Duplicate' control Screen Reader is announcing 'Duplicate button button'. **Expected:** For 'New Empty Profile' Screen Reader should announce 'New Empty Profile button' and for 'Duplicate' control Screen Reader should announce 'Duplicate Profile button'.
claunia commented 2026-01-31 04:28:41 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Sep 11, 2024):

Fixed by #12324 a while back. Should be available on versions 1.14.1432 or greater

@carlos-zamora commented on GitHub (Sep 11, 2024): Fixed by #12324 a while back. Should be available on versions 1.14.1432 or greater
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11ySev3 A11yWCAG Area-Accessibility Area-SettingsUI HCL-E+D HCL-WindowsTerminal Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15102
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?