starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Pixel shader config file #12324

New Issue
Closed
opened 2026-01-31 03:12:22 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 03:12:22 +00:00
Owner
Copy Link

Originally created by @amoldeshpande on GitHub (Jan 30, 2021).

I am aware this is looking that gift horse straight in the chompers, but I'd like to see a separate config file for pixel shaders.

My evil scheme is to extend one of the prompt configuration utilities (like oh-my-posh) to change the shader based on some external state . I mean, who doesn't want an actual dumpster fire with smoke in the terminal when they're working in the COBOL repo ?

I can see doing this now by changing the settings file, but it would be nice to be not screw up the entire profile if something goes wrong (race conditions with other things changing the file etc.)

Proposed technical implementation details (optional)

add a setting like experimental.pixelShaderStandalonePath to a file that contains just a filename (or if you want consistency, a json snippet like the current settings for pixel shaders)

Originally created by @amoldeshpande on GitHub (Jan 30, 2021). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> I am aware this is looking that gift horse straight in the chompers, but I'd like to see a separate config file for pixel shaders. My evil scheme is to extend one of the prompt configuration utilities (like oh-my-posh) to change the shader based on some external state . I mean, who doesn't want an actual dumpster fire with smoke in the terminal when they're working in the COBOL repo ? I can see doing this now by changing the settings file, but it would be nice to be not screw up the entire profile if something goes wrong (race conditions with other things changing the file etc.) # Proposed technical implementation details (optional) add a setting like `experimental.pixelShaderStandalonePath` to a file that contains just a filename (or if you want consistency, a json snippet like the current settings for pixel shaders)
claunia commented 2026-01-31 03:12:25 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 1, 2021):

Hmm. This might sound like a crazy idea, but this could be an application for settings fragments (#7632). Like, you have just a single file that's

{
  "profiles": [
    {
      "extends": "{whatever the guid is for the profile in question}",
      "experimental.pixelShaderPath": "whatever.hlsl"
    }
  ]
}

then you could modify just that file, and have the Terminal hot-reload the settings when that file changes.

I guess, this isn't that much better than just modifying the settings.json file directly, but at least you could be relatively confident that no one else would be touching that file.

/cc @PankajBhojwani as an fyi

@zadjii-msft commented on GitHub (Feb 1, 2021): Hmm. This might sound like a crazy idea, but this could be an application for settings fragments (#7632). Like, you have just a single file that's ```jsonc { "profiles": [ { "extends": "{whatever the guid is for the profile in question}", "experimental.pixelShaderPath": "whatever.hlsl" } ] } ``` then you could modify just that file, and have the Terminal hot-reload the settings when that file changes. I guess, this isn't that much better than just modifying the `settings.json` file directly, but at least you could be relatively confident that no one else would be touching that file. /cc @PankajBhojwani as an fyi
claunia commented 2026-01-31 03:12:25 +00:00
Author
Owner
Copy Link

@amoldeshpande commented on GitHub (Feb 1, 2021):

Sounds good. I didn't much like the idea of a one-off config key myself.

@amoldeshpande commented on GitHub (Feb 1, 2021): Sounds good. I didn't much like the idea of a one-off config key myself.
claunia commented 2026-01-31 03:12:25 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 1, 2021):

Okay cool. That should be coming in 1.7 (along with docs how to use it)!

@zadjii-msft commented on GitHub (Feb 1, 2021): Okay cool. That should be coming in 1.7 (along with docs how to use it)!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Question Needs-Triage Product-Terminal Resolution-Answered
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12324
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?